fix: autofix new clippy lint from rust 1.87.0

by running `cargo clippy --all-features --all-targets --fix`

two fixes mainly were autofixable with this release:
* https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
* https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error

Author: Alenar

examples/client-cardano-database-v2/src/main.rs

@@ -131,7 +131,7 @@ async fn main() -> MithrilResult<()> {
         )
         .await
     {
-        println!("Could not send usage statistics to the aggregator: {:?}", e);
+        println!("Could not send usage statistics to the aggregator: {e:?}");
     }
 
     println!(

examples/client-cardano-database/src/main.rs

@@ -89,7 +89,7 @@ async fn main() -> MithrilResult<()> {
         .await?;
 
     if let Err(e) = client.cardano_database().add_statistics(&snapshot).await {
-        println!("Could not increment snapshot download statistics: {:?}", e);
+        println!("Could not increment snapshot download statistics: {e:?}");
     }
 
     println!("Computing snapshot '{}' message ...", snapshot.digest);
@@ -234,7 +234,7 @@ impl FeedbackReceiver for IndicatifFeedbackReceiver {
                 }
                 *certificate_validation_pb = None;
             }
-            _ => panic!("Unexpected event: {:?}", event),
+            _ => panic!("Unexpected event: {event:?}"),
         }
     }
 }

internal/mithril-build-script/src/fake_aggregator.rs

@@ -286,17 +286,14 @@ pub fn extract_cardano_stake_distribution_epochs(
         .map(|content| {
             let json_value: serde_json::Value =
                 serde_json::from_str(content).unwrap_or_else(|err| {
-                    panic!(
-                        "Failed to parse JSON in csd content: {}\nError: {}",
-                        content, err
-                    );
+                    panic!("Failed to parse JSON in csd content: {content}\nError: {err}");
                 });
 
             json_value
                 .get("epoch")
                 .and_then(|epoch| epoch.as_u64().map(|s| s.to_string()))
                 .unwrap_or_else(|| {
-                    panic!("Epoch not found or invalid in csd content: {}", content);
+                    panic!("Epoch not found or invalid in csd content: {content}");
                 })
         })
         .collect()
@@ -327,33 +324,30 @@ pub fn generate_artifact_getter(
             artifacts_list,
             r###"
         (
-            "{}",
-            r#"{}"#
-        ),"###,
-            artifact_id, file_content
+            "{artifact_id}",
+            r#"{file_content}"#
+        ),"###
         )
         .unwrap();
     }
 
     format!(
-        r###"pub(crate) fn {}() -> BTreeMap<String, String> {{
-    [{}
+        r###"pub(crate) fn {fun_name}() -> BTreeMap<String, String> {{
+    [{artifacts_list}
     ]
     .into_iter()
     .map(|(k, v)| (k.to_owned(), v.to_owned()))
     .collect()
-}}"###,
-        fun_name, artifacts_list
+}}"###
     )
 }
 
 /// pub(crate) fn $fun_name() -> &'static str
 pub fn generate_list_getter(fun_name: &str, source_json: FileContent) -> String {
     format!(
-        r###"pub(crate) fn {}() -> &'static str {{
-    r#"{}"#
-}}"###,
-        fun_name, source_json
+        r###"pub(crate) fn {fun_name}() -> &'static str {{
+    r#"{source_json}"#
+}}"###
     )
 }
 
@@ -365,8 +359,7 @@ pub fn generate_ids_array(array_name: &str, ids: BTreeSet<ArtifactId>) -> String
         write!(
             ids_list,
             r#"
-        "{}","#,
-            id
+        "{id}","#
         )
         .unwrap();
     }

internal/mithril-build-script/src/open_api.rs

@@ -60,11 +60,10 @@ pub fn generate_open_api_versions_mapping(open_api_spec_files: &[PathBuf]) -> St
 /// Build Open API versions mapping
 pub fn get_open_api_versions_mapping() -> HashMap<OpenAPIFileName, semver::Version> {{
     HashMap::from([
-        {}
+        {open_api_versions_hashmap}
     ])
 }}
-        "#,
-        open_api_versions_hashmap
+        "#
     )
 }
 

internal/mithril-cli-helper/src/source_config.rs

@@ -142,7 +142,7 @@ mod tests {
             map,
             &"namespace".to_string(),
             fake.string_value,
-            |v: String| { format!("mapped_value from {}", v) }
+            |v: String| { format!("mapped_value from {v}") }
         );
 
         let expected = HashMap::from([(
@@ -200,7 +200,7 @@ mod tests {
             map,
             &"namespace".to_string(),
             fake.option_with_value,
-            |v: String| format!("mapped_value from {}", v)
+            |v: String| format!("mapped_value from {v}")
         );
         register_config_value_option!(map, &"namespace".to_string(), fake.option_none);
 

internal/mithril-doc/src/extract_clap_info.rs

@@ -5,8 +5,8 @@ use super::{FieldDoc, StructDoc};
 /// Extract information of an command line argument.
 fn extract_arg(arg: &Arg) -> FieldDoc {
     let parameter = arg.get_id().to_string();
-    let short_option = arg.get_short().map_or("".into(), |c| format!("-{}", c));
-    let long_option = arg.get_long().map_or("".into(), |c| format!("--{}", c));
+    let short_option = arg.get_short().map_or("".into(), |c| format!("-{c}"));
+    let long_option = arg.get_long().map_or("".into(), |c| format!("--{c}"));
     let env_variable = arg.get_env().map(|s| format!("{}", s.to_string_lossy()));
     let description = arg.get_help().map_or("-".into(), StyledStr::to_string);
     let default_value = if arg.get_default_values().iter().count() == 0 {

internal/mithril-doc/src/lib.rs

@@ -158,19 +158,19 @@ pub struct GenerateDocCommands {
 impl GenerateDocCommands {
     fn save_doc(&self, cmd_name: &str, doc: &str) -> Result<(), String> {
         let output = if self.output.as_str() == DEFAULT_OUTPUT_FILE_TEMPLATE {
-            format!("{}-command-line.md", cmd_name)
+            format!("{cmd_name}-command-line.md")
         } else {
             self.output.clone()
         };
 
         match File::create(&output) {
             Ok(mut buffer) => {
-                if write!(buffer, "\n{}", doc).is_err() {
-                    return Err(format!("Error writing in {}", output));
+                if write!(buffer, "\n{doc}").is_err() {
+                    return Err(format!("Error writing in {output}"));
                 }
                 println!("Documentation generated in file `{}`", &output);
             }
-            _ => return Err(format!("Could not create {}", output)),
+            _ => return Err(format!("Could not create {output}")),
         };
         Ok(())
     }
@@ -190,7 +190,7 @@ impl GenerateDocCommands {
         let cmd_name = cmd_to_document.get_name();
 
         println!("Please note: the documentation generated is not able to indicate the environment variables used by the commands.");
-        self.save_doc(cmd_name, format!("\n{}", doc).as_str())
+        self.save_doc(cmd_name, format!("\n{doc}").as_str())
     }
 }
 

internal/mithril-doc/src/markdown_formatter.rs

@@ -87,7 +87,7 @@ pub fn doc_markdown_with_config(cmd: &mut Command, configs: HashMap<String, Stru
 
             let parameters_table = doc_config_to_markdown(&command_parameters);
 
-            format!("{}\n{}", parameters_explanation, parameters_table)
+            format!("{parameters_explanation}\n{parameters_table}")
         } else {
             "".to_string()
         }
@@ -145,7 +145,7 @@ pub fn doc_markdown_with_config(cmd: &mut Command, configs: HashMap<String, Stru
         level: usize,
         parameters_explanation: &str,
     ) -> String {
-        let parent_path = parent.map(|s| format!("{} ", s)).unwrap_or_default();
+        let parent_path = parent.map(|s| format!("{s} ")).unwrap_or_default();
         let command_path = format!("{}{}", parent_path, cmd.get_name());
 
         let title = format!("{} {}\n", "#".repeat(level), command_path);
@@ -204,11 +204,11 @@ pub fn doc_config_to_markdown(struct_doc: &StructDoc) -> String {
                 },
                 config
                     .environment_variable
-                    .map_or_else(|| "-".to_string(), |x| format!("`{}`", x)),
+                    .map_or_else(|| "-".to_string(), |x| format!("`{x}`")),
                 config.description.replace('\n', "<br/>"),
                 config
                     .default_value
-                    .map(|value| format!("`{}`", value))
+                    .map(|value| format!("`{value}`"))
                     .unwrap_or("-".to_string()),
                 config
                     .example
@@ -509,7 +509,7 @@ mod tests {
 
         let mut command = MyCommand::command();
         let crate_name = format_clap_command_name_to_key(env!("CARGO_PKG_NAME"));
-        let configs = HashMap::from([(format!("{} subcommanda", crate_name), struct_doc)]);
+        let configs = HashMap::from([(format!("{crate_name} subcommanda"), struct_doc)]);
         let doc = doc_markdown_with_config(&mut command, configs);
 
         assert!(doc.contains("| `ConfigA` |"), "Generated doc: {doc}");

internal/mithril-metric/src/server.rs

@@ -31,7 +31,7 @@ impl IntoResponse for MetricsServerError {
     fn into_response(self) -> Response<Body> {
         match self {
             Self::Internal(e) => {
-                (StatusCode::INTERNAL_SERVER_ERROR, format!("Error: {:?}", e)).into_response()
+                (StatusCode::INTERNAL_SERVER_ERROR, format!("Error: {e:?}")).into_response()
             }
         }
     }

internal/mithril-persistence/src/database/query/cardano_transaction/get_cardano_transaction.rs

@@ -125,10 +125,10 @@ mod tests {
         slot_number: SlotNumber,
     ) -> CardanoTransactionRecord {
         CardanoTransactionRecord::new(
-            format!("tx-hash-{}", slot_number),
+            format!("tx-hash-{slot_number}"),
             block_number,
             slot_number,
-            format!("block-hash-{}", block_number),
+            format!("block-hash-{block_number}"),
         )
     }