refactor(client-cli): make unused param in v2 warning reusable

- move it from the cardano db download module to its parent
  module so all cardano db commmands can use it.
- make the unused parameters list configurable

Author: Alenar

mithril-client-cli/src/commands/cardano_db/download/mod.rs

@@ -9,7 +9,7 @@ use std::{collections::HashMap, path::PathBuf};
 
 use crate::{
     CommandContext,
-    commands::cardano_db::CardanoDbCommandsBackend,
+    commands::cardano_db::{CardanoDbCommandsBackend, warn_unused_parameter_with_v1_backend},
     configuration::{ConfigError, ConfigSource},
     utils::{self, JSON_CAUTION_KEY},
 };
@@ -89,7 +89,10 @@ impl CardanoDbDownloadCommand {
 
     fn prepare_v1(&self, context: &CommandContext) -> MithrilResult<PreparedCardanoDbV1Download> {
         if self.allow_override || self.start.is_some() || self.end.is_some() {
-            self.warn_unused_parameter_with_v1_backend(context);
+            warn_unused_parameter_with_v1_backend(
+                context,
+                ["--start", "--end", "--allow_override"],
+            );
         }
 
         let ancillary_verification_key = if self.include_ancillary {
@@ -164,17 +167,6 @@ For more information, please refer to the network configuration page of the docu
             eprintln!("{message}");
         }
     }
-
-    fn warn_unused_parameter_with_v1_backend(&self, context: &CommandContext) {
-        let message = "`--start`, `--end`, and `--allow-override` are only available with the `v2` backend. They will be ignored.";
-        if context.is_json_output_enabled() {
-            eprintln!(r#"{{"{JSON_CAUTION_KEY}":"{message}"}}"#);
-        } else {
-            eprintln!("{message}");
-            // Add a blank line to separate this message from the one related to the fast bootstrap that comes next.
-            eprintln!();
-        }
-    }
 }
 
 impl ConfigSource for CardanoDbDownloadCommand {

mithril-client-cli/src/commands/cardano_db/mod.rs

@@ -74,3 +74,65 @@ impl CardanoDbSnapshotCommands {
         }
     }
 }
+
+/// Print in stderr that the given parameters are not available with the v1 backend and will be ignored
+pub fn warn_unused_parameter_with_v1_backend<const N: usize>(
+    context: &CommandContext,
+    v2_only_parameters: [&str; N],
+) {
+    use crate::utils::JSON_CAUTION_KEY;
+
+    let message = format_unused_parameter_with_v1_backend(v2_only_parameters);
+    if context.is_json_output_enabled() {
+        eprintln!(r#"{{"{JSON_CAUTION_KEY}":"{message}"}}"#);
+    } else {
+        eprintln!("{message}");
+        // Add a blank line to separate this message from the one related to the fast bootstrap that comes next.
+        eprintln!();
+    }
+}
+
+fn format_unused_parameter_with_v1_backend<const N: usize>(
+    v2_only_parameters: [&str; N],
+) -> String {
+    match v2_only_parameters.len() {
+        0 => String::new(),
+        1 => format!(
+            "`{}` is only available with the `v2` backend. It will be ignored.",
+            v2_only_parameters[0]
+        ),
+        n => {
+            format!(
+                "`{}`, and `{}` are only available with the `v2` backend. They will be ignored.",
+                v2_only_parameters[..n - 1].join("`, `"),
+                v2_only_parameters[n - 1]
+            )
+        }
+    }
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn test_format_unused_parameter_with_v1_backend() {
+        assert_eq!(format_unused_parameter_with_v1_backend([]), String::new());
+
+        assert_eq!(
+            format_unused_parameter_with_v1_backend(["--test"]),
+            "`--test` is only available with the `v2` backend. It will be ignored.".to_string()
+        );
+
+        assert_eq!(
+            format_unused_parameter_with_v1_backend(["--foo", "--bar"]),
+            "`--foo`, and `--bar` are only available with the `v2` backend. They will be ignored."
+                .to_string()
+        );
+
+        assert_eq!(
+            format_unused_parameter_with_v1_backend(["--test", "--foo", "--bar"]),
+            "`--test`, `--foo`, and `--bar` are only available with the `v2` backend. They will be ignored.".to_string()
+        );
+    }
+}