Skip to content

Commit 7c077cb

Browse files
authored
Merge pull request #2008 from input-output-hk/dlachaume/fix-upgrade-dependencies-runbook
Fix: update dependencies runbook and script
2 parents 1a941b7 + fb3a449 commit 7c077cb

File tree

2 files changed

+23
-21
lines changed

2 files changed

+23
-21
lines changed

docs/runbook/upgrade-repository-dependencies/README.md

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -84,38 +84,40 @@ chore: upgrade doc dependencies
8484
By running 'make upgrade' command.
8585
```
8686

87-
### Upgrade the explorer dependencies
87+
### Upgrade `www/` and `www-test/` dependencies
8888

8989
From the root of the repository, run:
9090

91+
[!IMPORTANT]: This command must be run before upgrading `mithril-explorer`.
92+
9193
```bash
92-
cd mithril-explorer
93-
make upgrade
94+
cd mithril-client-wasm
95+
make upgrade-www-deps
9496
```
9597

9698
Create a dedicated commit, e.g.:
9799

98100
```bash
99-
chore: upgrade explorer dependencies
101+
chore: upgrade mithril client wasm 'www' and 'www-test' dependencies
100102

101-
By running 'make upgrade' command.
103+
By running 'make upgrade-www-deps' command.
102104
```
103105

104-
### Upgrade `www/` and `www-test/` dependencies
106+
### Upgrade the explorer dependencies
105107

106108
From the root of the repository, run:
107109

108110
```bash
109-
cd mithril-client-wasm
110-
make upgrade-www-deps
111+
cd mithril-explorer
112+
make upgrade
111113
```
112114

113115
Create a dedicated commit, e.g.:
114116

115117
```bash
116-
chore: upgrade mithril client wasm 'www' and 'www-test' dependencies
118+
chore: upgrade explorer dependencies
117119

118-
By running 'make upgrade-www-deps' command.
120+
By running 'make upgrade' command.
119121
```
120122

121123
### Bump Javascript packages versions
@@ -142,7 +144,7 @@ make install
142144
Create a dedicated commit, e.g.:
143145

144146
```bash
145-
chore: bump mithril client wasm 'www' and 'www-test' dependencies
147+
chore: bump javascript packages versions
146148

147149
By running:
148150
- 'make www-install' command in 'mithril-client-wasm'.

docs/runbook/upgrade-repository-dependencies/upgrade_dependencies.sh

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,6 @@ git commit -am "chore: upgrade doc dependencies
2626
2727
By running 'make upgrade' command."
2828

29-
# Upgrade the explorer dependencies
30-
pushd mithril-explorer || exit
31-
make upgrade
32-
popd || exit
33-
git commit -am "chore: upgrade explorer dependencies
34-
35-
By running 'make upgrade' command."
36-
3729
# Upgrade www/ and www-test/ dependencies
3830
pushd mithril-client-wasm || exit
3931
make upgrade-www-deps
@@ -43,11 +35,19 @@ git commit -am "chore: upgrade mithril client wasm 'www' and 'www-test' dependen
4335
4436
By running 'make upgrade-www-deps' command."
4537

38+
# Upgrade the explorer dependencies
39+
pushd mithril-explorer || exit
40+
make upgrade
41+
popd || exit
42+
git commit -am "chore: upgrade explorer dependencies
43+
44+
By running 'make upgrade' command."
45+
4646
# Bump Javascript packages versions
4747

4848
# Search all package.json files and bump the version
4949
# and exclude `package.json` in `node_modules` folder
50-
for package_json_file in $(find . -name package.json | grep -v "/node_modules/"); do
50+
for package_json_file in $(find . -name package.json | grep -v "/node_modules/" | grep -v "/pkg/"); do
5151
folder="$(dirname $package_json_file)"
5252
pushd "$folder" || exit
5353
npm version patch
@@ -66,7 +66,7 @@ pushd docs/website || exit
6666
make install
6767
popd || exit
6868

69-
git commit -am "chore: bump mithril client wasm 'www' and 'www-test' dependencies
69+
git commit -am "chore: bump javascript packages versions
7070
7171
By running:
7272
- 'make www-install' command in 'mithril-client-wasm'.

0 commit comments

Comments
 (0)