Merge pull request #1244 from input-output-hk/ensemble/1127-fix-record-statistics

Fix record download statistics

Author: jpraynaud

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-aggregator"
-version = "0.3.94"
+version = "0.3.95"
 description = "A Mithril Aggregator server"
 authors = { workspace = true }
 edition = { workspace = true }

mithril-aggregator/Cargo.toml

@@ -26,22 +26,22 @@ fn post_statistics(
 mod handlers {
     use std::{convert::Infallible, sync::Arc};
 
-    use mithril_common::messages::SnapshotMessage;
+    use mithril_common::messages::SnapshotDownloadMessage;
     use reqwest::StatusCode;
 
     use crate::event_store::{EventMessage, TransmitterService};
     use crate::http_server::routes::reply;
 
     pub async fn post_snapshot_statistics(
-        snapshot_message: SnapshotMessage,
+        snapshot_download_message: SnapshotDownloadMessage,
         event_transmitter: Arc<TransmitterService<EventMessage>>,
     ) -> Result<impl warp::Reply, Infallible> {
         let headers: Vec<(&str, &str)> = Vec::new();
 
         match event_transmitter.send_event_message(
             "HTTP::statistics",
             "snapshot_downloaded",
-            &snapshot_message,
+            &snapshot_download_message,
             headers,
         ) {
             Err(e) => Ok(reply::internal_server_error(e)),
@@ -54,7 +54,7 @@ mod handlers {
 mod tests {
     use super::*;
 
-    use mithril_common::messages::SnapshotMessage;
+    use mithril_common::messages::SnapshotDownloadMessage;
     use mithril_common::test_utils::apispec::APISpec;
 
     use warp::{http::Method, test::request};
@@ -82,14 +82,14 @@ mod tests {
         let mut builder = DependenciesBuilder::new(config);
         let mut rx = builder.get_event_transmitter_receiver().await.unwrap();
         let dependency_manager = builder.build_dependency_container().await.unwrap();
-        let snapshot_message = SnapshotMessage::dummy();
+        let snapshot_download_message = SnapshotDownloadMessage::dummy();
 
         let method = Method::POST.as_str();
         let path = "/statistics/snapshot";
 
         let response = request()
             .method(method)
-            .json(&snapshot_message)
+            .json(&snapshot_download_message)
             .path(&format!("/{SERVER_BASE_PATH}{path}"))
             .reply(&setup_router(Arc::new(dependency_manager)))
             .await;
@@ -99,7 +99,7 @@ mod tests {
             method,
             path,
             "application/json",
-            &snapshot_message,
+            &snapshot_download_message,
             &response,
         );
 

mithril-aggregator/src/http_server/routes/statistics_routes.rs

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-client"
-version = "0.4.1"
+version = "0.4.2"
 description = "A Mithril Client"
 authors = { workspace = true }
 edition = { workspace = true }

mithril-client/Cargo.toml

@@ -159,7 +159,8 @@ impl AggregatorHTTPClient {
     /// Issue a POST HTTP request.
     #[async_recursion]
     async fn post(&self, url: &str, json: &str) -> Result<Response, AggregatorHTTPClientError> {
-        let request_builder = Client::new().post(url.to_owned()).json(json);
+        debug!("POST url='{url}' json='{json}'.");
+        let request_builder = Client::new().post(url.to_owned()).body(json.to_owned());
         let current_api_version = self
             .compute_current_api_version()
             .await
@@ -177,7 +178,7 @@ impl AggregatorHTTPClient {
         })?;
 
         match response.status() {
-            StatusCode::OK => Ok(response),
+            StatusCode::OK | StatusCode::CREATED => Ok(response),
             StatusCode::PRECONDITION_FAILED => {
                 if self.discard_current_api_version().await.is_some()
                     && !self.api_versions.read().await.is_empty()

mithril-client/src/aggregator_client/http_client.rs

@@ -6,12 +6,14 @@ use thiserror::Error;
 
 use mithril_common::{
     entities::Snapshot,
-    messages::{SnapshotListItemMessage, SnapshotListMessage, SnapshotMessage},
+    messages::{SnapshotListItemMessage, SnapshotListMessage, SnapshotMessage, ToMessageAdapter},
     StdResult,
 };
 
-use crate::aggregator_client::AggregatorClient;
 use crate::utils::DownloadProgressReporter;
+use crate::{
+    aggregator_client::AggregatorClient, message_adapters::ToSnapshotDownloadMessageAdapter,
+};
 
 /// Error for the Snapshot client
 #[derive(Error, Debug)]
@@ -77,7 +79,9 @@ impl SnapshotClient {
                 {
                     Ok(()) => {
                         // the snapshot download does not fail if the statistic call fails.
-                        let _ = self.add_statistics(snapshot).await;
+                        if let Err(e) = self.add_statistics(snapshot).await {
+                            warn!("Could not POST snapshot download statistics: {e:?}");
+                        }
 
                         Ok(())
                     }
@@ -101,7 +105,8 @@ impl SnapshotClient {
     /// Increments Aggregator's download statistics
     pub async fn add_statistics(&self, snapshot: &Snapshot) -> StdResult<()> {
         let url = "statistics/snapshot";
-        let json = serde_json::to_string(snapshot)?;
+        let snapshot_download_message = ToSnapshotDownloadMessageAdapter::adapt(snapshot);
+        let json = serde_json::to_string(&snapshot_download_message)?;
         let _response = self.http_client.post_content(url, &json).await?;
 
         Ok(())

mithril-client/src/aggregator_client/snapshot_client.rs

@@ -1,7 +1,9 @@
 mod from_certificate_message_adapter;
 mod from_mithril_stake_distribution_message;
 mod from_snapshot_message;
+mod to_snapshot_download_message;
 
 pub use from_certificate_message_adapter::FromCertificateMessageAdapter;
 pub use from_mithril_stake_distribution_message::FromMithrilStakeDistributionMessageAdapter;
 pub use from_snapshot_message::FromSnapshotMessageAdapter;
+pub use to_snapshot_download_message::ToSnapshotDownloadMessageAdapter;

mithril-client/src/message_adapters/mod.rs

@@ -0,0 +1,35 @@
+use mithril_common::entities::Snapshot;
+use mithril_common::messages::{SnapshotDownloadMessage, ToMessageAdapter};
+
+/// Adapter to convert [Snapshot] to [SnapshotDownloadMessage] instances
+pub struct ToSnapshotDownloadMessageAdapter;
+
+impl ToMessageAdapter<&Snapshot, SnapshotDownloadMessage> for ToSnapshotDownloadMessageAdapter {
+    /// Method to trigger the conversion
+    fn adapt(snapshot: &Snapshot) -> SnapshotDownloadMessage {
+        SnapshotDownloadMessage {
+            digest: snapshot.digest.clone(),
+            beacon: snapshot.beacon.clone(),
+            size: snapshot.size,
+            locations: snapshot.locations.clone(),
+            compression_algorithm: snapshot.compression_algorithm,
+            cardano_node_version: snapshot.cardano_node_version.clone(),
+        }
+    }
+}
+
+#[cfg(test)]
+mod tests {
+    use mithril_common::test_utils::fake_data;
+
+    use super::*;
+
+    #[test]
+    fn adapt_ok() {
+        let mut snapshot = fake_data::snapshots(1)[0].to_owned();
+        snapshot.digest = "digest123".to_string();
+        let snapshot_download_message = ToSnapshotDownloadMessageAdapter::adapt(&snapshot);
+
+        assert_eq!("digest123".to_string(), snapshot_download_message.digest);
+    }
+}

mithril-client/src/message_adapters/to_snapshot_download_message.rs

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-common"
-version = "0.2.114"
+version = "0.2.115"
 authors = { workspace = true }
 edition = { workspace = true }
 documentation = { workspace = true }

mithril-common/Cargo.toml

@@ -11,6 +11,7 @@ mod mithril_stake_distribution_list;
 mod register_signature;
 mod register_signer;
 mod snapshot;
+mod snapshot_download;
 mod snapshot_list;
 
 pub use certificate::CertificateMessage;
@@ -28,4 +29,5 @@ pub use mithril_stake_distribution_list::{
 pub use register_signature::RegisterSignatureMessage;
 pub use register_signer::RegisterSignerMessage;
 pub use snapshot::SnapshotMessage;
+pub use snapshot_download::SnapshotDownloadMessage;
 pub use snapshot_list::{SnapshotListItemMessage, SnapshotListMessage};