style: naming & comments adjustements from pr reviews

Author: Alenar

mithril-aggregator/src/database/query/buffered_single_signature/delete_buffered_single_signature.rs

@@ -12,7 +12,7 @@ pub struct DeleteBufferedSingleSignatureQuery {
 
 impl DeleteBufferedSingleSignatureQuery {
     pub fn by_discriminant_and_party_ids(
-        signed_entity_type_discriminants: SignedEntityTypeDiscriminants,
+        signed_entity_type_discriminant: SignedEntityTypeDiscriminants,
         party_ids: Vec<PartyId>,
     ) -> Self {
         let ids_values = party_ids.into_iter().map(Value::String).collect();
@@ -21,7 +21,7 @@ impl DeleteBufferedSingleSignatureQuery {
             condition: WhereCondition::new(
                 "signed_entity_type_id = ?*",
                 vec![Value::Integer(
-                    signed_entity_type_discriminants.index() as i64
+                    signed_entity_type_discriminant.index() as i64
                 )],
             )
             .and_where(WhereCondition::where_in("party_id", ids_values)),

mithril-aggregator/src/database/query/buffered_single_signature/get_buffered_single_signature.rs

@@ -18,14 +18,12 @@ impl GetBufferedSingleSignatureQuery {
         }
     }
 
-    pub fn by_discriminant(
-        signed_entity_type_discriminants: SignedEntityTypeDiscriminants,
-    ) -> Self {
+    pub fn by_discriminant(signed_entity_type_discriminant: SignedEntityTypeDiscriminants) -> Self {
         Self {
             condition: WhereCondition::new(
                 "signed_entity_type_id = ?*",
                 vec![Value::Integer(
-                    signed_entity_type_discriminants.index() as i64
+                    signed_entity_type_discriminant.index() as i64
                 )],
             ),
         }

mithril-aggregator/src/database/repository/buffered_single_signature_repository.rs

@@ -34,7 +34,7 @@ impl BufferedSingleSignatureRepository {
 
     fn get_by_discriminant<T>(
         &self,
-        signed_entity_type_discriminants: SignedEntityTypeDiscriminants,
+        signed_entity_type_discriminant: SignedEntityTypeDiscriminants,
     ) -> StdResult<Vec<T>>
     where
         T: TryFrom<BufferedSingleSignatureRecord>,
@@ -43,7 +43,7 @@ impl BufferedSingleSignatureRepository {
         let records: Vec<BufferedSingleSignatureRecord> =
             self.connection
                 .fetch_collect(GetBufferedSingleSignatureQuery::by_discriminant(
-                    signed_entity_type_discriminants,
+                    signed_entity_type_discriminant,
                 ))?;
 
         let mut entities: Vec<T> = Vec::with_capacity(records.len());
@@ -59,12 +59,12 @@ impl BufferedSingleSignatureRepository {
 impl BufferedSingleSignatureStore for BufferedSingleSignatureRepository {
     async fn buffer_signature(
         &self,
-        signed_entity_type_discriminants: SignedEntityTypeDiscriminants,
+        signed_entity_type_discriminant: SignedEntityTypeDiscriminants,
         signature: &SingleSignatures,
     ) -> StdResult<()> {
         let record = BufferedSingleSignatureRecord::try_from_single_signatures(
             signature,
-            signed_entity_type_discriminants,
+            signed_entity_type_discriminant,
         )
         .with_context(|| "Failed to convert SingleSignatures to BufferedSingleSignatureRecord")?;
 
@@ -78,20 +78,20 @@ impl BufferedSingleSignatureStore for BufferedSingleSignatureRepository {
 
     async fn get_buffered_signatures(
         &self,
-        signed_entity_type_discriminants: SignedEntityTypeDiscriminants,
+        signed_entity_type_discriminant: SignedEntityTypeDiscriminants,
     ) -> StdResult<Vec<SingleSignatures>> {
-        self.get_by_discriminant(signed_entity_type_discriminants)
+        self.get_by_discriminant(signed_entity_type_discriminant)
     }
 
     async fn remove_buffered_signatures(
         &self,
-        signed_entity_type_discriminants: SignedEntityTypeDiscriminants,
+        signed_entity_type_discriminant: SignedEntityTypeDiscriminants,
         single_signatures: Vec<SingleSignatures>,
     ) -> StdResult<()> {
         let signatures_party_ids = single_signatures.into_iter().map(|s| s.party_id).collect();
         self.connection.fetch_first(
             DeleteBufferedSingleSignatureQuery::by_discriminant_and_party_ids(
-                signed_entity_type_discriminants,
+                signed_entity_type_discriminant,
                 signatures_party_ids,
             ),
         )?;

mithril-aggregator/src/dependency_injection/builder.rs

@@ -1277,7 +1277,7 @@ impl DependenciesBuilder {
         Ok(Arc::new(authenticator))
     }
 
-    /// [MithrilSignerRegisterer] service
+    /// [SingleSignatureAuthenticator] service
     pub async fn get_single_signature_authenticator(
         &mut self,
     ) -> Result<Arc<SingleSignatureAuthenticator>> {

mithril-aggregator/src/http_server/routes/signatures_routes.rs

@@ -168,7 +168,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_register_signatures_return_404_if_authentication_fail() {
+    async fn test_register_signatures_return_400_if_authentication_fail() {
         let mut mock_certifier_service = MockCertifierService::new();
         mock_certifier_service
             .expect_register_single_signature()

mithril-aggregator/src/services/certifier/interface.rs

@@ -139,20 +139,20 @@ pub trait BufferedSingleSignatureStore: Sync + Send {
     /// Buffer a single signature for later use.
     async fn buffer_signature(
         &self,
-        signed_entity_type_discriminants: SignedEntityTypeDiscriminants,
+        signed_entity_type_discriminant: SignedEntityTypeDiscriminants,
         signature: &SingleSignatures,
     ) -> StdResult<()>;
 
     /// Get the buffered single signatures for the given signed entity discriminant.
     async fn get_buffered_signatures(
         &self,
-        signed_entity_type_discriminants: SignedEntityTypeDiscriminants,
+        signed_entity_type_discriminant: SignedEntityTypeDiscriminants,
     ) -> StdResult<Vec<SingleSignatures>>;
 
     /// Remove the given single signatures from the buffer.
     async fn remove_buffered_signatures(
         &self,
-        signed_entity_type_discriminants: SignedEntityTypeDiscriminants,
+        signed_entity_type_discriminant: SignedEntityTypeDiscriminants,
         single_signatures: Vec<SingleSignatures>,
     ) -> StdResult<()>;
 }

mithril-common/src/entities/single_signatures.rs

@@ -29,9 +29,9 @@ pub struct SingleSignatures {
 /// Status of the authentication of the signer that emitted the signature
 #[derive(Debug, Copy, Clone, PartialEq, Eq, Default, Serialize, Deserialize)]
 pub enum SingleSignatureAuthenticationStatus {
-    /// We could authenticate the signer that emitted the signature
+    /// The signer that emitted the signature is authenticated
     Authenticated,
-    /// We could not authenticate the signer that emitted the signature
+    /// The signer that emitted the signature is not authenticated
     #[default]
     Unauthenticated,
 }