chore: apply review comments

Author: jpraynaud

mithril-relay/src/commands/signer.rs

@@ -26,7 +26,7 @@ pub struct SignerCommand {
     #[clap(long, env = "AGGREGATOR_ENDPOINT")]
     aggregator_endpoint: String,
 
-    /// Signer registration repeater delay in milliseconds (defaults to 1 hour)
+    /// Interval at which a signer registration should be repeated in milliseconds (defaults to 1 hour)
     #[clap(long, env = "SIGNER_REPEATER_DELAY", default_value_t = 3_600 * 1_000)]
     signer_repeater_delay: u64,
 }
@@ -38,7 +38,7 @@ impl SignerCommand {
         let dial_to = self.dial_to.to_owned();
         let addr: Multiaddr = format!("/ip4/0.0.0.0/tcp/{}", self.listen_port).parse()?;
         let aggregator_endpoint = self.aggregator_endpoint.to_owned();
-        let signer_repeater_delay = Duration::from_millis(self.signer_repeater_delay.to_owned());
+        let signer_repeater_delay = Duration::from_millis(self.signer_repeater_delay);
 
         let mut relay = SignerRelay::start(
             &addr,

mithril-relay/src/p2p/peer.rs

@@ -255,7 +255,7 @@ impl Peer {
     }
 
     /// Publish a signer registration on the P2P pubsub
-    pub fn publish_signer(
+    pub fn publish_signer_registration(
         &mut self,
         message: &RegisterSignerMessage,
     ) -> StdResult<gossipsub::MessageId> {

mithril-relay/src/relay/signer.rs

@@ -112,7 +112,7 @@ impl SignerRelay {
                 match message {
                     Some(signer_message) => {
                         info!("SignerRelay: publish signer-registration to p2p network"; "message" => format!("{signer_message:#?}"));
-                        self.peer.publish_signer(&signer_message)?;
+                        self.peer.publish_signer_registration(&signer_message)?;
                         Ok(())
                     }
                     None => {

mithril-relay/src/repeater.rs

@@ -94,7 +94,7 @@ mod tests {
         repeater.set_message(message.to_string()).await;
 
         let result = tokio::select! {
-            _ = time::sleep(delay-Duration::from_millis(100)) => {Err(anyhow!("Timeout"))}
+            _ = time::sleep(delay - Duration::from_millis(100)) => {Err(anyhow!("Timeout"))}
             _ = repeater.repeat_message() => {Ok(())}
         };
 
@@ -119,7 +119,7 @@ mod tests {
         let repeater = MessageRepeater::new(tx, delay);
 
         let result = tokio::select! {
-            _ = time::sleep(delay-Duration::from_millis(100)) => {Err(anyhow!("Timeout"))}
+            _ = time::sleep(delay - Duration::from_millis(100)) => {Err(anyhow!("Timeout"))}
             _ = repeater.repeat_message() => {Ok(())}
         };
 

mithril-relay/tests/register_signer_signature.rs

@@ -11,7 +11,7 @@ use slog::{Drain, Level, Logger};
 use slog_scope::{error, info};
 
 // Launch a relay that connects to P2P network. The relay is a peer in the P2P
-// network. The relay sends some signer regsitrations that must be received by other
+// network. The relay sends some signer registrations that must be received by other
 // relays.
 // TODO: this test is not optimal and should be refactored for better performances,
 // handling a variable number of peers and with test extensions to avoid code duplication