chore: make Cardano transaction parser fail on error

Author: jpraynaud

mithril-aggregator/src/dependency_injection/builder.rs

@@ -741,8 +741,8 @@ impl DependenciesBuilder {
     }
 
     async fn build_transaction_parser(&mut self) -> Result<Arc<dyn TransactionParser>> {
-        // TODO: 'allow_unparsable_block' parameter should be configurable and its default value set to false
-        let allow_unparsable_block = true;
+        // TODO: 'allow_unparsable_block' parameter should be configurable
+        let allow_unparsable_block = false;
         let transaction_parser =
             CardanoTransactionParser::new(self.get_logger().await?, allow_unparsable_block);
 

mithril-signer/src/runtime/signer_services.rs

@@ -266,8 +266,8 @@ impl<'a> ServiceBuilder for ProductionServiceBuilder<'a> {
             ));
         let mithril_stake_distribution_signable_builder =
             Arc::new(MithrilStakeDistributionSignableBuilder::default());
-        // TODO: 'allow_unparsable_block' parameter should be configurable and its default value set to false
-        let allow_unparsable_block = true;
+        // TODO: 'allow_unparsable_block' parameter should be configurable
+        let allow_unparsable_block = false;
         let transaction_parser = Arc::new(CardanoTransactionParser::new(
             slog_scope::logger(),
             allow_unparsable_block,