Skip to content

Commit a444d74

Browse files
committed
Fix issues from self review
New readme text wasn't updated to last class name & simplify & remove dead code in `CertificateVerifier`.
1 parent 649d4bb commit a444d74

File tree

2 files changed

+15
-22
lines changed

2 files changed

+15
-22
lines changed

mithril-explorer/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,5 +42,5 @@ make icons-font
4242
You can then use the icon in the js, ie if your icon name is `shield`:
4343

4444
```jsx
45-
<i className={`bi mithril mithril-shield`}></i>
45+
<i className={`bi mi mi-shield`}></i>
4646
```

mithril-explorer/src/components/VerifyCertificate/CertificateVerifier.js

Lines changed: 14 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ const certificateChainValidationEvents = {
2020
started: "CertificateChainValidationStarted",
2121
certificateValidated: "CertificateValidated",
2222
done: "CertificateChainValidated",
23-
unknown: "Unknown",
2423
};
2524

2625
const eventPosition = {
@@ -79,26 +78,20 @@ export default function CertificateVerifier({
7978
}, [validationError, onChainValidationError]);
8079

8180
useEffect(() => {
82-
switch (currentStep) {
83-
case certificateValidationSteps.ready:
84-
setVerificationEvents([]);
85-
setValidationError(undefined);
86-
87-
if (client && certificate) {
88-
setCurrentStep(certificateValidationSteps.validationInProgress);
89-
90-
verifyCertificateChain(client, certificate.hash)
91-
.catch((err) => {
92-
console.error("Certificate Chain verification error:\n", err);
93-
setValidationError(err);
94-
})
95-
.finally(() => setCurrentStep(certificateValidationSteps.done));
96-
}
97-
break;
98-
case certificateValidationSteps.validationInProgress:
99-
case certificateValidationSteps.done:
100-
default:
101-
break;
81+
if (currentStep === certificateValidationSteps.ready) {
82+
setVerificationEvents([]);
83+
setValidationError(undefined);
84+
85+
if (client && certificate) {
86+
setCurrentStep(certificateValidationSteps.validationInProgress);
87+
88+
verifyCertificateChain(client, certificate.hash)
89+
.catch((err) => {
90+
console.error("Certificate Chain verification error:\n", err);
91+
setValidationError(err);
92+
})
93+
.finally(() => setCurrentStep(certificateValidationSteps.done));
94+
}
10295
}
10396
}, [currentStep, client, certificate]);
10497

0 commit comments

Comments
 (0)