Merge pull request #1264 from input-output-hk/djo/798/anyhow-in-tests

Use anyhow in integration & e2e tests

Author: Alenar

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-aggregator"
-version = "0.3.103"
+version = "0.3.104"
 description = "A Mithril Aggregator server"
 authors = { workspace = true }
 edition = { workspace = true }

mithril-aggregator/Cargo.toml

@@ -160,10 +160,8 @@ async fn certificate_chain() {
         "Checking that no signers are registered for the next epoch since they did not register"
     );
     let next_epoch_verification_keys = tester
-        .deps_builder
-        .get_verification_key_store()
-        .await
-        .unwrap()
+        .dependencies
+        .verification_key_store
         .get_verification_keys(new_epoch + 1)
         .await
         .expect("get_verification_keys should not fail");

mithril-aggregator/tests/certificate_chain.rs

@@ -1,11 +1,12 @@
+use anyhow::{anyhow, Context};
 use mithril_aggregator::{
     dependency_injection::DependenciesBuilder,
     entities::OpenMessage,
     services::{CertifierService, TickerService},
 };
 use mithril_common::{
     entities::{Beacon, Epoch, SignedEntityType, SignedEntityTypeDiscriminants},
-    BeaconProvider,
+    BeaconProvider, StdResult,
 };
 use std::sync::Arc;
 
@@ -43,39 +44,37 @@ impl AggregatorObserver {
     pub async fn get_current_open_message(
         &self,
         discriminant: SignedEntityTypeDiscriminants,
-    ) -> Result<Option<OpenMessage>, String> {
+    ) -> StdResult<Option<OpenMessage>> {
         let signed_entity_type = self.build_current_signed_entity_type(discriminant).await?;
 
         self.certifier_service
             .get_open_message(&signed_entity_type)
             .await
-            .map_err(|e| {
-                format!(
-                    "Requesting current open message of type CardanoImmutableFilesFull should be not fail: {e:?}"
-                )
-            })
+            .with_context(|| "Requesting current open message of type CardanoImmutableFilesFull should be not fail")
     }
 
     // Get the [entity type][SignedEntityType::CardanoImmutableFilesFull] of the current current open message
     pub async fn get_current_signed_entity_type(
         &self,
         discriminant: SignedEntityTypeDiscriminants,
-    ) -> Result<SignedEntityType, String> {
+    ) -> StdResult<SignedEntityType> {
         match self.get_current_open_message(discriminant).await? {
-            None => Err("An open message should be available for cardano immutables".to_string()),
+            None => Err(anyhow!(
+                "An open message should be available for cardano immutables"
+            )),
             Some(message) => Ok(message.signed_entity_type),
         }
     }
 
     async fn build_current_signed_entity_type(
         &self,
         discriminant: SignedEntityTypeDiscriminants,
-    ) -> Result<SignedEntityType, String> {
+    ) -> StdResult<SignedEntityType> {
         let beacon = self
             .beacon_provider
             .get_current_beacon()
             .await
-            .map_err(|e| format!("Querying the current beacon should not fail: {e:?}"))?;
+            .with_context(|| "Querying the current beacon should not fail")?;
 
         match discriminant {
             SignedEntityTypeDiscriminants::MithrilStakeDistribution => {