Skip to content

Commit aac8161

Browse files
committed
Fix next_protocol_multi_signerbuild in FakeEpochService::with_data
1 parent 2d55a0b commit aac8161

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

mithril-aggregator/src/services/epoch_service.rs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -215,8 +215,6 @@ impl EpochService for MithrilEpochService {
215215
let next_signers_with_stake = self
216216
.get_signers_with_stake_at_epoch(next_signer_retrieval_epoch)
217217
.await?;
218-
219-
// TODO could it be better to create a EpochData::new and to this in the impl ? So, it'll not done twice in FakeEpochService
220218
let current_signers = Signer::vec_from(current_signers_with_stake.clone());
221219
let next_signers = Signer::vec_from(next_signers_with_stake.clone());
222220

@@ -346,12 +344,10 @@ impl FakeEpochService {
346344
.unwrap()
347345
.build_multi_signer();
348346
let next_protocol_multi_signer =
349-
// SignerBuilder::new(current_signers_with_stake, protocol_parameters)
350-
// TODO Is it correct to use current_signers_with_stake here and not next_signers_with_stake ?
351-
SignerBuilder::new(current_signers_with_stake, protocol_parameters)
352-
.with_context(|| "Could not build protocol_multi_signer for epoch service")
353-
.unwrap()
354-
.build_multi_signer();
347+
SignerBuilder::new(next_signers_with_stake, next_protocol_parameters)
348+
.with_context(|| "Could not build protocol_multi_signer for epoch service")
349+
.unwrap()
350+
.build_multi_signer();
355351

356352
let current_signers_with_stake = current_signers_with_stake.to_vec();
357353
let next_signers_with_stake = next_signers_with_stake.to_vec();

0 commit comments

Comments
 (0)