fix: address 'missing doc' clippy warning on public but test only symbols

by adjusting their visibility so they're at most `pub(crate)`.

Note: With rust `1.83` there's no more 'missing doc' exception for `cfg(test)`
and `pub` symbols.

Author: Alenar

internal/mithril-metric/src/helper.rs

@@ -88,12 +88,13 @@ macro_rules! build_metrics_service {
 }
 
 #[cfg(test)]
-pub mod test_tools {
+pub(crate) mod test_tools {
     use std::{io, sync::Arc};
 
     use slog::{Drain, Logger};
     use slog_async::Async;
     use slog_term::{CompactFormat, PlainDecorator};
+
     pub struct TestLogger;
 
     impl TestLogger {

internal/mithril-metric/src/lib.rs

@@ -10,6 +10,3 @@ mod server;
 pub use metric::*;
 pub use server::MetricsServer;
 pub use server::MetricsServiceExporter;
-
-#[cfg(test)]
-pub use helper::test_tools::TestLogger;

internal/mithril-persistence/src/database/mod.rs

@@ -17,7 +17,7 @@ pub use version_checker::{DatabaseVersionChecker, SqlMigration};
 pub type DbVersion = i64;
 
 #[cfg(test)]
-pub mod test_helper {
+pub(crate) mod test_helper {
     use sqlite::ConnectionThreadSafe;
 
     use mithril_common::StdResult;

internal/mithril-persistence/src/sqlite/condition.rs

@@ -362,9 +362,10 @@ mod tests {
 
     #[test]
     fn expression_get_all_default() {
-        impl GetAllCondition for String {}
+        struct Expression;
+        impl GetAllCondition for Expression {}
 
-        let expression = String::get_all_condition();
+        let expression = Expression::get_all_condition();
         let (sql, params) = expression.expand();
 
         assert_eq!("true".to_string(), sql);

mithril-aggregator/src/database/record/certificate.rs

@@ -69,15 +69,15 @@ pub struct CertificateRecord {
 
 #[cfg(test)]
 impl CertificateRecord {
-    pub fn dummy_genesis(id: &str, epoch: Epoch) -> Self {
+    pub(crate) fn dummy_genesis(id: &str, epoch: Epoch) -> Self {
         Self {
             parent_certificate_id: None,
             signature: fake_keys::genesis_signature()[0].to_owned(),
             ..Self::dummy(id, "", epoch, SignedEntityType::genesis(epoch))
         }
     }
 
-    pub fn dummy_db_snapshot(
+    pub(crate) fn dummy_db_snapshot(
         id: &str,
         parent_id: &str,
         epoch: Epoch,
@@ -94,7 +94,7 @@ impl CertificateRecord {
         )
     }
 
-    pub fn dummy_msd(id: &str, parent_id: &str, epoch: Epoch) -> Self {
+    pub(crate) fn dummy_msd(id: &str, parent_id: &str, epoch: Epoch) -> Self {
         Self::dummy(
             id,
             parent_id,
@@ -103,7 +103,7 @@ impl CertificateRecord {
         )
     }
 
-    pub fn dummy(
+    pub(crate) fn dummy(
         id: &str,
         parent_id: &str,
         epoch: Epoch,

mithril-aggregator/src/dependency_injection/containers.rs

@@ -303,7 +303,7 @@ impl DependencyContainer {
 }
 
 #[cfg(test)]
-pub mod tests {
+pub(crate) mod tests {
     use crate::{dependency_injection::DependenciesBuilder, Configuration, DependencyContainer};
 
     pub async fn initialize_dependencies() -> DependencyContainer {

mithril-aggregator/src/lib.rs

@@ -61,7 +61,7 @@ pub use tools::{
 };
 
 #[cfg(test)]
-pub use dependency_injection::tests::initialize_dependencies;
+pub(crate) use dependency_injection::tests::initialize_dependencies;
 
 // Memory allocator (to handle properly memory fragmentation)
 #[cfg(all(not(target_env = "msvc"), feature = "jemallocator"))]

mithril-aggregator/src/services/cardano_transactions_importer.rs

@@ -251,7 +251,7 @@ mod tests {
     }
 
     impl CardanoTransactionsImporter {
-        pub fn new_for_test(
+        pub(crate) fn new_for_test(
             scanner: Arc<dyn BlockScanner>,
             transaction_store: Arc<dyn TransactionStore>,
         ) -> Self {

mithril-aggregator/src/services/epoch_service.rs

@@ -516,7 +516,7 @@ impl EpochService for MithrilEpochService {
 }
 
 #[cfg(test)]
-pub struct FakeEpochService {
+pub(crate) struct FakeEpochService {
     epoch_data: Option<EpochData>,
     computed_epoch_data: Option<ComputedEpochData>,
     inform_epoch_error: bool,
@@ -525,7 +525,7 @@ pub struct FakeEpochService {
 }
 
 #[cfg(test)]
-pub struct FakeEpochServiceBuilder {
+pub(crate) struct FakeEpochServiceBuilder {
     pub cardano_era: CardanoEra,
     pub mithril_era: SupportedEra,
     pub epoch: Epoch,
@@ -662,6 +662,7 @@ impl FakeEpochService {
         }
     }
 
+    #[allow(dead_code)]
     pub fn toggle_errors(
         &mut self,
         inform_epoch: bool,

mithril-aggregator/src/signer_registerer.rs

@@ -63,7 +63,7 @@ pub struct SignerRegistrationRound {
 
 #[cfg(test)]
 impl SignerRegistrationRound {
-    pub fn dummy(epoch: Epoch, stake_distribution: StakeDistribution) -> Self {
+    pub(crate) fn dummy(epoch: Epoch, stake_distribution: StakeDistribution) -> Self {
         Self {
             epoch,
             stake_distribution,
@@ -146,7 +146,7 @@ impl MithrilSignerRegisterer {
     }
 
     #[cfg(test)]
-    pub async fn get_current_round(&self) -> Option<SignerRegistrationRound> {
+    pub(crate) async fn get_current_round(&self) -> Option<SignerRegistrationRound> {
         self.current_round.read().await.as_ref().cloned()
     }
 }