refactor: replace fn dummy() with Dummy trait impl

and, when applicable, move the `Dummy` impl to a `test::double::dummies`
module.

Author: Alenar

internal/mithril-dmq/src/publisher/pallas.rs

@@ -82,7 +82,6 @@ impl<M: TryToBytes + Debug + Sync + Send> DmqPublisher<M> for DmqPublisherPallas
 
 #[cfg(all(test, unix))]
 mod tests {
-
     use std::{fs, sync::Arc};
 
     use pallas_network::miniprotocols::{
@@ -91,7 +90,11 @@ mod tests {
     use tokio::{net::UnixListener, task::JoinHandle};
 
     use mithril_cardano_node_chain::test::double::FakeChainObserver;
-    use mithril_common::{crypto_helper::KesSignerFake, current_function, test_utils::TempDir};
+    use mithril_common::{
+        crypto_helper::KesSignerFake,
+        current_function,
+        test_utils::{TempDir, double::Dummy},
+    };
 
     use crate::{test::payload::DmqMessageTestPayload, test_tools::TestLogger};
 

internal/mithril-dmq/src/test/payload.rs

@@ -3,6 +3,7 @@ use std::fmt::Debug;
 use mithril_common::{
     StdResult,
     crypto_helper::{TryFromBytes, TryToBytes},
+    test_utils::double::Dummy,
 };
 
 /// A test message payload for the DMQ.
@@ -18,9 +19,11 @@ impl DmqMessageTestPayload {
             message: bytes.to_vec(),
         }
     }
+}
 
+impl Dummy for DmqMessageTestPayload {
     /// Creates a dummy `DmqMessageTestPayload` with a predefined message.
-    pub fn dummy() -> Self {
+    fn dummy() -> Self {
         Self {
             message: b"dummy message".to_vec(),
         }

mithril-aggregator/src/artifact_builder/cardano_database_artifacts/ancillary.rs

@@ -206,7 +206,7 @@ impl AncillaryArtifactBuilder {
 mod tests {
     use std::path::PathBuf;
 
-    use mithril_common::test_utils::{TempDir, assert_equivalent};
+    use mithril_common::test_utils::{TempDir, assert_equivalent, double::Dummy};
 
     use crate::services::{DumbSnapshotter, MockSnapshotter};
     use crate::test_tools::TestLogger;

mithril-aggregator/src/artifact_builder/cardano_database_artifacts/digest.rs

@@ -299,7 +299,7 @@ mod tests {
         current_function,
         entities::{CardanoDbBeacon, CompressionAlgorithm},
         messages::{CardanoDatabaseDigestListItemMessage, CardanoDatabaseDigestListMessage},
-        test_utils::{TempDir, assert_equivalent},
+        test_utils::{TempDir, assert_equivalent, double::Dummy},
     };
 
     use crate::{

mithril-aggregator/src/artifact_builder/mithril_stake_distribution.rs

@@ -38,7 +38,10 @@ impl ArtifactBuilder<Epoch, MithrilStakeDistribution> for MithrilStakeDistributi
 
 #[cfg(test)]
 mod tests {
-    use mithril_common::{crypto_helper::ProtocolParameters, test_utils::fake_data};
+    use mithril_common::{
+        crypto_helper::ProtocolParameters,
+        test_utils::{double::Dummy, fake_data},
+    };
     use std::sync::Arc;
     use tokio::sync::RwLock;
 

mithril-aggregator/src/database/query/open_message/insert_or_replace_open_message.rs

@@ -34,6 +34,7 @@ impl Query for InsertOrReplaceOpenMessageQuery {
 
 #[cfg(test)]
 mod tests {
+    use mithril_common::test_utils::double::Dummy;
     use mithril_persistence::sqlite::ConnectionExtensions;
 
     use crate::database::query::GetOpenMessageQuery;

mithril-aggregator/src/database/record/immutable_file_digest.rs

@@ -19,15 +19,6 @@ impl ImmutableFileDigestRecord {
         let aliases = SourceAlias::new(&[("{:immutable_file_digest:}", table)]);
         Self::get_projection().expand(aliases)
     }
-
-    #[cfg(test)]
-    /// Create a dumb ImmutableFileDigestRecord instance mainly for test purposes
-    pub fn dummy() -> Self {
-        Self {
-            immutable_file_name: "123.chunk".to_string(),
-            digest: "dummy_digest".to_string(),
-        }
-    }
 }
 
 impl SqLiteEntity for ImmutableFileDigestRecord {

mithril-aggregator/src/database/record/open_message.rs

@@ -43,25 +43,6 @@ impl OpenMessageRecord {
     pub fn new_id() -> Uuid {
         Uuid::new_v4()
     }
-
-    #[cfg(test)]
-    /// Create a dumb OpenMessage instance mainly for test purposes
-    pub fn dummy() -> Self {
-        let beacon = mithril_common::test_utils::fake_data::beacon();
-        let epoch = beacon.epoch;
-        let signed_entity_type = SignedEntityType::CardanoImmutableFilesFull(beacon);
-
-        Self {
-            open_message_id: Uuid::parse_str("193d1442-e89b-43cf-9519-04d8db9a12ff").unwrap(),
-            epoch,
-            signed_entity_type,
-            protocol_message: ProtocolMessage::new(),
-            is_certified: false,
-            is_expired: false,
-            created_at: Utc::now(),
-            expires_at: None,
-        }
-    }
 }
 
 impl SqLiteEntity for OpenMessageRecord {

mithril-aggregator/src/database/repository/epoch_settings_store.rs

@@ -92,6 +92,8 @@ impl EpochPruningTask for EpochSettingsStore {
 
 #[cfg(test)]
 mod tests {
+    use mithril_common::test_utils::double::Dummy;
+
     use crate::database::test_helper::{insert_epoch_settings, main_db_connection};
 
     use super::*;

mithril-aggregator/src/database/repository/open_message_repository.rs

@@ -140,6 +140,7 @@ impl OpenMessageStorer for OpenMessageRepository {
 #[cfg(test)]
 mod tests {
     use mithril_common::entities::{BlockNumber, CardanoDbBeacon};
+    use mithril_common::test_utils::double::Dummy;
 
     use crate::database::record::SingleSignatureRecord;
     use crate::database::test_helper::{