Skip to content

Commit b383c8e

Browse files
committed
Still show a link to cexplorer if the network is availabe even without ticker
1 parent 0418a50 commit b383c8e

File tree

2 files changed

+50
-3
lines changed

2 files changed

+50
-3
lines changed

mithril-explorer/__tests__/PoolTicker.test.js

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,4 +71,51 @@ describe('PoolTicker', () => {
7171
expect(screen.getByText(poolTicker));
7272
expect(screen.getByRole('link')).toHaveAttribute('href', getCExplorerUrlForPool(network, partyId));
7373
});
74+
75+
it.each(["mainnet", "preprod", "preview"])
76+
('Not available Pool ticker on %s network still show link to cexplorer', (network) => {
77+
const partyId = "pool1zmtm8yef33z2n7x4nn0kvv9xpzjuj7725p9y9m5t960g5qy51ua";
78+
renderPoolTickerComponent(
79+
"myaggregator",
80+
partyId,
81+
{
82+
pools: {
83+
...poolsSlice.getInitialState(),
84+
list: [
85+
{
86+
aggregator: "myaggregator",
87+
network: network,
88+
pools: [{
89+
"party_id": partyId,
90+
"has_registered": true,
91+
}],
92+
}],
93+
},
94+
});
95+
96+
expect(screen.getByText("Not available"));
97+
expect(screen.getByRole('link')).toHaveAttribute('href', getCExplorerUrlForPool(network, partyId));
98+
});
99+
100+
it.each(["mainnet", "preprod", "preview"])
101+
('Not available Pool ticker on %s network still show link to cexplorer even without pools data', (network) => {
102+
const partyId = "pool1zmtm8yef33z2n7x4nn0kvv9xpzjuj7725p9y9m5t960g5qy51ua";
103+
renderPoolTickerComponent(
104+
"myaggregator",
105+
partyId,
106+
{
107+
pools: {
108+
...poolsSlice.getInitialState(),
109+
list: [
110+
{
111+
aggregator: "myaggregator",
112+
network: network,
113+
pools: [],
114+
}],
115+
},
116+
});
117+
118+
expect(screen.getByText("Not available"));
119+
expect(screen.getByRole('link')).toHaveAttribute('href', getCExplorerUrlForPool(network, partyId));
120+
});
74121
});

mithril-explorer/src/components/PoolTicker.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ export default function PoolTicker({aggregator, partyId, ...props}) {
1111

1212
useEffect(() => {
1313
if (pool?.network) {
14-
setUrl(getCExplorerUrlForPool(pool.network, pool.party_id));
14+
setUrl(getCExplorerUrlForPool(pool.network, partyId));
1515
} else {
1616
setUrl(undefined);
1717
}
18-
}, [pool.party_id, pool.network])
18+
}, [partyId, pool.network])
1919

2020
return (url !== undefined)
2121
? <>
@@ -27,7 +27,7 @@ export default function PoolTicker({aggregator, partyId, ...props}) {
2727
style={{verticalAlign:"text-top"}}
2828
width={20} height={20}/>
2929
<> </>
30-
{pool.pool_ticker}
30+
{pool.pool_ticker ?? "Not available"}
3131
</span>
3232
</OverlayTrigger>
3333
</a>

0 commit comments

Comments
 (0)