Skip to content

Commit b5efb83

Browse files
committed
style: adjustements following PR reviews
Adjust some logs messages & added properties
1 parent b409dd0 commit b5efb83

File tree

4 files changed

+14
-10
lines changed

4 files changed

+14
-10
lines changed

mithril-aggregator/src/runtime/runner.rs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ impl AggregatorRunnerTrait for AggregatorRunner {
326326
time_point: TimePoint,
327327
signed_entity_type: &SignedEntityType,
328328
) -> StdResult<CertificatePending> {
329-
debug!(self.logger, ">> create_new_pending_certificate");
329+
debug!(self.logger, ">> create_new_pending_certificate"; "signed_entity_type" => ?signed_entity_type);
330330
let epoch_service = self.dependencies.epoch_service.read().await;
331331

332332
let signers = epoch_service.current_signers_with_stake()?;
@@ -382,7 +382,7 @@ impl AggregatorRunnerTrait for AggregatorRunner {
382382
&self,
383383
signed_entity_type: &SignedEntityType,
384384
) -> StdResult<Option<Certificate>> {
385-
debug!(self.logger, ">> create_certificate");
385+
debug!(self.logger, ">> create_certificate"; "signed_entity_type" => ?signed_entity_type);
386386

387387
self.dependencies
388388
.certifier_service
@@ -400,7 +400,11 @@ impl AggregatorRunnerTrait for AggregatorRunner {
400400
signed_entity_type: &SignedEntityType,
401401
certificate: &Certificate,
402402
) -> StdResult<()> {
403-
debug!(self.logger, ">> create_artifact");
403+
debug!(
404+
self.logger, ">> create_artifact";
405+
"signed_entity_type" => ?signed_entity_type,
406+
"certificate_hash" => &certificate.hash
407+
);
404408

405409
self.dependencies
406410
.signed_entity_service
@@ -417,7 +421,7 @@ impl AggregatorRunnerTrait for AggregatorRunner {
417421
}
418422

419423
async fn update_era_checker(&self, epoch: Epoch) -> StdResult<()> {
420-
debug!(self.logger, ">> update_era_checker");
424+
debug!(self.logger, ">> update_era_checker({epoch:?})");
421425
let token = self
422426
.dependencies
423427
.era_reader
@@ -463,7 +467,7 @@ impl AggregatorRunnerTrait for AggregatorRunner {
463467
}
464468

465469
async fn inform_new_epoch(&self, epoch: Epoch) -> StdResult<()> {
466-
debug!(self.logger, ">> inform_new_epoch");
470+
debug!(self.logger, ">> inform_new_epoch({epoch:?})");
467471
self.dependencies
468472
.certifier_service
469473
.inform_epoch(epoch)

mithril-aggregator/src/services/cardano_transactions_importer.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,13 @@ impl CardanoTransactionsImporter {
8787
if from.as_ref().is_some_and(|f| f.block_number >= until) {
8888
debug!(
8989
self.logger,
90-
"Does not need to retrieve Cardano transactions, the database is up to date for block_number '{until}'",
90+
"No need to retrieve Cardano transactions, the database is up to date for block_number '{until}'",
9191
);
9292
return Ok(());
9393
}
9494
debug!(
9595
self.logger,
96-
"Will retrieve Cardano transactions between block_number '{}' and '{until}'",
96+
"Retrieving Cardano transactions between block_number '{}' and '{until}'",
9797
from.as_ref()
9898
.map(|c| c.block_number)
9999
.unwrap_or(BlockNumber(0))

mithril-aggregator/src/tools/signer_importer.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ impl SignersImporter {
3838

3939
/// Import and persist the signers
4040
pub async fn run(&self) -> StdResult<()> {
41-
info!(self.logger, "Starting importation");
41+
info!(self.logger, "Starting import");
4242
let items = self
4343
.retriever
4444
.retrieve()

mithril-signer/src/services/cardano_transactions/importer/service.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,13 @@ impl CardanoTransactionsImporter {
8787
if from.as_ref().is_some_and(|f| f.block_number >= until) {
8888
debug!(
8989
self.logger,
90-
"Does not need to retrieve Cardano transactions, the database is up to date for block_number '{until}'",
90+
"No need to retrieve Cardano transactions, the database is up to date for block_number '{until}'",
9191
);
9292
return Ok(());
9393
}
9494
debug!(
9595
self.logger,
96-
"Will retrieve Cardano transactions between block_number '{}' and '{until}'",
96+
"Retrieving Cardano transactions between block_number '{}' and '{until}'",
9797
from.as_ref()
9898
.map(|c| c.block_number)
9999
.unwrap_or(BlockNumber(0))

0 commit comments

Comments
 (0)