Don't use ServiceBuilder to build the sqliteconnection in unit tests

Author: Alenar

mithril-signer/src/cardano_transactions_importer.rs

@@ -114,10 +114,10 @@ impl TransactionsImporter for CardanoTransactionsImporter {
 #[cfg(test)]
 mod tests {
     use crate::database::provider::CardanoTransactionRepository;
-    use crate::{Configuration, ProductionServiceBuilder};
-    use mithril_persistence::sqlite::SqliteConnection;
+    use crate::database::test_utils::apply_all_transactions_db_migrations;
     use mockall::mock;
     use mockall::predicate::eq;
+    use sqlite::Connection;
 
     use super::*;
 
@@ -135,19 +135,6 @@ mod tests {
         }
     }
 
-    async fn get_connection() -> Arc<SqliteConnection> {
-        let party_id = "party-id-123".to_string();
-        let configuration = Configuration::new_sample(&party_id);
-        let production_service_builder = ProductionServiceBuilder::new(&configuration);
-        production_service_builder
-            .build_sqlite_connection(
-                ":memory:",
-                crate::database::cardano_transaction_migration::get_migrations(),
-            )
-            .await
-            .unwrap()
-    }
-
     fn build_importer(
         parser_mock_config: &dyn Fn(&mut MockTransactionParserImpl),
         store_mock_config: &dyn Fn(&mut MockTransactionStore),
@@ -275,7 +262,8 @@ mod tests {
             CardanoTransaction::new("tx_hash-4", 20, 30, "block_hash-2", 12),
         ];
         let importer = {
-            let connection = get_connection().await;
+            let connection = Connection::open_thread_safe(":memory:").unwrap();
+            apply_all_transactions_db_migrations(&connection).unwrap();
             let parsed_transactions = transactions.clone();
             let mut parser = MockTransactionParserImpl::new();
             parser
@@ -284,7 +272,7 @@ mod tests {
 
             CardanoTransactionsImporter::new(
                 Arc::new(parser),
-                Arc::new(CardanoTransactionRepository::new(connection.clone())),
+                Arc::new(CardanoTransactionRepository::new(Arc::new(connection))),
                 Path::new(""),
                 None,
                 crate::test_tools::logger_for_tests(),

mithril-signer/src/database/mod.rs

@@ -4,3 +4,19 @@
 pub mod cardano_transaction_migration;
 pub mod migration;
 pub mod provider;
+
+#[cfg(test)]
+pub mod test_utils {
+    use mithril_common::StdResult;
+    use mithril_persistence::sqlite::SqliteConnection;
+
+    use super::*;
+
+    pub fn apply_all_transactions_db_migrations(connection: &SqliteConnection) -> StdResult<()> {
+        for migration in cardano_transaction_migration::get_migrations() {
+            connection.execute(&migration.alterations)?;
+        }
+
+        Ok(())
+    }
+}

mithril-signer/src/database/provider/cardano_transaction.rs

@@ -343,21 +343,14 @@ mod tests {
     use mithril_persistence::sqlite::SourceAlias;
     use sqlite::Connection;
 
-    use crate::{Configuration, ProductionServiceBuilder};
+    use crate::database::test_utils::apply_all_transactions_db_migrations;
 
     use super::*;
 
     async fn get_connection() -> Arc<SqliteConnection> {
-        let party_id = "party-id-123".to_string();
-        let configuration = Configuration::new_sample(&party_id);
-        let production_service_builder = ProductionServiceBuilder::new(&configuration);
-        production_service_builder
-            .build_sqlite_connection(
-                ":memory:",
-                crate::database::cardano_transaction_migration::get_migrations(),
-            )
-            .await
-            .unwrap()
+        let connection = Connection::open_thread_safe(":memory:").unwrap();
+        apply_all_transactions_db_migrations(&connection).unwrap();
+        Arc::new(connection)
     }
 
     #[test]