fix error management

Author: ghubertpalo

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-aggregator"
-version = "0.2.38"
+version = "0.2.39"
 description = "A Mithril Aggregator server"
 authors = { workspace = true }
 edition = { workspace = true }

mithril-aggregator/Cargo.toml

@@ -250,7 +250,7 @@ impl RuntimeTester {
         signers: &[SignerFixture],
     ) -> Result<(), String> {
         let lock = self.deps_builder.get_multi_signer().await.unwrap();
-        let mut multisigner = lock.write().await;
+        let multisigner = lock.read().await;
         let message = multisigner
             .get_current_message()
             .await

mithril-aggregator/tests/test_extensions/runtime_tester.rs

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-client"
-version = "0.2.14"
+version = "0.2.15"
 description = "A Mithril Client"
 authors = { workspace = true }
 edition = { workspace = true }

mithril-client/Cargo.toml

@@ -1,8 +1,8 @@
-use std::{error::Error, fmt::Display, sync::Arc};
+use std::{fmt::Display, sync::Arc};
 
 use clap::Parser;
 use config::{builder::DefaultState, ConfigBuilder};
-use mithril_common::api_version::APIVersionProvider;
+use mithril_common::{api_version::APIVersionProvider, StdError};
 use serde::Serialize;
 use slog_scope::debug;
 
@@ -28,7 +28,7 @@ impl DownloadCommand {
     pub async fn execute(
         &self,
         config_builder: ConfigBuilder<DefaultState>,
-    ) -> Result<(), Box<dyn Error>> {
+    ) -> Result<(), StdError> {
         debug!("Download snapshots");
         let config: Config = config_builder
             .build()

mithril-client/src/commands/download.rs

@@ -1,9 +1,9 @@
-use std::{error::Error, sync::Arc};
+use std::sync::Arc;
 
 use clap::Parser;
 use cli_table::{print_stdout, WithTitle};
 use config::{builder::DefaultState, ConfigBuilder};
-use mithril_common::api_version::APIVersionProvider;
+use mithril_common::{api_version::APIVersionProvider, StdError};
 use slog_scope::debug;
 
 use crate::{AggregatorHTTPClient, Config, Runtime};
@@ -21,7 +21,7 @@ impl ListCommand {
     pub async fn execute(
         &self,
         config_builder: ConfigBuilder<DefaultState>,
-    ) -> Result<(), Box<dyn Error>> {
+    ) -> Result<(), StdError> {
         debug!("List snapshots");
         let config: Config = config_builder
             .build()

mithril-client/src/commands/list.rs

@@ -9,9 +9,10 @@ use mithril_common::{
         cache::ImmutableFileDigestCacheProvider,
         cache::JsonImmutableFileDigestCacheProviderBuilder, CardanoImmutableDigester,
     },
+    StdError,
 };
 use slog_scope::{debug, warn};
-use std::{error::Error, path::Path, sync::Arc};
+use std::{path::Path, sync::Arc};
 
 use crate::{AggregatorHTTPClient, AggregatorHandler, Config, Runtime};
 
@@ -41,7 +42,7 @@ impl RestoreCommand {
     pub async fn execute(
         &self,
         config_builder: ConfigBuilder<DefaultState>,
-    ) -> Result<(), Box<dyn Error>> {
+    ) -> Result<(), StdError> {
         debug!("Restore snapshot");
         let config: Config = config_builder
             .build()
@@ -102,7 +103,7 @@ async fn build_digester_cache_provider(
     disable_digests_cache: bool,
     reset_digests_cache: bool,
     config: &Config,
-) -> Result<Option<Arc<dyn ImmutableFileDigestCacheProvider>>, Box<dyn Error>> {
+) -> Result<Option<Arc<dyn ImmutableFileDigestCacheProvider>>, StdError> {
     if disable_digests_cache {
         return Ok(None);
     }

mithril-client/src/commands/restore.rs

@@ -1,9 +1,9 @@
-use std::{error::Error, sync::Arc};
+use std::sync::Arc;
 
 use clap::Parser;
 use cli_table::{print_stdout, WithTitle};
 use config::{builder::DefaultState, ConfigBuilder};
-use mithril_common::api_version::APIVersionProvider;
+use mithril_common::{api_version::APIVersionProvider, StdError};
 use slog_scope::debug;
 
 use crate::{convert_to_field_items, AggregatorHTTPClient, Config, Runtime};
@@ -24,7 +24,7 @@ impl ShowCommand {
     pub async fn execute(
         &self,
         config_builder: ConfigBuilder<DefaultState>,
-    ) -> Result<(), Box<dyn Error>> {
+    ) -> Result<(), StdError> {
         debug!("Show snapshot");
         let config: Config = config_builder
             .build()

mithril-client/src/commands/show.rs

@@ -3,9 +3,9 @@
 use clap::{Parser, Subcommand};
 use config::builder::DefaultState;
 use config::{ConfigBuilder, Map, Source, Value, ValueKind};
+use mithril_common::StdError;
 use slog::{Drain, Level, Logger};
 use slog_scope::debug;
-use std::error::Error;
 use std::path::PathBuf;
 use std::sync::Arc;
 
@@ -42,7 +42,7 @@ pub struct Args {
 }
 
 impl Args {
-    pub async fn execute(&self) -> Result<(), Box<dyn Error>> {
+    pub async fn execute(&self) -> Result<(), StdError> {
         debug!("Run Mode: {}", self.run_mode);
         let config: ConfigBuilder<DefaultState> = config::Config::builder()
             .add_source(
@@ -122,7 +122,7 @@ impl Commands {
     pub async fn execute(
         &self,
         config_builder: ConfigBuilder<DefaultState>,
-    ) -> Result<(), Box<dyn Error>> {
+    ) -> Result<(), StdError> {
         match self {
             Self::List(cmd) => cmd.execute(config_builder).await,
             Self::Download(cmd) => cmd.execute(config_builder).await,

mithril-client/src/main.rs

@@ -1,6 +1,6 @@
 [package]
 name = "mithril-common"
-version = "0.2.33"
+version = "0.2.34"
 authors = { workspace = true }
 edition = { workspace = true }
 documentation = { workspace = true }