Make transaction repository handle the store in chunk

Since it's a sqlite limitation, it's the repository job to handle that.

Author: Alenar

mithril-aggregator/src/database/provider/cardano_transaction.rs

@@ -331,11 +331,13 @@ impl TransactionStore for CardanoTransactionRepository {
         })
     }
 
-    async fn store_transactions(&self, transactions: &[CardanoTransaction]) -> StdResult<()> {
-        self.create_transactions(transactions.to_vec())
-            .await
-            .with_context(|| "CardanoTransactionRepository can not store transactions")?;
-
+    async fn store_transactions(&self, transactions: Vec<CardanoTransaction>) -> StdResult<()> {
+        // Chunk transactions to avoid an error when we exceed sqlite binding limitations
+        for transactions_in_chunk in transactions.chunks(100) {
+            self.create_transactions(transactions_in_chunk.to_vec())
+                .await
+                .with_context(|| "CardanoTransactionRepository can not store transactions")?;
+        }
         Ok(())
     }
 }
@@ -556,7 +558,7 @@ mod tests {
             CardanoTransaction::new("tx-hash-456", 11, 51, "block-hash-456", 100),
         ];
         repository
-            .store_transactions(&cardano_transactions)
+            .create_transactions(cardano_transactions)
             .await
             .unwrap();
 
@@ -626,7 +628,7 @@ mod tests {
             CardanoTransaction::new("tx-hash-456".to_string(), 11, 51, "block-hash-456", 100),
         ];
         repository
-            .store_transactions(&cardano_transactions)
+            .create_transactions(cardano_transactions.clone())
             .await
             .unwrap();
 
@@ -657,7 +659,7 @@ mod tests {
             99,
         )];
         repository
-            .store_transactions(&cardano_transactions)
+            .create_transactions(cardano_transactions)
             .await
             .unwrap();
 
@@ -694,7 +696,7 @@ mod tests {
             CardanoTransaction::new("tx-hash-456".to_string(), 11, 51, "block-hash-456", 100),
         ];
         repository
-            .store_transactions(&cardano_transactions)
+            .create_transactions(cardano_transactions)
             .await
             .unwrap();
 

mithril-aggregator/src/services/cardano_transactions_importer.rs

@@ -24,7 +24,7 @@ pub trait TransactionStore: Send + Sync {
     ) -> StdResult<Vec<CardanoTransaction>>;
 
     /// Store list of transactions
-    async fn store_transactions(&self, transactions: &[CardanoTransaction]) -> StdResult<()>;
+    async fn store_transactions(&self, transactions: Vec<CardanoTransaction>) -> StdResult<()>;
 }
 
 /// Import and store [CardanoTransaction].
@@ -89,12 +89,9 @@ impl CardanoTransactionsImporter {
             from.unwrap_or(0)
         );
 
-        let transaction_chunk_size = 100;
-        for transactions_in_chunk in parsed_transactions.chunks(transaction_chunk_size) {
-            self.transaction_store
-                .store_transactions(transactions_in_chunk)
-                .await?;
-        }
+        self.transaction_store
+            .store_transactions(parsed_transactions)
+            .await?;
         Ok(())
     }
 }

mithril-signer/src/cardano_transactions_importer.rs

@@ -24,7 +24,7 @@ pub trait TransactionStore: Send + Sync {
     ) -> StdResult<Vec<CardanoTransaction>>;
 
     /// Store list of transactions
-    async fn store_transactions(&self, transactions: &[CardanoTransaction]) -> StdResult<()>;
+    async fn store_transactions(&self, transactions: Vec<CardanoTransaction>) -> StdResult<()>;
 }
 
 /// Import and store [CardanoTransaction].
@@ -89,12 +89,9 @@ impl CardanoTransactionsImporter {
             from.unwrap_or(0)
         );
 
-        let transaction_chunk_size = 100;
-        for transactions_in_chunk in parsed_transactions.chunks(transaction_chunk_size) {
-            self.transaction_store
-                .store_transactions(transactions_in_chunk)
-                .await?;
-        }
+        self.transaction_store
+            .store_transactions(parsed_transactions)
+            .await?;
         Ok(())
     }
 }

mithril-signer/src/database/provider/cardano_transaction.rs

@@ -330,11 +330,13 @@ impl TransactionStore for CardanoTransactionRepository {
         })
     }
 
-    async fn store_transactions(&self, transactions: &[CardanoTransaction]) -> StdResult<()> {
-        self.create_transactions(transactions.to_vec())
-            .await
-            .with_context(|| "CardanoTransactionRepository can not store transactions")?;
-
+    async fn store_transactions(&self, transactions: Vec<CardanoTransaction>) -> StdResult<()> {
+        // Chunk transactions to avoid an error when we exceed sqlite binding limitations
+        for transactions_in_chunk in transactions.chunks(100) {
+            self.create_transactions(transactions_in_chunk.to_vec())
+                .await
+                .with_context(|| "CardanoTransactionRepository can not store transactions")?;
+        }
         Ok(())
     }
 }
@@ -539,7 +541,7 @@ mod tests {
             CardanoTransaction::new("tx-hash-456", 11, 51, "block-hash-456", 100),
         ];
         repository
-            .store_transactions(&cardano_transactions)
+            .create_transactions(cardano_transactions)
             .await
             .unwrap();
 
@@ -609,7 +611,7 @@ mod tests {
             CardanoTransaction::new("tx-hash-456".to_string(), 11, 51, "block-hash-456", 100),
         ];
         repository
-            .store_transactions(&cardano_transactions)
+            .create_transactions(cardano_transactions.clone())
             .await
             .unwrap();
 
@@ -640,7 +642,7 @@ mod tests {
             99,
         )];
         repository
-            .store_transactions(&cardano_transactions)
+            .create_transactions(cardano_transactions)
             .await
             .unwrap();
 
@@ -677,7 +679,7 @@ mod tests {
             CardanoTransaction::new("tx-hash-456".to_string(), 11, 51, "block-hash-456", 100),
         ];
         repository
-            .store_transactions(&cardano_transactions)
+            .create_transactions(cardano_transactions)
             .await
             .unwrap();