Apply review comments

Author: jpraynaud

mithril-aggregator/src/certifier_service.rs

@@ -226,19 +226,10 @@ impl CertifierService for MithrilCertifierService {
     ) -> StdResult<OpenMessage> {
         debug!("CertifierService::create_open_message(signed_entity_type: {signed_entity_type:?}, protocol_message: {protocol_message:?})");
         let current_epoch = self.current_epoch.read().await;
-
-        let open_message = match self
+        let open_message = self
             .open_message_repository
-            .get_open_message(signed_entity_type)
-            .await?
-        {
-            Some(open_message) => open_message,
-            None => {
-                self.open_message_repository
-                    .create_open_message(*current_epoch, signed_entity_type, protocol_message)
-                    .await?
-            }
-        };
+            .create_open_message(*current_epoch, signed_entity_type, protocol_message)
+            .await?;
         info!("CertifierService::create_open_message: created open message for {signed_entity_type:?}");
         debug!(
             "CertifierService::create_open_message: created open message ID='{}'",

mithril-aggregator/src/database/provider/signed_entity.rs

@@ -303,6 +303,7 @@ impl SignedEntityStorer for SignedEntityStoreAdapter {
     }
 }
 
+// TODO: this StoreAdapter implementation is temporary and concerns only the snapshots for the CardanoImmutableFilesFull signed entity type
 #[async_trait]
 impl StoreAdapter for SignedEntityStoreAdapter {
     type Key = String;
@@ -330,7 +331,13 @@ impl StoreAdapter for SignedEntityStoreAdapter {
             .map_err(|e| AdapterError::GeneralError(format!("{e}")))?;
         let signed_entity = cursor
             .next()
-            .map(|signed_entity_record| signed_entity_record.into());
+            .filter(|record| {
+                matches!(
+                    record.signed_entity_type,
+                    SignedEntityType::CardanoImmutableFilesFull(_)
+                )
+            })
+            .map(|record| record.into());
 
         Ok(signed_entity)
     }

mithril-aggregator/src/runtime/runner.rs

@@ -55,7 +55,7 @@ pub trait AggregatorRunnerTrait: Sync + Send {
     /// Return the current beacon from the chain
     async fn get_beacon_from_chain(&self) -> Result<Beacon, Box<dyn StdError + Sync + Send>>;
 
-    /// Retrieves the ucrrent non certified open message.
+    /// Retrieves the current non certified open message.
     async fn get_current_non_certified_open_message(
         &self,
     ) -> Result<Option<OpenMessage>, Box<dyn StdError + Sync + Send>>;
@@ -190,11 +190,29 @@ impl AggregatorRunnerTrait for AggregatorRunner {
             ),
         ];
 
+        // to be tested:
+        // - if MithrilStakeDistribution not exist: Create and returns one (event if a CardanoImmutableFilesFull exist)
+        // - if MithrilStakeDistribution exist but not certified returns it (event if a CardanoImmutableFilesFull exist)
+        // - if MithrilStakeDistribution exist but certified:
+        //   -- existing not certified CardanoImmutableFilesFull ? returns it
+        //   -- existing certified CardanoImmutableFilesFull ? returns None
+        //   -- no existing CardanoImmutableFilesFull ? Create and returns one
         for signed_entity_type in signed_entity_types {
-            let protocol_message = self.compute_protocol_message(&signed_entity_type).await?;
-            let open_message = self
-                .create_open_message(&signed_entity_type, &protocol_message)
-                .await?;
+            let open_message = match self
+                .dependencies
+                .certifier_service
+                .get_open_message(&signed_entity_type)
+                .await?
+            {
+                Some(existing_open_message) => existing_open_message,
+                None => {
+                    let protocol_message =
+                        self.compute_protocol_message(&signed_entity_type).await?;
+                    self.create_open_message(&signed_entity_type, &protocol_message)
+                        .await?
+                }
+            };
+
             if !open_message.is_certified {
                 return Ok(Some(open_message));
             }

mithril-aggregator/tests/create_certificate.rs

@@ -13,7 +13,7 @@ use test_extensions::{utilities::get_test_dir, RuntimeTester};
 async fn create_certificate() {
     let protocol_parameters = ProtocolParameters {
         k: 5,
-        m: 100,
+        m: 150,
         phi_f: 0.95,
     };
     let configuration = Configuration {