Extend usage of 'allow_skip_signer_certification' feature

Instead of having another 'allow_uncertified_signer_registration' feature, for clarity and simplicity.

Author: jpraynaud

mithril-common/Cargo.toml

@@ -54,9 +54,8 @@ mithril-stm = { path = "../mithril-stm", default-features = false, features = ["
 slog-scope = "4.4.0"
 
 [features]
-default = ["allow_uncertified_signer_registration"]
+default = ["allow_skip_signer_certification"]
 portable = ["mithril-stm/portable"]
 test_only = []
 allow_skip_signer_certification = []
-allow_uncertified_signer_registration = []
 

mithril-common/src/crypto_helper/cardano/key_certification.rs

@@ -247,7 +247,7 @@ impl KeyRegWrapper {
             }
             pool_id.ok_or(ProtocolRegistrationErrorWrapper::KesSignatureInvalid)?
         } else {
-            if cfg!(not(feature = "allow_uncertified_signer_registration")) {
+            if cfg!(not(feature = "allow_skip_signer_certification")) {
                 Err(ProtocolRegistrationErrorWrapper::OpCertMissing)?
             }
             println!("WARNING: Uncertified signer regsitration by providing a Pool Id is deprecated and will be removed soon! (Pool Id: {:?})", party_id);

mithril-common/src/crypto_helper/tests_setup.rs

@@ -64,7 +64,7 @@ pub fn setup_signers(
         .into_iter()
         .map(|party_idx| {
             let party_id = if party_idx % 2 == 0
-                || cfg!(not(feature = "allow_uncertified_signer_registration"))
+                || cfg!(not(feature = "allow_skip_signer_certification"))
             {
                 // 50% of signers with key certification if allow unverified signer registration
                 // Or 100% of signers otherwise

mithril-test-lab/mithril-end-to-end/Cargo.toml

@@ -27,6 +27,6 @@ tokio = { version = "1.17.0", features = ["full"] }
 tokio-util = { version = "0.7.1", features = ["codec"] }
 
 [features]
-default = ["allow_uncertified_signer_registration"]
+default = ["allow_skip_signer_certification"]
 portable = ["mithril-common/portable"]
-allow_uncertified_signer_registration = []
+allow_skip_signer_certification = []

mithril-test-lab/mithril-end-to-end/src/mithril/infrastructure.rs

@@ -43,7 +43,7 @@ impl MithrilInfrastructure {
             // Or 100% of signers otherwise
             // TODO: Should be removed once the signer certification is fully deployed
             let enable_certification =
-                index % 2 == 0 || cfg!(not(feature = "allow_uncertified_signer_registration"));
+                index % 2 == 0 || cfg!(not(feature = "allow_skip_signer_certification"));
             let mut signer = Signer::new(
                 aggregator.endpoint(),
                 pool_node,