Add context for certificate db provider calling functions

Author: Damien LACHAUME / PALO-IT

mithril-aggregator/src/services/certifier.rs

@@ -346,7 +346,13 @@ impl CertifierService for MithrilCertifierService {
         let parent_certificate_hash = self
             .certificate_repository
             .get_master_certificate_for_epoch(open_message.epoch)
-            .await?
+            .await
+            .with_context(|| {
+                format!(
+                    "Certifier can not get master certificate for epoch: '{}'",
+                    open_message.epoch
+                )
+            })?
             .map(|cert| cert.hash)
             .ok_or_else(|| Box::new(CertifierServiceError::NoParentCertificateFound))?;
 
@@ -373,7 +379,10 @@ impl CertifierService for MithrilCertifierService {
         let certificate = self
             .certificate_repository
             .create_certificate(certificate)
-            .await?;
+            .await
+            .with_context(|| {
+                "Certifier can not create certificate for signed entity type: '{signed_entity_type}'"
+            })?;
 
         let mut open_message_certified: OpenMessageRecord = open_message_record.into();
         open_message_certified.is_certified = true;
@@ -392,6 +401,7 @@ impl CertifierService for MithrilCertifierService {
         self.certificate_repository
             .get_latest_certificates(last_n)
             .await
+            .with_context(|| "Certifier can not get last '{last_n}' certificates")
     }
 
     async fn verify_certificate_chain(&self, epoch: Epoch) -> StdResult<()> {

mithril-aggregator/src/tools/certificates_hash_migrator.rs

@@ -1,5 +1,5 @@
 use crate::database::provider::{CertificateRepository, SignedEntityStorer};
-use anyhow::anyhow;
+use anyhow::{anyhow, Context};
 use mithril_common::{entities::Certificate, StdResult};
 use slog_scope::{debug, info, trace};
 use std::{collections::HashMap, sync::Arc};
@@ -112,7 +112,8 @@ impl CertificatesHashMigrator {
         debug!("🔧 Certificate Hash Migrator: inserting migrated certificates in the database");
         self.certificate_repository
             .create_many_certificates(migrated_certificates)
-            .await?;
+            .await
+            .with_context(|| "Certificates Hash Migrator can not create many certificates")?;
 
         Ok((old_certificates, old_and_new_hashes))
     }
@@ -163,7 +164,8 @@ impl CertificatesHashMigrator {
         info!("🔧 Certificate Hash Migrator: deleting old certificates in the database");
         self.certificate_repository
             .delete_certificates(&old_certificates.iter().collect::<Vec<_>>())
-            .await?;
+            .await
+            .with_context(|| "Certificate Hash Migrator can not delete certificates")?;
 
         Ok(())
     }
@@ -175,6 +177,7 @@ mod test {
         apply_all_migrations_to_db, disable_foreign_key_support, CertificateRecord,
         CertificateRepository, SignedEntityRecord, SignedEntityStoreAdapter, SignedEntityStorer,
     };
+    use anyhow::Context;
     use mithril_common::{
         entities::{
             Beacon, Certificate, Epoch, ImmutableFileNumber,
@@ -244,7 +247,8 @@ mod test {
         for (certificate, discriminant_maybe) in certificates_and_signed_entity {
             certificate_repository
                 .create_certificate(certificate.clone())
-                .await?;
+                .await
+                .with_context(|| "Certificates Hash Migrator can not create certificate")?;
 
             let signed_entity_maybe = match discriminant_maybe {
                 None => None,

mithril-aggregator/src/tools/genesis.rs

@@ -170,8 +170,11 @@ impl GenesisTools {
             .verify_genesis_certificate(&genesis_certificate, &self.genesis_verifier)
             .await?;
         self.certificate_repository
-            .create_certificate(genesis_certificate)
-            .await?;
+            .create_certificate(genesis_certificate.clone())
+            .await
+            .with_context(|| {
+                "Genesis tool can not create certificate with genesis signature: '{genesis_signature}'"
+            })?;
         Ok(())
     }
 }

mithril-aggregator/tests/test_extensions/runtime_tester.rs

@@ -1,9 +1,11 @@
+use anyhow::Context;
 use mithril_aggregator::database::provider::SignedEntityRecord;
 use mithril_aggregator::{
     dependency_injection::DependenciesBuilder, event_store::EventMessage, AggregatorRuntime,
     Configuration, DumbSnapshotUploader, DumbSnapshotter, SignerRegisterer,
     SignerRegistrationError,
 };
+use mithril_common::StdResult;
 use mithril_common::{
     chain_observer::FakeObserver,
     crypto_helper::ProtocolGenesisSigner,
@@ -178,7 +180,7 @@ impl RuntimeTester {
     pub async fn register_genesis_certificate(
         &mut self,
         fixture: &MithrilFixture,
-    ) -> Result<(), String> {
+    ) -> StdResult<()> {
         let beacon = self.observer.current_beacon().await;
         let genesis_certificate = fixture.create_genesis_certificate(&beacon);
         debug!("genesis_certificate: {genesis_certificate:?}");
@@ -188,7 +190,10 @@ impl RuntimeTester {
             .unwrap()
             .create_certificate(genesis_certificate)
             .await
-            .map_err(|e| format!("Saving the genesis certificate should not fail: {e:?}"))?;
+            .with_context(|| {
+                "Runtime Tester can not create certificate with fixture: '{fixture}'"
+            })?;
+
         Ok(())
     }