Merge pull request #1641 from input-output-hk/damien/1567/handle-unparsed-blocks-in-ctx-parser

dlachaume · web-flow · commit d415b238d7d3 · 2024-04-22T09:59:50.000+02:00
Handle unparsed blocks in Cardano transactions parser
diff --git a/.github/workflows/actions/deploy-terraform-infrastructure/action.yml b/.github/workflows/actions/deploy-terraform-infrastructure/action.yml
@@ -100,6 +100,10 @@ inputs:
   mithril_aggregator_cexplorer_pools_url:
     description: CExplorer url of the list of pools that is used by the mithril aggregator.
     required: false
+  mithril_aggregator_allow_unparsable_block:
+    description: If set no error is returned in case of unparsable block and an error log is written instead. Will be ignored on (pre)production networks.
+    required: false
+    default: "false"
   prometheus_auth_username:
     description: Prometheus metrics endpoint username.
     required: false
@@ -153,7 +157,7 @@ runs:
           environment_prefix                                = "${{ inputs.environment_prefix }}"
           cardano_network                                   = "${{ inputs.cardano_network }}"
           cardano_image_id                                  = "${{ inputs.cardano_node_version }}"
-          cardano_image_registry                          = "${{ inputs.cardano_node_docker_registry }}"
+          cardano_image_registry                            = "${{ inputs.cardano_node_docker_registry }}"
           google_region                                     = "${{ inputs.google_region }}"
           google_zone                                       = "${{ inputs.google_zone }}"
           google_machine_type                               = "${{ inputs.google_machine_type }}"
@@ -178,6 +182,7 @@ runs:
           mithril_aggregator_zstandard_parameters_level     = "${{ inputs.mithril_aggregator_zstandard_parameters_level }}"
           mithril_aggregator_zstandard_parameters_workers   = "${{ inputs.mithril_aggregator_zstandard_parameters_workers }}"
           mithril_aggregator_cexplorer_pools_url            = "${{ inputs.mithril_aggregator_cexplorer_pools_url }}"
+          mithril_aggregator_allow_unparsable_block         = "${{ inputs.mithril_aggregator_allow_unparsable_block }}"
           prometheus_auth_username                          = "${{ inputs.prometheus_auth_username }}"
           prometheus_auth_password                          = "${{ inputs.prometheus_auth_password }}"
           prometheus_ingest_host                            = "${{ inputs.prometheus_ingest_host }}"
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -663,6 +663,7 @@ jobs:
           mithril_aggregator_zstandard_parameters_level: ${{ vars.AGGREGATOR_SNAPSHOT_ZSTANDARD_LEVEL }}
           mithril_aggregator_zstandard_parameters_workers: ${{ vars.AGGREGATOR_SNAPSHOT_ZSTANDARD_WORKERS }}
           mithril_aggregator_cexplorer_pools_url: ${{ vars.AGGREGATOR_CEXPLORER_POOLS_URL }}
+          mithril_aggregator_allow_unparsable_block:  ${{ vars.AGGREGATOR_ALLOW_UNPARSABLE_BLOCK }}
           prometheus_auth_username: ${{ secrets.PROMETHEUS_AUTH_USERNAME }}
           prometheus_auth_password: ${{ secrets.PROMETHEUS_AUTH_PASSWORD }}
           prometheus_ingest_host: ${{ vars.PROMETHEUS_INGEST_HOST }}
diff --git a/.github/workflows/test-deploy-network.yml b/.github/workflows/test-deploy-network.yml
@@ -133,6 +133,7 @@ jobs:
           mithril_aggregator_zstandard_parameters_level: ${{ vars.AGGREGATOR_SNAPSHOT_ZSTANDARD_LEVEL }}
           mithril_aggregator_zstandard_parameters_workers: ${{ vars.AGGREGATOR_SNAPSHOT_ZSTANDARD_WORKERS }}
           mithril_aggregator_cexplorer_pools_url: ${{ vars.AGGREGATOR_CEXPLORER_POOLS_URL }}
+          mithril_aggregator_allow_unparsable_block:  ${{ vars.AGGREGATOR_ALLOW_UNPARSABLE_BLOCK }}
           prometheus_auth_username: ${{ secrets.PROMETHEUS_AUTH_USERNAME }}
           prometheus_auth_password: ${{ secrets.PROMETHEUS_AUTH_PASSWORD }}
           prometheus_ingest_host: ${{ vars.PROMETHEUS_INGEST_HOST }}
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/docs/website/root/manual/developer-docs/nodes/mithril-aggregator.md b/docs/website/root/manual/developer-docs/nodes/mithril-aggregator.md
@@ -445,6 +445,7 @@ Here is a list of the available parameters:
 | `signed_entity_types` | `--signed-entity-types` | - | `SIGNED_ENTITY_TYPES` | Signed entity types parameters (discriminants names in an ordered comma separated list) | - | `MithrilStakeDistribution,CardanoImmutableFilesFull,CardanoStakeDistribution` | - |
 | `snapshot_compression_algorithm` | `--snapshot-compression-algorithm` | - | `SNAPSHOT_COMPRESSION_ALGORITHM` | Compression algorithm of the snapshot archive | `zstandard` | `gzip` or `zstandard` | - |
 | `zstandard_parameters` | - | - | `ZSTANDARD_PARAMETERS__LEVEL` and `ZSTANDARD_PARAMETERS__NUMBER_OF_WORKERS` | Zstandard specific parameters | - | `{ level: 9, number_of_workers: 4 }` | - |
+| `allow_unparsable_block` | `--allow-unparsable-block` | - | `ALLOW_UNPARSABLE_BLOCK` | If set no error is returned in case of unparsable block and an error log is written instead. Will be ignored on (pre)production networks. | `false` | - | - |
 
 `genesis bootstrap` command:
 
diff --git a/docs/website/root/manual/developer-docs/nodes/mithril-signer.md b/docs/website/root/manual/developer-docs/nodes/mithril-signer.md
@@ -162,6 +162,11 @@ Options:
           [env: METRICS_SERVER_PORT=]
           [default: 9090]
 
+      --allow-unparsable-block
+          If set no error is returned in case of unparsable block and an error log is written instead.
+          
+          Will be ignored on (pre)production networks.
+
   -h, --help
           Print help (see a summary with '-h')
 
@@ -246,3 +251,4 @@ Here is a list of the available parameters:
 | `enable_metrics_server` | `--enable-metrics-server` | - | `ENABLE_METRICS_SERVER` | Enable metrics HTTP server (Prometheus endpoint on /metrics) | `false` | - | - |
 | `metrics_server_ip` | `--metrics-server-ip` | - | `METRICS_SERVER_IP` | Metrics HTTP server IP | `0.0.0.0` | - | - |
 | `metrics_server_port` | `--metrics-server-port` | - | `METRICS_SERVER_PORT` | Metrics HTTP server listening port | `9090` | - | - |
+| `allow_unparsable_block` | `--allow-unparsable-block` | - | `ALLOW_UNPARSABLE_BLOCK` | If set no error is returned in case of unparsable block and an error log is written instead. Will be ignored on (pre)production networks. | `false` | - | - |
diff --git a/mithril-aggregator/Cargo.toml b/mithril-aggregator/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "mithril-aggregator"
-version = "0.4.60"
+version = "0.4.61"
 description = "A Mithril Aggregator server"
 authors = { workspace = true }
 edition = { workspace = true }
diff --git a/mithril-aggregator/src/commands/serve_command.rs b/mithril-aggregator/src/commands/serve_command.rs
@@ -36,6 +36,12 @@ pub struct ServeCommand {
     /// Will be ignored if set in conjunction with `--disable-digests-cache`.
     #[clap(long)]
     reset_digests_cache: bool,
+
+    /// If set no error is returned in case of unparsable block and an error log is written instead.
+    ///
+    /// Will be ignored on (pre)production networks.
+    #[clap(long)]
+    allow_unparsable_block: bool,
 }
 
 impl Source for ServeCommand {
diff --git a/mithril-aggregator/src/configuration.rs b/mithril-aggregator/src/configuration.rs
@@ -147,6 +147,11 @@ pub struct Configuration {
 
     /// Time interval at which the signers in [Self::cexplorer_pools_url] will be imported (in minutes).
     pub signer_importer_run_interval: u64,
+
+    /// If set no error is returned in case of unparsable block and an error log is written instead.
+    ///
+    /// Will be ignored on (pre)production networks.
+    pub allow_unparsable_block: bool,
 }
 
 /// Uploader needed to copy the snapshot once computed.
@@ -218,6 +223,7 @@ impl Configuration {
             zstandard_parameters: Some(ZstandardCompressionParameters::default()),
             cexplorer_pools_url: None,
             signer_importer_run_interval: 1,
+            allow_unparsable_block: false,
         }
     }
 
@@ -348,6 +354,11 @@ pub struct DefaultConfiguration {
 
     /// Signer importer run interval default setting
     pub signer_importer_run_interval: u64,
+
+    /// If set no error is returned in case of unparsable block and an error log is written instead.
+    ///
+    /// Will be ignored on (pre)production networks.
+    pub allow_unparsable_block: String,
 }
 
 impl Default for DefaultConfiguration {
@@ -367,6 +378,7 @@ impl Default for DefaultConfiguration {
             snapshot_compression_algorithm: "zstandard".to_string(),
             snapshot_use_cdn_domain: "false".to_string(),
             signer_importer_run_interval: 720,
+            allow_unparsable_block: "false".to_string(),
         }
     }
 }
@@ -465,6 +477,13 @@ impl Source for DefaultConfiguration {
                 ValueKind::from(myself.signer_importer_run_interval),
             ),
         );
+        result.insert(
+            "allow_unparsable_block".to_string(),
+            Value::new(
+                Some(&namespace),
+                ValueKind::from(myself.allow_unparsable_block),
+            ),
+        );
 
         Ok(result)
     }
diff --git a/mithril-aggregator/src/dependency_injection/builder.rs b/mithril-aggregator/src/dependency_injection/builder.rs
@@ -714,10 +714,12 @@ impl DependenciesBuilder {
     }
 
     async fn build_transaction_parser(&mut self) -> Result<Arc<dyn TransactionParser>> {
-        // TODO: 'allow_unparsable_block' parameter should be configurable
-        let allow_unparsable_block = false;
-        let transaction_parser =
-            CardanoTransactionParser::new(self.get_logger().await?, allow_unparsable_block);
+        let transaction_parser = CardanoTransactionParser::new(
+            self.get_logger().await?,
+            self.configuration
+                .get_network()?
+                .compute_allow_unparsable_block(self.configuration.allow_unparsable_block)?,
+        );
 
         Ok(Arc::new(transaction_parser))
     }
diff --git a/mithril-common/Cargo.toml b/mithril-common/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "mithril-common"
-version = "0.3.32"
+version = "0.3.33"
 description = "Common types, interfaces, and utilities for Mithril nodes."
 authors = { workspace = true }
 edition = { workspace = true }
diff --git a/mithril-common/src/cardano_transaction_parser.rs b/mithril-common/src/cardano_transaction_parser.rs
@@ -11,7 +11,7 @@ use anyhow::{anyhow, Context};
 use async_trait::async_trait;
 use pallas_hardano::storage::immutable::chunk::{read_blocks, Reader};
 use pallas_traverse::MultiEraBlock;
-use slog::{error, Logger};
+use slog::{error, warn, Logger};
 use std::path::Path;
 use tokio::sync::RwLock;
 
@@ -131,6 +131,12 @@ pub struct CardanoTransactionParser {
 impl CardanoTransactionParser {
     /// Factory
     pub fn new(logger: Logger, allow_unparsable_block: bool) -> Self {
+        if allow_unparsable_block {
+            warn!(
+                logger,
+                "The 'allow_unparsable_block' option is activated. This option should only be used on test networks.")
+        }
+
         Self {
             logger,
             allow_unparsable_block,
@@ -372,4 +378,36 @@ mod tests {
 
         assert_eq!(transactions.len(), tx_count);
     }
+
+    #[tokio::test]
+    async fn test_instantiate_parser_with_allow_unparsable_block_should_log_warning() {
+        let temp_dir = TempDir::create(
+            "cardano_transaction_parser",
+            "test_instantiate_parser_with_allow_unparsable_block_should_log_warning",
+        );
+        let filepath = temp_dir.join("test.log");
+        // We create a block to drop the logger and force a flush before we read the log file.
+        {
+            let _ = CardanoTransactionParser::new(create_file_logger(&filepath), true);
+        }
+
+        let log_file = std::fs::read_to_string(&filepath).unwrap();
+        assert!(log_file.contains("The 'allow_unparsable_block' option is activated. This option should only be used on test networks."));
+    }
+
+    #[tokio::test]
+    async fn test_instantiate_parser_without_allow_unparsable_block_should_not_log_warning() {
+        let temp_dir = TempDir::create(
+            "cardano_transaction_parser",
+            "test_instantiate_parser_without_allow_unparsable_block_should_not_log_warning",
+        );
+        let filepath = temp_dir.join("test.log");
+        // We create a block to drop the logger and force a flush before we read the log file.
+        {
+            let _ = CardanoTransactionParser::new(create_file_logger(&filepath), false);
+        }
+
+        let log_file = std::fs::read_to_string(&filepath).unwrap();
+        assert!(!log_file.contains("The 'allow_unparsable_block' option is activated. This option should only be used on test networks."));
+    }
 }
diff --git a/mithril-common/src/entities/cardano_network.rs b/mithril-common/src/entities/cardano_network.rs
@@ -2,7 +2,7 @@ use serde::{Deserialize, Serialize};
 use std::fmt::Display;
 use thiserror::Error;
 
-use crate::MagicId;
+use crate::{MagicId, StdResult};
 
 const MAINNET_MAGIC_ID: MagicId = 764824073;
 const TESTNET_MAGIC_ID: MagicId = 1097911063;
@@ -74,6 +74,17 @@ impl CardanoNetwork {
             CardanoNetwork::TestNet(magic_id) => magic_id,
         }
     }
+
+    /// Determines whether unparsable blocks should be allowed based on the specific Cardano network.
+    pub fn compute_allow_unparsable_block(&self, allow_unparsable_block: bool) -> StdResult<bool> {
+        let allow_unparsable_block = match self {
+            CardanoNetwork::MainNet => false,
+            CardanoNetwork::TestNet(id) if *id == PREPROD_MAGIC_ID => false,
+            _ => allow_unparsable_block,
+        };
+
+        Ok(allow_unparsable_block)
+    }
 }
 
 impl Display for CardanoNetwork {
@@ -144,4 +155,71 @@ mod tests {
         );
         assert!(CardanoNetwork::from_code("private".to_string(), None).is_err());
     }
+
+    #[test]
+    fn compute_allow_unparsable_block_should_always_return_false_on_mainnet_and_preprod() {
+        let allow_unparsable_block = CardanoNetwork::MainNet
+            .compute_allow_unparsable_block(false)
+            .unwrap();
+        assert!(!allow_unparsable_block);
+
+        let allow_unparsable_block = CardanoNetwork::MainNet
+            .compute_allow_unparsable_block(true)
+            .unwrap();
+        assert!(!allow_unparsable_block);
+
+        let allow_unparsable_block = CardanoNetwork::TestNet(PREPROD_MAGIC_ID)
+            .compute_allow_unparsable_block(false)
+            .unwrap();
+        assert!(!allow_unparsable_block);
+
+        let allow_unparsable_block = CardanoNetwork::TestNet(PREPROD_MAGIC_ID)
+            .compute_allow_unparsable_block(true)
+            .unwrap();
+        assert!(!allow_unparsable_block);
+    }
+
+    #[test]
+    fn compute_allow_unparsable_block_should_return_value_passed_in_parameter_on_all_networks_other_than_mainnet_and_preprod(
+    ) {
+        let allow_unparsable_block = CardanoNetwork::TestNet(PREVIEW_MAGIC_ID)
+            .compute_allow_unparsable_block(false)
+            .unwrap();
+        assert!(!allow_unparsable_block);
+
+        let allow_unparsable_block = CardanoNetwork::TestNet(PREVIEW_MAGIC_ID)
+            .compute_allow_unparsable_block(true)
+            .unwrap();
+        assert!(allow_unparsable_block);
+
+        let allow_unparsable_block = CardanoNetwork::TestNet(SANCHONET_MAGIC_ID)
+            .compute_allow_unparsable_block(false)
+            .unwrap();
+        assert!(!allow_unparsable_block);
+
+        let allow_unparsable_block = CardanoNetwork::TestNet(SANCHONET_MAGIC_ID)
+            .compute_allow_unparsable_block(true)
+            .unwrap();
+        assert!(allow_unparsable_block);
+
+        let allow_unparsable_block = CardanoNetwork::TestNet(TESTNET_MAGIC_ID)
+            .compute_allow_unparsable_block(false)
+            .unwrap();
+        assert!(!allow_unparsable_block);
+
+        let allow_unparsable_block = CardanoNetwork::TestNet(TESTNET_MAGIC_ID)
+            .compute_allow_unparsable_block(true)
+            .unwrap();
+        assert!(allow_unparsable_block);
+
+        let allow_unparsable_block = CardanoNetwork::DevNet(123)
+            .compute_allow_unparsable_block(false)
+            .unwrap();
+        assert!(!allow_unparsable_block);
+
+        let allow_unparsable_block = CardanoNetwork::DevNet(123)
+            .compute_allow_unparsable_block(true)
+            .unwrap();
+        assert!(allow_unparsable_block);
+    }
 }
diff --git a/mithril-infra/assets/docker/docker-compose-aggregator-auth-p2p.yaml b/mithril-infra/assets/docker/docker-compose-aggregator-auth-p2p.yaml
@@ -75,6 +75,7 @@ services:
       - ERA_READER_ADAPTER_TYPE=${ERA_READER_ADAPTER_TYPE}
       - ERA_READER_ADAPTER_PARAMS=${ERA_READER_ADAPTER_PARAMS}
       - CEXPLORER_POOLS_URL=${CEXPLORER_POOLS_URL}
+      - ALLOW_UNPARSABLE_BLOCK=${ALLOW_UNPARSABLE_BLOCK}
     volumes:
       - ../data/${NETWORK}/mithril-aggregator/mithril:/mithril-aggregator/mithril
       - ../data/${NETWORK}/mithril-aggregator/cardano/db:/db
diff --git a/mithril-infra/assets/docker/docker-compose-aggregator-auth.yaml b/mithril-infra/assets/docker/docker-compose-aggregator-auth.yaml
@@ -75,6 +75,7 @@ services:
       - ERA_READER_ADAPTER_TYPE=${ERA_READER_ADAPTER_TYPE}
       - ERA_READER_ADAPTER_PARAMS=${ERA_READER_ADAPTER_PARAMS}
       - CEXPLORER_POOLS_URL=${CEXPLORER_POOLS_URL}
+      - ALLOW_UNPARSABLE_BLOCK=${ALLOW_UNPARSABLE_BLOCK}
     volumes:
       - ../data/${NETWORK}/mithril-aggregator/mithril:/mithril-aggregator/mithril
       - ../data/${NETWORK}/mithril-aggregator/cardano/db:/db
diff --git a/mithril-infra/assets/docker/docker-compose-aggregator-noauth-p2p.yaml b/mithril-infra/assets/docker/docker-compose-aggregator-noauth-p2p.yaml
@@ -75,6 +75,7 @@ services:
       - ERA_READER_ADAPTER_TYPE=${ERA_READER_ADAPTER_TYPE}
       - ERA_READER_ADAPTER_PARAMS=${ERA_READER_ADAPTER_PARAMS}
       - CEXPLORER_POOLS_URL=${CEXPLORER_POOLS_URL}
+      - ALLOW_UNPARSABLE_BLOCK=${ALLOW_UNPARSABLE_BLOCK}
     volumes:
       - ../data/${NETWORK}/mithril-aggregator/mithril:/mithril-aggregator/mithril
       - ../data/${NETWORK}/mithril-aggregator/cardano/db:/db
diff --git a/mithril-infra/assets/docker/docker-compose-aggregator-noauth.yaml b/mithril-infra/assets/docker/docker-compose-aggregator-noauth.yaml
@@ -75,6 +75,7 @@ services:
       - ERA_READER_ADAPTER_TYPE=${ERA_READER_ADAPTER_TYPE}
       - ERA_READER_ADAPTER_PARAMS=${ERA_READER_ADAPTER_PARAMS}
       - CEXPLORER_POOLS_URL=${CEXPLORER_POOLS_URL}
+      - ALLOW_UNPARSABLE_BLOCK=${ALLOW_UNPARSABLE_BLOCK}
     volumes:
       - ../data/${NETWORK}/mithril-aggregator/mithril:/mithril-aggregator/mithril
       - ../data/${NETWORK}/mithril-aggregator/cardano/db:/db
diff --git a/mithril-infra/mithril.aggregator.tf b/mithril-infra/mithril.aggregator.tf
@@ -66,6 +66,7 @@ EOT
       "export ERA_READER_ADAPTER_PARAMS=$(jq -nc --arg address $(wget -q -O - ${var.mithril_era_reader_address_url}) --arg verification_key $(wget -q -O - ${var.mithril_era_reader_verification_key_url}) '{\"address\": $address, \"verification_key\": $verification_key}')",
       "export ERA_READER_SECRET_KEY='${var.mithril_era_reader_secret_key}'",
       "export CEXPLORER_POOLS_URL='${var.mithril_aggregator_cexplorer_pools_url}'",
+      "export ALLOW_UNPARSABLE_BLOCK=${var.mithril_aggregator_allow_unparsable_block}",
       "export LOGGING_DRIVER='${var.mithril_container_logging_driver}'",
       "export AUTH_USER_PASSWORD=$(htpasswd -nb ${var.mithril_aggregator_auth_username} ${var.mithril_aggregator_auth_password})",
       "export AGGREGATOR_RELAY_LISTEN_PORT='${local.mithril_aggregator_relay_mithril_listen_port}'",
diff --git a/mithril-infra/variables.tf b/mithril-infra/variables.tf
diff --git a/mithril-signer/Cargo.toml b/mithril-signer/Cargo.toml
diff --git a/mithril-signer/src/aggregator_client.rs b/mithril-signer/src/aggregator_client.rs
diff --git a/mithril-signer/src/configuration.rs b/mithril-signer/src/configuration.rs
diff --git a/mithril-signer/src/main.rs b/mithril-signer/src/main.rs
diff --git a/mithril-signer/src/runtime/runner.rs b/mithril-signer/src/runtime/runner.rs
diff --git a/mithril-signer/src/runtime/signer_services.rs b/mithril-signer/src/runtime/signer_services.rs

Original file line number	Diff line number	Diff line change
`@@ -147,6 +147,11 @@ pub struct Configuration {`
`147`	`147`
`148`	`148`	`/// Time interval at which the signers in [Self::cexplorer_pools_url] will be imported (in minutes).`
`149`	`149`	`pub signer_importer_run_interval: u64,`
	`150`	`+`
	`151`	`+ /// If set no error is returned in case of unparsable block and an error log is written instead.`
	`152`	`+ ///`
	`153`	`+ /// Will be ignored on (pre)production networks.`
	`154`	`+ pub allow_unparsable_block: bool,`
`150`	`155`	`}`
`151`	`156`
`152`	`157`	`/// Uploader needed to copy the snapshot once computed.`
`@@ -218,6 +223,7 @@ impl Configuration {`
`218`	`223`	`zstandard_parameters: Some(ZstandardCompressionParameters::default()),`
`219`	`224`	`cexplorer_pools_url: None,`
`220`	`225`	`signer_importer_run_interval: 1,`
	`226`	`+ allow_unparsable_block: false,`
`221`	`227`	`}`
`222`	`228`	`}`
`223`	`229`
`@@ -348,6 +354,11 @@ pub struct DefaultConfiguration {`
`348`	`354`
`349`	`355`	`/// Signer importer run interval default setting`
`350`	`356`	`pub signer_importer_run_interval: u64,`
	`357`	`+`
	`358`	`+ /// If set no error is returned in case of unparsable block and an error log is written instead.`
	`359`	`+ ///`
	`360`	`+ /// Will be ignored on (pre)production networks.`
	`361`	`+ pub allow_unparsable_block: String,`
`351`	`362`	`}`
`352`	`363`
`353`	`364`	`impl Default for DefaultConfiguration {`
`@@ -367,6 +378,7 @@ impl Default for DefaultConfiguration {`
`367`	`378`	`snapshot_compression_algorithm: "zstandard".to_string(),`
`368`	`379`	`snapshot_use_cdn_domain: "false".to_string(),`
`369`	`380`	`signer_importer_run_interval: 720,`
	`381`	`+ allow_unparsable_block: "false".to_string(),`
`370`	`382`	`}`
`371`	`383`	`}`
`372`	`384`	`}`
`@@ -465,6 +477,13 @@ impl Source for DefaultConfiguration {`
`465`	`477`	`ValueKind::from(myself.signer_importer_run_interval),`
`466`	`478`	`),`
`467`	`479`	`);`
	`480`	`+ result.insert(`
	`481`	`+ "allow_unparsable_block".to_string(),`
	`482`	`+ Value::new(`
	`483`	`+ Some(&namespace),`
	`484`	`+ ValueKind::from(myself.allow_unparsable_block),`
	`485`	`+ ),`
	`486`	`+ );`
`468`	`487`
`469`	`488`	`Ok(result)`
`470`	`489`	`}`