Skip to content

Commit d435f70

Browse files
committed
Remove portable features for all other crates
As it's no longer needed since it does nothing now.
1 parent 4310007 commit d435f70

File tree

7 files changed

+2
-17
lines changed

7 files changed

+2
-17
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@ jobs:
3232
# We separate the build in 2 steps as we want to avoid side effects with Rust feature unification.
3333
- name: Cargo build - Tooling
3434
shell: bash
35-
run: |
36-
cargo build --features portable --release -p mithril-end-to-end
35+
run: cargo build --release -p mithril-end-to-end
3736

3837
- name: Build Mithril workspace & publish artifacts
3938
uses: ./.github/workflows/actions/build-upload-mithril-artifact
@@ -166,7 +165,7 @@ jobs:
166165

167166
include:
168167
- os: ubuntu-22.04
169-
test-args: --features portable,full,unstable --workspace
168+
test-args: --features full,unstable --workspace
170169
# Only test client on windows & mac (since its the only binaries supported for those os for now)
171170
- os: macos-12
172171
test-args: --package mithril-client --package mithril-client-cli --features full,unstable

demo/protocol-demo/Cargo.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,3 @@ mithril-stm = { path = "../../mithril-stm" }
3030
mithril-stm = { path = "../../mithril-stm", default-features = false, features = [
3131
"num-integer-backend",
3232
] }
33-
34-
[features]
35-
portable = ["mithril-common/portable", "mithril-stm/portable"]

mithril-aggregator/Cargo.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,4 @@ slog-term = "2.9.0"
5757
tempfile = "3.9.0"
5858

5959
[features]
60-
portable = [
61-
"mithril-common/portable",
62-
] # portable feature avoids SIGILL crashes on CPUs not supporting Intel ADX instruction set when built on CPUs that support it
6360
bundle_openssl = ["dep:openssl", "dep:openssl-probe"]

mithril-client-cli/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,5 +53,4 @@ tokio = { version = "1.35.1", features = ["full"] }
5353
mithril-common = { path = "../mithril-common", features = ["test_tools"] }
5454

5555
[features]
56-
portable = ["mithril-client/portable"]
5756
bundle_openssl = ["dep:openssl", "dep:openssl-probe"]

mithril-common/Cargo.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,6 @@ fs = [
117117
"dep:pallas-traverse",
118118
]
119119

120-
# Portable feature avoids SIGILL crashes on CPUs not supporting Intel ADX instruction set when built on CPUs that support it
121-
portable = ["mithril-stm/portable"]
122-
123120
# Disable signer certification, to be used only for tests
124121
allow_skip_signer_certification = []
125122
# Enable all tests tools

mithril-signer/Cargo.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,4 @@ prometheus-parse = "0.2.5"
4646
slog-term = "2.9.0"
4747

4848
[features]
49-
portable = [
50-
"mithril-common/portable",
51-
] # portable feature avoids SIGILL crashes on CPUs not supporting Intel ADX instruction set when built on CPUs that support it
5249
bundle_openssl = ["dep:openssl", "dep:openssl-probe"]

mithril-test-lab/mithril-end-to-end/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,5 +41,4 @@ tokio-util = { version = "0.7.10", features = ["codec"] }
4141

4242
[features]
4343
default = []
44-
portable = ["mithril-common/portable"]
4544
allow_skip_signer_certification = []

0 commit comments

Comments
 (0)