refactor(common): remove test only CardanoTransactionsSigningConfig::new

Has its value was low and it was even confusing since both parameters
use the same type.
This allow to remove the last usage of `cfg_test_tools` in mithril
common, beside the one on the test module.

Author: Alenar

mithril-aggregator/src/database/query/epoch_settings/get_epoch_settings.rs

@@ -69,7 +69,10 @@ mod tests {
         );
 
         assert_eq!(
-            CardanoTransactionsSigningConfig::new(BlockNumber(10), BlockNumber(15)),
+            CardanoTransactionsSigningConfig {
+                security_parameter: BlockNumber(10),
+                step: BlockNumber(15)
+            },
             epoch_settings_record.cardano_transactions_signing_config
         );
 

mithril-aggregator/src/database/query/epoch_settings/update_epoch_settings.rs

@@ -68,10 +68,10 @@ mod tests {
 
         let epoch_settings_send_to_update = AggregatorEpochSettings {
             protocol_parameters: fake_data::protocol_parameters(),
-            cardano_transactions_signing_config: CardanoTransactionsSigningConfig::new(
-                BlockNumber(24),
-                BlockNumber(62),
-            ),
+            cardano_transactions_signing_config: CardanoTransactionsSigningConfig {
+                security_parameter: BlockNumber(24),
+                step: BlockNumber(62),
+            },
         };
         let record_returned_by_update_query = connection
             .fetch_first(UpdateEpochSettingsQuery::one(

mithril-aggregator/src/database/test_helper.rs

@@ -205,10 +205,10 @@ pub fn insert_epoch_settings(
             Epoch(1),
             AggregatorEpochSettings {
                 protocol_parameters: ProtocolParameters::new(1, 2, 1.0),
-                cardano_transactions_signing_config: CardanoTransactionsSigningConfig::new(
-                    BlockNumber(0),
-                    BlockNumber(0),
-                ),
+                cardano_transactions_signing_config: CardanoTransactionsSigningConfig {
+                    security_parameter: BlockNumber(0),
+                    step: BlockNumber(0),
+                },
             },
         )
         .filters()
@@ -222,7 +222,10 @@ pub fn insert_epoch_settings(
             (
                 epoch,
                 ProtocolParameters::new(*epoch, epoch + 1, 1.0),
-                CardanoTransactionsSigningConfig::new(BlockNumber(epoch * 10), BlockNumber(15)),
+                CardanoTransactionsSigningConfig {
+                    security_parameter: BlockNumber(epoch * 10),
+                    step: BlockNumber(15),
+                },
             )
         })
     {

mithril-aggregator/src/services/epoch_service.rs

@@ -1125,8 +1125,10 @@ mod tests {
     async fn inform_epoch_get_signed_entity_config_from_its_dependencies_and_store() {
         let epoch = Epoch(5);
 
-        let cardano_transactions_signing_config =
-            CardanoTransactionsSigningConfig::new(BlockNumber(29), BlockNumber(986));
+        let cardano_transactions_signing_config = CardanoTransactionsSigningConfig {
+            security_parameter: BlockNumber(29),
+            step: BlockNumber(986),
+        };
         let allowed_discriminants = BTreeSet::from([
             SignedEntityTypeDiscriminants::CardanoTransactions,
             SignedEntityTypeDiscriminants::CardanoImmutableFilesFull,

mithril-aggregator/src/services/message.rs

@@ -467,17 +467,17 @@ mod tests {
             assert_eq!(message.next_signers.len(), 3);
             assert_eq!(
                 message.cardano_transactions_signing_config,
-                Some(CardanoTransactionsSigningConfig::new(
-                    BlockNumber(0),
-                    BlockNumber(15)
-                ))
+                Some(CardanoTransactionsSigningConfig {
+                    security_parameter: BlockNumber(0),
+                    step: BlockNumber(15)
+                })
             );
             assert_eq!(
                 message.next_cardano_transactions_signing_config,
-                Some(CardanoTransactionsSigningConfig::new(
-                    BlockNumber(0),
-                    BlockNumber(15)
-                ))
+                Some(CardanoTransactionsSigningConfig {
+                    security_parameter: BlockNumber(0),
+                    step: BlockNumber(15)
+                })
             );
         }
 
@@ -561,17 +561,17 @@ mod tests {
         #[tokio::test]
         async fn get_epoch_settings_message_retrieves_signing_configuration_from_epoch_service() {
             let current_epoch_settings = AggregatorEpochSettings {
-                cardano_transactions_signing_config: CardanoTransactionsSigningConfig::new(
-                    BlockNumber(100),
-                    BlockNumber(15),
-                ),
+                cardano_transactions_signing_config: CardanoTransactionsSigningConfig {
+                    security_parameter: BlockNumber(100),
+                    step: BlockNumber(15),
+                },
                 ..AggregatorEpochSettings::dummy()
             };
             let next_epoch_settings = AggregatorEpochSettings {
-                cardano_transactions_signing_config: CardanoTransactionsSigningConfig::new(
-                    BlockNumber(200),
-                    BlockNumber(15),
-                ),
+                cardano_transactions_signing_config: CardanoTransactionsSigningConfig {
+                    security_parameter: BlockNumber(200),
+                    step: BlockNumber(15),
+                },
                 ..AggregatorEpochSettings::dummy()
             };
             let epoch_service = FakeEpochServiceBuilder {

mithril-common/src/entities/signed_entity_config.rs

@@ -112,16 +112,6 @@ pub struct CardanoTransactionsSigningConfig {
 }
 
 impl CardanoTransactionsSigningConfig {
-    cfg_test_tools! {
-        /// Create a new CardanoTransactionsSigningConfig
-        pub fn new(security_parameter: BlockNumber, step: BlockNumber) -> Self {
-            Self {
-                security_parameter,
-                step,
-            }
-        }
-    }
-
     /// Compute the block number to be signed based on the chain tip block number.
     ///
     /// The latest block number to be signed is the highest multiple of the step less or equal than the