feat(relay): use binary encoding for exchanging messages in P2P pubsub topics

Author: jpraynaud

Cargo.lock

@@ -15,6 +15,7 @@ future_dmq = ["dep:mithril-dmq"]
 
 [dependencies]
 anyhow = { workspace = true }
+bincode = { version = "2.0.1" }
 clap = { workspace = true }
 config = { workspace = true }
 libp2p = { version = "0.56.0", features = [

mithril-relay/Cargo.toml

@@ -11,6 +11,7 @@ use libp2p::{
 };
 use mithril_common::{
     StdResult,
+    crypto_helper::{TryFromBytes, TryToBytes},
     logging::LoggerExtensions,
     messages::{RegisterSignatureMessageHttp, RegisterSignerMessage},
 };
@@ -74,6 +75,25 @@ pub enum BroadcastMessage {
     RegisterSignatureDmq(DmqMessage),
 }
 
+impl TryToBytes for BroadcastMessage {
+    fn to_bytes_vec(&self) -> StdResult<Vec<u8>> {
+        let bytes =
+            bincode::serde::encode_to_vec(self, bincode::config::standard()).map_err(|e| e.into());
+
+        bytes
+    }
+}
+
+impl TryFromBytes for BroadcastMessage {
+    fn try_from_bytes(bytes: &[u8]) -> StdResult<Self> {
+        let (res, _) =
+            bincode::serde::decode_from_slice::<Self, _>(bytes, bincode::config::standard())
+                .map_err(|e| anyhow!(e))?;
+
+        Ok(res)
+    }
+}
+
 /// A peer in the P2P network
 pub struct Peer {
     topics: HashMap<TopicName, gossipsub::IdentTopic>,
@@ -185,7 +205,7 @@ impl Peer {
         match event {
             PeerEvent::Behaviour {
                 event: PeerBehaviourEvent::Gossipsub(gossipsub::Event::Message { message, .. }),
-            } => Ok(Some(serde_json::from_slice(&message.data)?)),
+            } => Ok(Some(BroadcastMessage::try_from_bytes(&message.data)?)),
             _ => Ok(None),
         }
     }
@@ -247,6 +267,17 @@ impl Peer {
         )
     }
 
+    /// Publish a signer registration on the P2P pubsub
+    pub fn publish_signer_registration(
+        &mut self,
+        message: &RegisterSignerMessage,
+    ) -> StdResult<gossipsub::MessageId> {
+        self.publish_broadcast_message(
+            &BroadcastMessage::RegisterSignerHttp(message.to_owned()),
+            mithril_p2p_topic::SIGNERS_HTTP,
+        )
+    }
+
     /// Publish a broadcast message on the P2P pubsub
     pub fn publish_broadcast_message(
         &mut self,
@@ -261,9 +292,10 @@ impl Peer {
                 format!("Can not publish broadcast message on invalid topic: {topic_name}")
             })?
             .to_owned();
-        let data = serde_json::to_vec(message).with_context(|| {
+        let data = message.to_bytes_vec().with_context(|| {
             format!("Can not publish broadcast message with invalid format on topic {topic_name}")
         })?;
+        println!("Publishing message on topic {topic_name}: {:?}", data.len());
 
         let message_id = self
             .swarm
@@ -283,17 +315,6 @@ impl Peer {
         Ok(message_id.to_owned())
     }
 
-    /// Publish a signer registration on the P2P pubsub
-    pub fn publish_signer_registration(
-        &mut self,
-        message: &RegisterSignerMessage,
-    ) -> StdResult<gossipsub::MessageId> {
-        self.publish_broadcast_message(
-            &BroadcastMessage::RegisterSignerHttp(message.to_owned()),
-            mithril_p2p_topic::SIGNERS_HTTP,
-        )
-    }
-
     /// Connect to a remote peer
     pub fn dial(&mut self, addr: Multiaddr) -> StdResult<()> {
         debug!(self.logger, "Dialing to"; "address" => ?addr, "local_peer_id" => ?self.local_peer_id());