Clean mithril-signer

Author: dlachaume

Cargo.lock

@@ -9,10 +9,6 @@ homepage = { workspace = true }
 license = { workspace = true }
 repository = { workspace = true }
 
-[[bench]]
-name = "cardano_transactions"
-harness = false
-
 [dependencies]
 anyhow = "1.0.79"
 async-trait = "0.1.77"
@@ -46,7 +42,6 @@ tokio = { version = "1.37.0", features = ["full"] }
 tikv-jemallocator = { version = "0.5.4", optional = true }
 
 [dev-dependencies]
-criterion = { version = "0.5.1", features = ["html_reports", "async_tokio"] }
 httpmock = "0.7.0"
 mithril-common = { path = "../mithril-common" }
 mockall = "0.12.1"

mithril-signer/Cargo.toml

@@ -30,7 +30,7 @@ use mithril_persistence::sqlite::GetAllProvider;
 /// This is a business oriented layer to perform actions on the database through
 /// providers.
 pub struct CardanoTransactionRepository {
-    pub connection: Arc<SqliteConnection>,
+    connection: Arc<SqliteConnection>,
 }
 
 impl CardanoTransactionRepository {
@@ -116,21 +116,6 @@ impl CardanoTransactionRepository {
         let records: Vec<CardanoTransactionRecord> =
             transactions.into_iter().map(|tx| tx.into()).collect();
 
-        let provider = InsertCardanoTransactionProvider::new(&self.connection);
-        let filters = provider.get_insert_many_condition(records)?;
-        provider.find(filters)?.next();
-
-        Ok(vec![])
-    }
-
-    /// Create new [CardanoTransactionRecord]s in the database.
-    pub async fn create_transactions_and_collect<T: Into<CardanoTransactionRecord>>(
-        &self,
-        transactions: Vec<T>,
-    ) -> StdResult<Vec<CardanoTransactionRecord>> {
-        let records: Vec<CardanoTransactionRecord> =
-            transactions.into_iter().map(|tx| tx.into()).collect();
-
         let provider = InsertCardanoTransactionProvider::new(&self.connection);
         let filters = provider.get_insert_many_condition(records)?;
         let cursor = provider.find(filters)?;
@@ -153,34 +138,6 @@ impl CardanoTransactionRepository {
         Ok(cursor.collect())
     }
 
-    pub async fn store_transactions_with_chunks_size(
-        &self,
-        transactions: Vec<CardanoTransaction>,
-        chunks_size: usize,
-    ) -> StdResult<()> {
-        // Chunk transactions to avoid an error when we exceed sqlite binding limitations
-        for transactions_in_chunk in transactions.chunks(chunks_size) {
-            self.create_transactions(transactions_in_chunk.to_vec())
-                .await
-                .with_context(|| "CardanoTransactionRepository can not store transactions")?;
-        }
-        Ok(())
-    }
-
-    pub async fn store_transactions_with_chunks_size_and_collect(
-        &self,
-        transactions: Vec<CardanoTransaction>,
-        chunks_size: usize,
-    ) -> StdResult<()> {
-        // Chunk transactions to avoid an error when we exceed sqlite binding limitations
-        for transactions_in_chunk in transactions.chunks(chunks_size) {
-            self.create_transactions_and_collect(transactions_in_chunk.to_vec())
-                .await
-                .with_context(|| "CardanoTransactionRepository can not store transactions")?;
-        }
-        Ok(())
-    }
-
     // TODO: remove this function when the Cardano transaction signature is based on block number instead of immutable number
     async fn get_highest_block_number_for_immutable_number(
         &self,
@@ -281,7 +238,7 @@ impl TransactionStore for CardanoTransactionRepository {
     async fn store_transactions(&self, transactions: Vec<CardanoTransaction>) -> StdResult<()> {
         // Chunk transactions to avoid an error when we exceed sqlite binding limitations
         for transactions_in_chunk in transactions.chunks(100) {
-            self.create_transactions_and_collect(transactions_in_chunk.to_vec())
+            self.create_transactions(transactions_in_chunk.to_vec())
                 .await
                 .with_context(|| "CardanoTransactionRepository can not store transactions")?;
         }