refactor(aggregator): move test::mocks to test::double::mocks

As mocks are test double, it should have been there in the first place

Author: Alenar

internal/cardano-node/mithril-cardano-node-chain/src/test/mod.rs

@@ -8,4 +8,5 @@ pub mod double;
 #[cfg(test)]
 pub(crate) mod test_cli_runner;
 
+#[cfg(test)]
 mithril_common::define_test_logger!();

internal/cardano-node/mithril-cardano-node-internal-database/src/test/mod.rs

@@ -10,4 +10,5 @@ pub mod fake_data;
 
 pub use dummy_cardano_db::{DummyCardanoDb, DummyCardanoDbBuilder};
 
+#[cfg(test)]
 mithril_common::define_test_logger!();

internal/mithril-dmq/src/test/mod.rs

@@ -9,4 +9,5 @@ pub mod double;
 #[cfg(test)]
 pub(crate) mod payload;
 
+#[cfg(test)]
 mithril_common::define_test_logger!();

mithril-aggregator/src/services/certificate_chain_synchronizer/synchronizer_service.rs

@@ -237,7 +237,7 @@ mod tests {
         MockOpenMessageStorer, MockRemoteCertificateRetriever, MockSynchronizedCertificateStorer,
     };
     use crate::test::TestLogger;
-    use crate::test::mocks::MockCertificateVerifier;
+    use crate::test::double::mocks::MockCertificateVerifier;
 
     use super::*;
 

mithril-aggregator/src/services/epoch_service.rs

@@ -849,7 +849,7 @@ mod tests {
 
     use crate::store::{FakeEpochSettingsStorer, MockVerificationKeyStorer};
     use crate::test::TestLogger;
-    use crate::test::mocks::MockStakeStore;
+    use crate::test::double::mocks::MockStakeStore;
 
     use super::*;
 

mithril-aggregator/src/services/signer_registration/follower.rs

@@ -189,7 +189,7 @@ mod tests {
             FakeEpochService, MockLeaderAggregatorClient, MockSignerRecorder,
             MockSignerRegistrationVerifier,
         },
-        test::mocks::MockStakeStore,
+        test::double::mocks::MockStakeStore,
     };
 
     use super::*;

mithril-aggregator/src/services/stake_distribution.rs

@@ -227,7 +227,7 @@ mod tests {
     use mithril_common::temp_dir;
 
     use crate::dependency_injection::DependenciesBuilder;
-    use crate::test::mocks::MockChainObserver;
+    use crate::test::double::mocks::MockChainObserver;
 
     use super::*;
 

mithril-aggregator/src/test/mocks.rs renamed to mithril-aggregator/src/test/double/mocks.rs

@@ -1 +1,7 @@
+//! Test doubles
+//!
+//! Enable unit testing with controlled inputs and predictable behavior.
+
 mod dummies;
+#[cfg(test)]
+pub mod mocks;

mithril-aggregator/src/test/double/mod.rs

@@ -1,5 +1,4 @@
-mod double;
-#[cfg(test)]
-pub mod mocks;
+pub mod double;
 
+#[cfg(test)]
 mithril_common::define_test_logger!();