Some renaming

Author: sfauvel

mithril-aggregator/src/database/repository/epoch_settings_store.rs

@@ -66,7 +66,7 @@ impl EpochSettingsStorer for EpochSettingsStore {
         let epoch_settings_record = self
             .connection
             .fetch_first(UpdateEpochSettingsQuery::one(epoch, epoch_settings))
-            .with_context(|| format!("persist epoch settings failure: epoch = {epoch:?}"))?
+            .with_context(|| format!("persist epoch settings failure for epoch {epoch:?}"))?
             .unwrap_or_else(|| panic!("No entity returned by the persister, epoch = {epoch:?}"));
 
         Ok(Some(epoch_settings_record.into()))

mithril-aggregator/src/database/repository/pending_certificate_repository.rs

@@ -176,7 +176,7 @@ mod test {
             )
             .unwrap();
 
-        assert!(pending_certificate_adapter.is_key_hash_exist("Certificate"));
+        assert!(pending_certificate_adapter.has_key_hash("Certificate"));
 
         // We finish the migration
         ConnectionBuilder::open_memory()

mithril-aggregator/src/database/test_helper.rs

@@ -459,7 +459,7 @@ pub fn insert_stake_pool(
     Ok(())
 }
 
-/// A simple struct that help to initialize database with the old adapter behavior for testing purposes.
+/// A simple struct that helps initialize a database with the old adapter behavior for testing purposes.
 pub struct FakeStoreAdapter {
     connection: Arc<SqliteConnection>,
     table: &'static str,
@@ -478,7 +478,7 @@ impl FakeStoreAdapter {
         self.connection.execute(sql).unwrap();
     }
 
-    pub fn is_key_hash_exist(&self, key_hash: &str) -> bool {
+    pub fn has_key_hash(&self, key_hash: &str) -> bool {
         let sql = format!(
             "select exists(select 1 from {} where key_hash = ?1) as record_exists",
             self.table

mithril-aggregator/src/dependency_injection/builder.rs

@@ -501,7 +501,7 @@ impl DependenciesBuilder {
         Ok(self.multi_signer.as_ref().cloned().unwrap())
     }
 
-    async fn build_certificate_pending_store(
+    async fn build_certificate_pending_storer(
         &mut self,
     ) -> Result<Arc<dyn CertificatePendingStorer>> {
         Ok(Arc::new(CertificatePendingRepository::new(
@@ -510,11 +510,11 @@ impl DependenciesBuilder {
     }
 
     /// Get a configured [CertificatePendingStorer].
-    pub async fn get_certificate_pending_store(
+    pub async fn get_certificate_pending_storer(
         &mut self,
     ) -> Result<Arc<dyn CertificatePendingStorer>> {
         if self.certificate_pending_store.is_none() {
-            self.certificate_pending_store = Some(self.build_certificate_pending_store().await?);
+            self.certificate_pending_store = Some(self.build_certificate_pending_storer().await?);
         }
 
         Ok(self.certificate_pending_store.as_ref().cloned().unwrap())
@@ -1414,7 +1414,7 @@ impl DependenciesBuilder {
             stake_store: self.get_stake_store().await?,
             snapshot_uploader: self.get_snapshot_uploader().await?,
             multi_signer: self.get_multi_signer().await?,
-            certificate_pending_store: self.get_certificate_pending_store().await?,
+            certificate_pending_store: self.get_certificate_pending_storer().await?,
             certificate_repository: self.get_certificate_repository().await?,
             open_message_repository: self.get_open_message_repository().await?,
             verification_key_store: self.get_verification_key_store().await?,

mithril-aggregator/src/services/epoch_service.rs

@@ -977,7 +977,7 @@ mod tests {
                 ),
             ]);
 
-            let vkey_store = {
+            let verification_key_store = {
                 let mut store = MockVerificationKeyStorer::new();
                 let signers_with_stake = self.signers_with_stake.clone();
                 store
@@ -1022,7 +1022,7 @@ mod tests {
                 },
                 EpochServiceDependencies::new(
                     Arc::new(epoch_settings_storer),
-                    Arc::new(vkey_store),
+                    Arc::new(verification_key_store),
                     Arc::new(chain_observer),
                     Arc::new(era_checker),
                     Arc::new(stake_distribution_service),