Skip to content

Commit f8290dc

Browse files
committed
chore(client-lib): fix reviews comments
- fix symbols rust doc: "Aggregator" -> "aggregator" + some plurals
1 parent 914ddb2 commit f8290dc

File tree

9 files changed

+31
-31
lines changed

9 files changed

+31
-31
lines changed

mithril-client/src/aggregator_client.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//! Mechanisms to exchange data with an Aggregator.
1+
//! Mechanisms to exchange data with an aggregator.
22
//!
33
44
use anyhow::Context;

mithril-client/src/cardano_database_client/api.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ use super::{
3333
proving::InternalArtifactProver,
3434
};
3535

36-
/// HTTP client for CardanoDatabase API from the Aggregator
36+
/// HTTP client for CardanoDatabase API from the aggregator
3737
pub struct CardanoDatabaseClient {
3838
pub(super) artifact_retriever: InternalArtifactRetriever,
3939
#[cfg(feature = "fs")]
@@ -43,21 +43,21 @@ pub struct CardanoDatabaseClient {
4343
pub(super) statistics_sender: InternalStatisticsSender,
4444
}
4545

46-
/// Define the requests against an Aggregator related to Cardano database v2 snapshots.
46+
/// Define the requests against an aggregator related to Cardano database v2 snapshots.
4747
#[cfg_attr(test, mockall::automock)]
4848
#[cfg_attr(target_family = "wasm", async_trait::async_trait(?Send))]
4949
#[cfg_attr(not(target_family = "wasm"), async_trait::async_trait)]
5050
pub trait CardanoDatabaseAggregatorRequest: Send + Sync {
51-
/// Get the list of the latest Cardano database v2 snapshots from the Aggregator.
51+
/// Get the list of the latest Cardano database v2 snapshots from the aggregator.
5252
async fn list_latest(&self) -> MithrilResult<Vec<CardanoDatabaseSnapshotListItem>>;
5353

54-
/// Get the list of the latest Cardano database v2 snapshots for an [EpochSpecifier] from the Aggregator.
54+
/// Get the list of the latest Cardano database v2 snapshots for an [EpochSpecifier] from the aggregator.
5555
async fn list_by_epoch(
5656
&self,
5757
specifier: EpochSpecifier,
5858
) -> MithrilResult<Vec<CardanoDatabaseSnapshotListItem>>;
5959

60-
/// Get the details of a Cardano database v2 snapshot for a given hash from the Aggregator.
60+
/// Get the details of a Cardano database v2 snapshot for a given hash from the aggregator.
6161
async fn get_by_hash(&self, hash: &str) -> MithrilResult<Option<CardanoDatabaseSnapshot>>;
6262

6363
/// Notify the aggregator that a complete Cardano database v2 restoration has been performed.

mithril-client/src/cardano_database_client/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//! A client to retrieve Cardano databases data from an Aggregator.
1+
//! A client to retrieve Cardano databases data from an aggregator.
22
//!
33
//! In order to do so it defines a [CardanoDatabaseClient] which exposes the following features:
44
//! - [get][CardanoDatabaseClient::get]: get a Cardano database data from its hash

mithril-client/src/cardano_stake_distribution_client.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//! A client to retrieve Cardano stake distributions data from an Aggregator.
1+
//! A client to retrieve Cardano stake distributions data from an aggregator.
22
//!
33
//! In order to do so it defines a [CardanoStakeDistributionClient] which exposes the following features:
44
//! - [get][CardanoStakeDistributionClient::get]: get a Cardano stake distribution data from its hash
@@ -77,23 +77,23 @@ use std::sync::Arc;
7777
use crate::common::{Epoch, EpochSpecifier};
7878
use crate::{CardanoStakeDistribution, CardanoStakeDistributionListItem, MithrilResult};
7979

80-
/// HTTP client for CardanoStakeDistribution API from the Aggregator
80+
/// HTTP client for CardanoStakeDistribution API from the aggregator
8181
pub struct CardanoStakeDistributionClient {
8282
aggregator_requester: Arc<dyn CardanoStakeDistributionAggregatorRequest>,
8383
}
8484

85-
/// Define the requests against an Aggregator related to Cardano stake distribution.
85+
/// Define the requests against an aggregator related to Cardano stake distribution.
8686
#[cfg_attr(test, mockall::automock)]
8787
#[cfg_attr(target_family = "wasm", async_trait::async_trait(?Send))]
8888
#[cfg_attr(not(target_family = "wasm"), async_trait::async_trait)]
8989
pub trait CardanoStakeDistributionAggregatorRequest: Send + Sync {
90-
/// Get the list of latest Cardano stake distributions from the Aggregator.
90+
/// Get the list of the latest Cardano stake distributions from the aggregator.
9191
async fn list_latest(&self) -> MithrilResult<Vec<CardanoStakeDistributionListItem>>;
9292

93-
/// Get a Cardano stake distribution for a given hash from the Aggregator.
93+
/// Get a Cardano stake distribution for a given hash from the aggregator.
9494
async fn get_by_hash(&self, hash: &str) -> MithrilResult<Option<CardanoStakeDistribution>>;
9595

96-
/// Get a Cardano stake distribution for an [EpochSpecifier] from the Aggregator.
96+
/// Get a Cardano stake distribution for an [EpochSpecifier] from the aggregator.
9797
async fn get_by_epoch(
9898
&self,
9999
specifier: EpochSpecifier,

mithril-client/src/cardano_transaction_client.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,27 +82,27 @@ use crate::{
8282
MithrilResult,
8383
};
8484

85-
/// HTTP client for CardanoTransactionsAPI from the Aggregator
85+
/// HTTP client for CardanoTransactionsAPI from the aggregator
8686
pub struct CardanoTransactionClient {
8787
aggregator_requester: Arc<dyn CardanoTransactionAggregatorRequest>,
8888
}
8989

90-
/// Define the requests against an Aggregator related to Cardano transactions.
90+
/// Define the requests against an aggregator related to Cardano transactions.
9191
#[cfg_attr(test, mockall::automock)]
9292
#[cfg_attr(target_family = "wasm", async_trait::async_trait(?Send))]
9393
#[cfg_attr(not(target_family = "wasm"), async_trait::async_trait)]
9494
pub trait CardanoTransactionAggregatorRequest: Send + Sync {
95-
/// Get a proof of membership for the given transactions hashes from the Aggregator.
95+
/// Get a proof of membership for the given transactions hashes from the aggregator.
9696
async fn get_proof(
9797
&self,
9898
hashes: &[String],
9999
) -> MithrilResult<Option<CardanoTransactionsProofs>>;
100100

101-
/// Fetch the list of latest signed Cardano transaction snapshots from the Aggregator
101+
/// Fetch the list of latest signed Cardano transactions snapshots from the aggregator
102102
async fn list_latest_snapshots(&self)
103103
-> MithrilResult<Vec<CardanoTransactionSnapshotListItem>>;
104104

105-
/// Fetch a Cardano transaction snapshot by its hash from the Aggregator.
105+
/// Fetch a Cardano transactions snapshot by its hash from the aggregator.
106106
async fn get_snapshot(&self, hash: &str) -> MithrilResult<Option<CardanoTransactionSnapshot>>;
107107
}
108108

mithril-client/src/certificate_client/api.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@ pub struct CertificateClient {
1414
pub(super) verifier: Arc<dyn CertificateVerifier>,
1515
}
1616

17-
/// Define the requests against an Aggregator related to Mithril certificate.
17+
/// Define the requests against an aggregator related to Mithril certificate.
1818
#[cfg_attr(test, mockall::automock)]
1919
#[cfg_attr(target_family = "wasm", async_trait::async_trait(?Send))]
2020
#[cfg_attr(not(target_family = "wasm"), async_trait::async_trait)]
2121
pub trait CertificateAggregatorRequest: Send + Sync {
22-
/// Get the list of latest Mithril Certificates from the Aggregator.
22+
/// Get the list of latest Mithril Certificates from the aggregator.
2323
async fn list_latest(&self) -> MithrilResult<Vec<MithrilCertificateListItem>>;
2424

25-
/// Get a Mithril Certificate for a given hash from the Aggregator.
25+
/// Get a Mithril Certificate for a given hash from the aggregator.
2626
async fn get_by_hash(&self, hash: &str) -> MithrilResult<Option<MithrilCertificate>>;
2727
}
2828

mithril-client/src/certificate_client/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//! A client which retrieves and validates certificates from an Aggregator.
1+
//! A client which retrieves and validates certificates from an aggregator.
22
//!
33
//! In order to do so it defines a [CertificateClient] exposes the following features:
44
//! - [get][CertificateClient::get]: get a certificate data from its hash

mithril-client/src/mithril_stake_distribution_client.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//! A client to retrieve Mithril stake distributions data from an Aggregator.
1+
//! A client to retrieve Mithril stake distributions data from an aggregator.
22
//!
33
//! In order to do so it defines a [MithrilStakeDistributionClient] which exposes the following features:
44
//! - [get][MithrilStakeDistributionClient::get]: get a Mithril stake distribution data from its hash
@@ -42,20 +42,20 @@ use std::sync::Arc;
4242

4343
use crate::{MithrilResult, MithrilStakeDistribution, MithrilStakeDistributionListItem};
4444

45-
/// HTTP client for MithrilStakeDistribution API from the Aggregator
45+
/// HTTP client for MithrilStakeDistribution API from the aggregator
4646
pub struct MithrilStakeDistributionClient {
4747
aggregator_requester: Arc<dyn MithrilStakeDistributionAggregatorRequest>,
4848
}
4949

50-
/// Define the requests against an Aggregator related to Mithril stake distribution.
50+
/// Define the requests against an aggregator related to Mithril stake distribution.
5151
#[cfg_attr(test, mockall::automock)]
5252
#[cfg_attr(target_family = "wasm", async_trait::async_trait(?Send))]
5353
#[cfg_attr(not(target_family = "wasm"), async_trait::async_trait)]
5454
pub trait MithrilStakeDistributionAggregatorRequest: Send + Sync {
55-
/// Get the list of latest Mithril stake distributions from the Aggregator.
55+
/// Get the list of latest Mithril stake distributions from the aggregator.
5656
async fn list_latest(&self) -> MithrilResult<Vec<MithrilStakeDistributionListItem>>;
5757

58-
/// Get a Mithril stake distribution for a given hash from the Aggregator.
58+
/// Get a Mithril stake distribution for a given hash from the aggregator.
5959
async fn get_by_hash(&self, hash: &str) -> MithrilResult<Option<MithrilStakeDistribution>>;
6060
}
6161

mithril-client/src/snapshot_client.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//! A client to retrieve snapshots data from an Aggregator.
1+
//! A client to retrieve snapshots data from an aggregator.
22
//!
33
//! In order to do so it defines a [SnapshotClient] which exposes the following features:
44
//! - [get][SnapshotClient::get]: get a single snapshot data from its digest
@@ -160,15 +160,15 @@ pub struct SnapshotClient {
160160
logger: Logger,
161161
}
162162

163-
/// Define the requests against an Aggregator related to Cardano database v1 snapshots.
163+
/// Define the requests against an aggregator related to Cardano database v1 snapshots.
164164
#[cfg_attr(test, mockall::automock)]
165165
#[cfg_attr(target_family = "wasm", async_trait::async_trait(?Send))]
166166
#[cfg_attr(not(target_family = "wasm"), async_trait::async_trait)]
167167
pub trait SnapshotAggregatorRequest: Send + Sync {
168-
/// Get the list of the latest Cardano database v1 snapshots from the Aggregator.
168+
/// Get the list of the latest Cardano database v1 snapshots from the aggregator.
169169
async fn list_latest(&self) -> MithrilResult<Vec<SnapshotListItem>>;
170170

171-
/// Get the details of a Cardano database v1 snapshot for a given hash from the Aggregator.
171+
/// Get the details of a Cardano database v1 snapshot for a given hash from the aggregator.
172172
async fn get_by_hash(&self, hash: &str) -> MithrilResult<Option<Snapshot>>;
173173

174174
/// Notify the aggregator that a Cardano database v1 snapshot has been downloaded.

0 commit comments

Comments
 (0)