feat: implement fake DMQ node #2635
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Test Results 1 files - 3 26 suites - 132 4m 6s ⏱️ - 19m 37s For more details on these failures, see this check. Results for commit 900fb4e. ± Comparison against base commit 8cb3c05. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull Request Overview
Adds support for a Decentralized Message Queue (DMQ) node across end-to-end tests, relay components, signers, aggregators, and the mithril-dmq crate.
- Introduce
DMQ_NODE_SOCKET_PATHenv var and socket setup in end-to-end signer and aggregator. - Extend relay components and CLI commands to accept DMQ socket path and Cardano network settings.
- Refactor
mithril-dmqcrate to split client/server interfaces and enablefuture_dmqby default.
Reviewed Changes
Copilot reviewed 42 out of 43 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| mithril-test-lab/.../src/mithril/signer.rs | Insert DMQ_NODE_SOCKET_PATH setup in Signer |
| mithril-test-lab/.../src/mithril/relay_signer.rs | Add DMQ socket and network env in RelaySigner |
| mithril-test-lab/.../src/mithril/relay_aggregator.rs | Add DMQ socket and network env in RelayAggregator |
| mithril-test-lab/.../src/mithril/aggregator.rs | Insert DMQ socket env in end-to-end Aggregator |
| mithril-relay/src/relay/signer.rs | Wire up DMQ publisher server in SignerRelay |
| mithril-relay/src/relay/aggregator.rs | Wire up DMQ consumer server in AggregatorRelay |
| internal/mithril-dmq/src/publisher/client/pallas.rs | Rename to client interface and update implementations |
Comments suppressed due to low confidence (1)
mithril-test-lab/mithril-end-to-end/src/mithril/signer.rs:99
- [nitpick] End-to-end tests don’t currently cover the DMQ_NODE_SOCKET_PATH setup. Add tests that exercise DMQ-based workflows to verify this new configuration is applied correctly.
// TODO: make this configurable
jpraynaud
force-pushed
the
jpraynaud/2627-fake-dmq-node-in-relay
branch
from
730ee75 to
3761142
Compare
jpraynaud
force-pushed
the
jpraynaud/2627-fake-dmq-node-in-relay
branch
2 times, most recently
from
14815a4 to
ac101c4
Compare
jpraynaud
force-pushed
the
jpraynaud/2627-fake-dmq-node-in-relay
branch
from
ac101c4 to
054bcb5
Compare
jpraynaud
had a problem deploying
to
testing-preview
GitHub Actions
Failure
jpraynaud
force-pushed
the
jpraynaud/2627-fake-dmq-node-in-relay
branch
from
b603cb0 to
59f3dc6
Compare
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
dev-follower-preview
GitHub Actions
Inactive
jpraynaud
force-pushed
the
jpraynaud/2627-fake-dmq-node-in-relay
branch
from
59f3dc6 to
57452a5
Compare
| let bytes = | ||
| bincode::serde::encode_to_vec(self, bincode::config::standard()).map_err(|e| e.into()); |
Check warning
Code scanning / clippy
returning the result of a let binding from a block Warning
| let bytes = | ||
| bincode::serde::encode_to_vec(self, bincode::config::standard()).map_err(|e| e.into()); |
Check warning
Code scanning / clippy
returning the result of a let binding from a block Warning
| let bytes = | ||
| bincode::serde::encode_to_vec(self, bincode::config::standard()).map_err(|e| e.into()); | ||
|
|
||
| bytes |
Check warning
Code scanning / clippy
returning the result of a let binding from a block Warning
| let bytes = | ||
| bincode::serde::encode_to_vec(self, bincode::config::standard()).map_err(|e| e.into()); | ||
|
|
||
| bytes |
Check warning
Code scanning / clippy
returning the result of a let binding from a block Warning
'mithril_common::test_utils' has been renamed to 'mithril_common::test'.
jpraynaud
force-pushed
the
jpraynaud/2627-fake-dmq-node-in-relay
branch
from
57452a5 to
900fb4e
Compare
| use anyhow::{Context, anyhow}; | ||
| use pallas_network::{ | ||
| facades::DmqServer, | ||
| miniprotocols::localmsgnotification::{Request, State}, |
Check warning
Code scanning / clippy
unused import: State Warning
| logger: Logger, | ||
| } | ||
|
|
||
| impl DmqConsumerServerPallas { |
Check warning
Code scanning / clippy
method drop_server is never used Warning
| } | ||
|
|
||
| /// Drops the current `DmqServer`, if it exists. | ||
| async fn drop_server(&self) -> StdResult<()> { |
Check warning
Code scanning / clippy
method drop_server is never used Warning
| use anyhow::{Context, anyhow}; | ||
| use pallas_network::{ | ||
| facades::DmqServer, | ||
| miniprotocols::localmsgnotification::{Request, State}, |
Check warning
Code scanning / clippy
unused import: State Warning
| logger: Logger, | ||
| } | ||
|
|
||
| impl DmqConsumerServerPallas { |
Check warning
Code scanning / clippy
method drop_server is never used Warning
| } | ||
|
|
||
| /// Drops the current `DmqServer`, if it exists. | ||
| async fn drop_server(&self) -> StdResult<()> { |
Check warning
Code scanning / clippy
method drop_server is never used Warning
| } | ||
| }, | ||
| None => { | ||
| return Err(anyhow!("DMQ message receiver is not registered")); |
Check warning
Code scanning / clippy
unneeded return statement Warning
| } | ||
| }, | ||
| None => { | ||
| return Err(anyhow!("DMQ message receiver is not registered")); |
Check warning
Code scanning / clippy
unneeded return statement Warning
Content
Note
This is a work in progress
This PR includes...
Pre-submit checklist
Issue(s)
Closes #2627