WIP Linear Leios

Author: nfrisby

leios-trace-hs/src/LeiosConfig.hs

@@ -85,7 +85,7 @@ instance Default CleanupPolicies where
 allCleanupPolicies :: CleanupPolicies
 allCleanupPolicies = CleanupPolicies $ Set.fromList [minBound .. maxBound]
 
-data LeiosVariant = Short | Full
+data LeiosVariant = Short | Full | Linear
   deriving (Show, Eq, Generic)
 
 data Config = Config
@@ -97,6 +97,8 @@ data Config = Config
   , simulateTransactions :: Bool
   , leiosStageLengthSlots :: Word
   , leiosStageActiveVotingSlots :: Word
+  , linearVoteStageLengthSlots :: Word
+  , linearDiffuseStageLengthSlots :: Word
   , leiosVoteSendRecvStages :: Bool
   , leiosVariant :: LeiosVariant
   , leiosLateIbInclusion :: Bool
@@ -141,6 +143,7 @@ data Config = Config
   , voteGenerationProbability :: Double
   , voteGenerationCpuTimeMsConstant :: DurationMs
   , voteGenerationCpuTimeMsPerIb :: DurationMs
+  , voteGenerationCpuTimeMsPerTx :: DurationMs
   , voteValidationCpuTimeMs :: DurationMs
   , voteThreshold :: Word
   , voteBundleSizeBytesConstant :: SizeBytes
@@ -170,6 +173,8 @@ instance Default Config where
       , simulateTransactions = True
       , leiosStageLengthSlots = 20
       , leiosStageActiveVotingSlots = 1
+      , linearVoteStageLengthSlots = 5
+      , linearDiffuseStageLengthSlots = 5
       , leiosVoteSendRecvStages = False
       , leiosVariant = Short
       , leiosLateIbInclusion = True
@@ -214,6 +219,7 @@ instance Default Config where
       , voteGenerationProbability = 500.0
       , voteGenerationCpuTimeMsConstant = 0.164
       , voteGenerationCpuTimeMsPerIb = 0.0
+      , voteGenerationCpuTimeMsPerTx = 0.0
       , voteValidationCpuTimeMs = 0.816
       , voteThreshold = 300
       , voteBundleSizeBytesConstant = 0
@@ -291,6 +297,7 @@ configToKVsWith getter cfg =
     , get @"voteGenerationProbability" getter cfg
     , get @"voteGenerationCpuTimeMsConstant" getter cfg
     , get @"voteGenerationCpuTimeMsPerIb" getter cfg
+    , get @"voteGenerationCpuTimeMsPerTx" getter cfg
     , get @"voteValidationCpuTimeMs" getter cfg
     , get @"voteThreshold" getter cfg
     , get @"voteBundleSizeBytesConstant" getter cfg
@@ -339,6 +346,8 @@ instance FromJSON Config where
     leiosStageLengthSlots <- parseFieldOrDefault @Config @"leiosStageLengthSlots" obj
     leiosStageActiveVotingSlots <- parseFieldOrDefault @Config @"leiosStageActiveVotingSlots" obj
     leiosVoteSendRecvStages <- parseFieldOrDefault @Config @"leiosVoteSendRecvStages" obj
+    linearVoteStageLengthSlots <- parseFieldOrDefault @Config @"linearVoteStageLengthSlots" obj
+    linearDiffuseStageLengthSlots <- parseFieldOrDefault @Config @"linearDiffuseStageLengthSlots" obj
     txGenerationDistribution <- parseFieldOrDefault @Config @"txGenerationDistribution" obj
     txSizeBytesDistribution <- parseFieldOrDefault @Config @"txSizeBytesDistribution" obj
     txValidationCpuTimeMs <- parseFieldOrDefault @Config @"txValidationCpuTimeMs" obj
@@ -378,6 +387,7 @@ instance FromJSON Config where
     voteGenerationProbability <- parseFieldOrDefault @Config @"voteGenerationProbability" obj
     voteGenerationCpuTimeMsConstant <- parseFieldOrDefault @Config @"voteGenerationCpuTimeMsConstant" obj
     voteGenerationCpuTimeMsPerIb <- parseFieldOrDefault @Config @"voteGenerationCpuTimeMsPerIb" obj
+    voteGenerationCpuTimeMsPerTx <- parseFieldOrDefault @Config @"voteGenerationCpuTimeMsPerTx" obj
     voteValidationCpuTimeMs <- parseFieldOrDefault @Config @"voteValidationCpuTimeMs" obj
     voteThreshold <- parseFieldOrDefault @Config @"voteThreshold" obj
     voteBundleSizeBytesConstant <- parseFieldOrDefault @Config @"voteBundleSizeBytesConstant" obj

simulation/docs/SimulatorModel.md

@@ -347,3 +347,76 @@ These variables maintain tasks blocked on some missing input.
 - `taskQueue`.
   A queue of tasks scheduled for the CPU, labeled according to what they model (eg "validate an RB").
   Tasks are only removed when they are executed.
+
+# Alternative Design: Linear Leios
+
+## Motivation
+
+In Linear Leios, every time any party issues an RB, they also issue an EB.
+In effect, the RB now consists of three parts: a header, a first body (the standard RB body), and a second body (the EB) that extends the first.
+The EB includes txs (either by value or by reference)---there are no IBs.
+When a (child) RB extends some (parent) RB, it will sometimes include a certificate that demonstrates a quorum of stake has already validated the parent RB's second body.
+If the child RB includes that certificate, then its first body extends the parent's second body.
+If the child RB excludes that certificate, then its first body instead extends the parent's first body---the parent's second body is irrevocably lost (except maybe on other chains extending that same parent RB).
+
+This variant is _linear_ because the txs that end up on some chain are never unordered: they are ordered in the mempools and they are ordered in the roughly-alternating chain of RBs and EBs.
+This is in crucial contrast to Short Leios and its extensions: there, txs included (directly or indirectly) via EBs are concurrent until an RB serializes them (at the latest possible moment).
+As a result, this variant is immediately compatible with today's ledger interface, as is---possibly other than reward calculations etc.
+
+## A Terse Interpretation of the Linear Leois Specification
+
+- A node should fetch EBs according to a FreshestFirst policy.
+- A node should validate an EB as soon as possible while both of the following are true.
+    - It has validated the EB's parent RB.
+      The node cannot validate the EB before validating its parent RB.
+    - The EB's parent RB is the tip of the best RB header chain it has validated, excluding RB header's whose body turned out to be invalid.
+      Any RB that extends the EB's parent RB either excludes the EB or else certifies its validity---in either case, the node no longer needs to validate the EB.
+      Note that this conjunct is non-monotonic, due to a relevant RB header being later disqualified when its RB body is recognized as invalid.
+      TODO for now, it's merely what the chain has selected, regardless of any better headers.
+- A node should vote for an EB as soon as possible within the following interval.
+    - The interval ends `L_vote` slots after the onset of the EB's slot (aka `linear-vote-stage-length-slots`).
+    - The interval begins either when the node validates the EB or three \Delta_hdr of the onset of the EB's slot, whichever happens last (ie combined the two times via `max`).
+      A node must not vote for an EB if it receives evidence of the issuer's equivocation within three \Delta_hdr of the EB's slot onset.
+- A node should include an EB certificate, if any, in a new RB that extends the EB's parent if the new RB is at least `L_vote + L_diff` slots younger than the EB's parent (aka `linear-vote-stage-length-slots + linear-diffuse-stage-length-slots`).
+  It is important to clarify that an RB remains valid if it excludes the certificate even when those constraints are satisfied.
+- A node should diffuse an EB even before it knows whether it's invalid (ie it should enable "EB diffusion pipelining").
+  TODO would it even be worth going one step further: _streaming_ the EB, ie diffusing its prefix before its suffix has been received (and therefore before the EB could have been parsed)?
+- A node should diffuse RB headers (at most two per election proof) even if it they're not on the best header chain, since such a header might still evidence equivocation.
+  We anticipate this happening separately (and redundantly) of ChainSync and BlockFetch.
+  TODO it can also abort validation of the EB, right?
+  TODO should it exclude the certificate of an equivocated EB if it issues the next RB?
+
+A node should acquire EBs from election opportunities even if they're on competing forks.
+That way, if the node switches chains, it will already have the necessary EBs.
+It won't have validated them, but that's fine, since it will only need to apply them when a certificate forces them to, so they can skip the validation checks.
+
+In order for the node to receive EBs for RB chains it doesn't necessarily have the RB headers for, RB headers will also be propogated via Relay in addition to and completely independently from their diffusion via ChainSync and BlockFetch.
+This is because the RB header announces not just the RB body but also the EB (via the new `EBannounced` field in the RB header from the Linear Leios spec).
+
+## Implementation Notes
+
+The Linear Leios specification indicates that an RB header names the EB that occurs on the chain before the RB, if any, the EB that occurs after the RB, if any, and an EB names the RB that it follows.
+However, in the absence of an attacker, the simulator can simply use the existing data types for Linear Leios even though the RB header type excludes those two fields.
+
+- The simulator does not currently have extensible data types for Praos headers, so it would not be trivial to add these header fields.
+- In the absence of an attacker within the simulation, the new RB header fields aren't _necessary_.
+- Despite being unnecessary, having the RB header announce its second body EB would plausibly decrease the average latency of the EBs.
+  But that decrease should be _very_ minor; with the current overly-coarse multiplexer logic (see [Issue 453](https://github.com/input-output-hk/ouroboros-leios/issues/453)), the EB's `RelayHeader` will arrive immediately after the ChainSync header (which are small), except perhaps during severe congestion.
+
+The Linear Leios simulator adds the following new variables, some of which also require some new threads.
+
+- `relayLinearEBState`.
+  As a shortcut, the first Linear Leios simulator will instantiate `Relay` with `RelayHeader InputBlockId` and `InputBlock`.
+  This is because the IB specified in Short Leios has just a few small fields more than the EB specified in Linear Leios.
+- `waitingForLedgerStateAndLinearEbVar` and `ledgerStateAndLinearEbVar`.
+  An RB that contains an EB cert can be adopted before that EB has been validated.
+  TODO but it still needs to be applied, which is much cheaper but not free
+- `waitingForTipVar`.
+  The Linear EB should be validated the first time its arrived and its parent RB is the tip of the node's selection.
+- `linearEbsToVoteVar`.
+  Once a Linear EB has been validated, it should be voted for.
+  A new custom thread monitors this variable in addition to the clock, so that it can avoid issugin a vote too early or too late.
+
+TODO block diffusion pipelining for both RBs and EBs
+
+TODO RBs are so far only distributed by ChainSync and BlockFetch

simulation/src/LeiosProtocol/Common.hs

@@ -147,6 +147,9 @@ inputBlockInvariant ib = ib.header.id == ib.body.id
 instance HasField "id" InputBlock InputBlockId where
   getField = (.id) . (.header)
 
+instance HasField "slot" InputBlock SlotNo where
+  getField = (.slot) . (.header)
+
 data EndorseBlockId = EndorseBlockId
   { node :: !NodeId
   , num :: !Int

simulation/src/LeiosProtocol/Short.hs

@@ -63,6 +63,7 @@ data LeiosDelays = LeiosDelays
   , endorseBlockGeneration :: !(EndorseBlock -> DiffTime)
   , endorseBlockValidation :: !(EndorseBlock -> DiffTime)
   , voteMsgGeneration :: !(VoteMsg -> [EndorseBlock] -> DiffTime)
+  , linearVoteMsgGeneration :: !(VoteMsg -> [InputBlock] -> DiffTime)
   , voteMsgValidation :: !(VoteMsg -> DiffTime)
   , certificateGeneration :: !(Certificate -> DiffTime)
   , certificateValidation :: !(Certificate -> DiffTime)
@@ -122,6 +123,8 @@ data LeiosConfig = forall p. IsPipeline p => LeiosConfig
   , votesForCertificate :: Int
   , sizes :: SizesConfig
   , delays :: LeiosDelays
+  , linearVoteStageLengthSlots :: Int
+  , linearDiffuseStageLengthSlots :: Int
   , ibDiffusion :: RelayDiffusionConfig
   , ebDiffusion :: RelayDiffusionConfig
   , voteDiffusion :: RelayDiffusionConfig
@@ -153,11 +156,13 @@ convertConfig disk =
           , headerDiffusionTime = realToFrac $ durationMsToDiffTime disk.leiosHeaderDiffusionTimeMs
           , lateIbInclusion = disk.leiosLateIbInclusion
           , pipelinesToReferenceFromEB =
-              if disk.leiosVariant == Full
-                then
-                  ceiling ((3 * disk.praosChainQuality) / fromIntegral sliceLength) - 2
-                else 0
+              case disk.leiosVariant of
+                Full -> ceiling ((3 * disk.praosChainQuality) / fromIntegral sliceLength) - 2
+                Short -> 0
+                Linear -> 0
           , activeVotingStageLength = fromIntegral disk.leiosStageActiveVotingSlots
+          , linearVoteStageLengthSlots = fromIntegral disk.linearVoteStageLengthSlots
+          , linearDiffuseStageLengthSlots = fromIntegral disk.linearDiffuseStageLengthSlots
           , votingFrequencyPerStage = disk.voteGenerationProbability
           , votesForCertificate = fromIntegral disk.voteThreshold
           , sizes
@@ -267,13 +272,25 @@ convertConfig disk =
                   + disk.voteGenerationCpuTimeMsPerIb `forEach` eb.inputBlocks
                 | eb <- ebs
                 ]
+      , linearVoteMsgGeneration = \vm ibs ->
+          assert (1 == length vm.endorseBlocks) $
+            assert (vm.endorseBlocks == map (convertLinearId . (.id)) ibs) $
+              assert (0 == disk.voteGenerationCpuTimeMsPerTx) $   -- TODO
+                durationMsToDiffTime $
+                  disk.voteGenerationCpuTimeMsConstant `forEach` ibs
       , voteMsgValidation = \vm ->
           durationMsToDiffTime $
             disk.voteValidationCpuTimeMs `forEach` vm.endorseBlocks
       , certificateGeneration = const $ error "certificateGeneration delay included in RB generation"
       , certificateValidation = const $ error "certificateValidation delay included in RB validation"
       }
 
+convertLinearId :: InputBlockId -> EndorseBlockId
+convertLinearId (InputBlockId x y) = EndorseBlockId x y
+
+unconvertLinearId :: EndorseBlockId -> InputBlockId
+unconvertLinearId (EndorseBlockId x y) = InputBlockId x y
+
 delaysAndSizesAsFull :: LeiosConfig -> LeiosConfig
 delaysAndSizesAsFull cfg@LeiosConfig{pipeline, voteSendStage} =
   -- Fields spelled out to more likely trigger an error and review when type changes.
@@ -293,6 +310,8 @@ delaysAndSizesAsFull cfg@LeiosConfig{pipeline, voteSendStage} =
     , lateIbInclusion = cfg.lateIbInclusion
     , pipelinesToReferenceFromEB = cfg.pipelinesToReferenceFromEB
     , activeVotingStageLength = cfg.activeVotingStageLength
+    , linearVoteStageLengthSlots = cfg.linearVoteStageLengthSlots
+    , linearDiffuseStageLengthSlots = cfg.linearDiffuseStageLengthSlots
     , votingFrequencyPerStage = cfg.votingFrequencyPerStage
     , voteSendStage = voteSendStage
     , votesForCertificate = cfg.votesForCertificate
@@ -310,6 +329,15 @@ delaysAndSizesAsFull cfg@LeiosConfig{pipeline, voteSendStage} =
     | id' <- fullVT.endorseBlocks
     , let EndorseBlock{..} = fullEB
     ]
+  fullLinearEBsVotedFor =
+    [ InputBlock {
+        body = fullIB.body
+        , header =
+          let InputBlockHeader{..} = fullIB.header
+          in InputBlockHeader {id = unconvertLinearId id', ..}
+        }
+    | id' <- fullVT.endorseBlocks
+    ]
   fullRB = mockFullRankingBlock cfg
   fullCert = mockFullCertificate cfg
   praos =
@@ -347,6 +375,12 @@ delaysAndSizesAsFull cfg@LeiosConfig{pipeline, voteSendStage} =
               cfg.delays.voteMsgGeneration
                 fullVT
                 fullEBsVotedFor
+      , linearVoteMsgGeneration =
+          const $
+            const @DiffTime $
+              cfg.delays.linearVoteMsgGeneration
+                fullVT
+                fullLinearEBsVotedFor
       , voteMsgValidation = const @DiffTime $ cfg.delays.voteMsgValidation fullVT
       , certificateGeneration = const @DiffTime $ cfg.delays.certificateGeneration fullCert
       , certificateValidation = const @DiffTime $ cfg.delays.certificateValidation fullCert
@@ -661,7 +695,8 @@ mockFullCertificate cfg = mockCertificate cfg cfg.votesForCertificate
 -- Buffers views, divided to avoid reading unneeded buffers.
 
 data NewRankingBlockData = NewRankingBlockData
-  { certifiedEBforRBAt :: SlotNo -> Maybe (EndorseBlockId, Certificate)
+  { prevChain :: Chain RankingBlock
+  , mbEbCert :: Maybe (EndorseBlockId, Certificate)
   , txsPayload :: Bytes
   }
 
@@ -758,13 +793,14 @@ endorseBlocksToReference ::
   EndorseBlocksSnapshot ->
   (PipelineNo -> UTCTime -> Bool) ->
   [(PipelineNo, [EndorseBlock])]
-endorseBlocksToReference LeiosConfig{variant = Short} _ _ _ = []
-endorseBlocksToReference cfg@LeiosConfig{variant = Full} pl EndorseBlocksSnapshot{..} checkDeliveryTime =
-  assert
-    ( all (\(p, ebs) -> all (\eb -> p == endorseBlockPipeline cfg eb) ebs && succ (succ p) <= pl) result
-        && (\ps -> sort ps == ps) (map fst result)
-    )
-    result
+endorseBlocksToReference cfg pl EndorseBlocksSnapshot{..} checkDeliveryTime
+  | Full <- cfg.variant =
+      assert
+        ( all (\(p, ebs) -> all (\eb -> p == endorseBlockPipeline cfg eb) ebs && succ (succ p) <= pl) result
+            && (\ps -> sort ps == ps) (map fst result)
+        )
+        result
+  | otherwise = []
  where
   result =
     [ (p, [eb | (eb, _, _) <- es])

simulation/src/LeiosProtocol/Short/DataSimP2P.hs

@@ -153,6 +153,11 @@ accumLeiosSimState _cfg now (LeiosEventNode (LabelNode nid (LeiosNodeEvent event
         { ebDiffusionLatency = accumDiffusionLatency' now nid event x.id x ebDiffusionLatency
         , ..
         }
+    EventLinearEB x ->
+      LeiosSimState
+        { ibDiffusionLatency = accumDiffusionLatency' now nid event x.id x.header ibDiffusionLatency
+        , ..
+        }
     EventVote x ->
       LeiosSimState
         { voteDiffusionLatency = accumDiffusionLatency' now nid event x.id x voteDiffusionLatency