Skip to content

Commit 7820a66

Browse files
authored
Fixed data file location bugs in cabal files (#395)
* Switched to system temporary directory, for nix compatibility * Added missing data files to ouroboros-leios-sim.cabal * Updated logbook Fixes #368
1 parent 4370fd8 commit 7820a66

File tree

4 files changed

+11
-6
lines changed

4 files changed

+11
-6
lines changed

Logbook.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Leios logbook
22

3+
## 2025-06-09
4+
5+
### Fixes to CI
6+
7+
Outstanding bugs in the CI, [#368](https://github.com/input-output-hk/ouroboros-leios/issues/368) and [#379](https://github.com/input-output-hk/ouroboros-leios/issues/379), have been fixes, so now all of the CI checks pass!
8+
39
## 2025-06-06
410

511
### Formal methods

nix/project.nix

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,8 @@ let
5353
# modules = [{ packages = { }; } { packages = { }; } ];
5454
});
5555

56-
5756
cabalProject = cabalProject'.appendOverlays [ ];
5857

59-
6058
# Docs for mkHaskellProject: https://github.com/input-output-hk/iogx/blob/main/doc/api.md#mkhaskellproject
6159
project = lib.iogx.mkHaskellProject {
6260
inherit cabalProject;

simulation/ouroboros-leios-sim.cabal

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,10 @@ maintainer: [email protected]
2020
build-type: Simple
2121
extra-source-files: CHANGELOG.md
2222
data-files:
23+
test/data/BenchTopology/topology-dense-52.json
2324
test/data/BenchTopology/topology-dense-52.json
2425
test/data/BenchTopology/latency.sqlite3.gz
26+
test/data/simulation/config.default.yaml
2527

2628
flag perf
2729
description: Ghc options for improved performance, disables asserts.

simulation/src/Topology.hs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,9 @@ import ModelTCP (Bytes, kilobytes)
7070
import P2P (Latency, Link, Link' (..), P2PTopography (..), P2PTopographyCharacteristics (..), genArbitraryP2PTopography, pattern (:<-))
7171
import SimTypes (NodeId (..), NumCores (..), Path (..), Point (..), StakeFraction (StakeFraction), World (..), WorldDimensions)
7272
import System.Exit (exitFailure)
73-
import System.FilePath (dropExtension, takeDirectory, takeExtension, takeExtensions, takeFileName)
73+
import System.FilePath (dropExtension, takeExtension, takeExtensions, takeFileName)
7474
import System.IO (hClose, hPutStrLn, stderr)
75-
import System.IO.Temp (withTempFile)
75+
import System.IO.Temp (withSystemTempFile)
7676
import System.Random (RandomGen)
7777
import Text.Printf (printf)
7878

@@ -563,9 +563,8 @@ readLatencies topology latencyFile =
563563
readLatenciesSqlite3Gz :: BenchTopology -> FilePath -> IO LatenciesMs
564564
readLatenciesSqlite3Gz topology latencySqliteGzFile =
565565
assert (takeExtension latencySqliteGzFile == ".gz") $ do
566-
let latencySqliteDirectory = takeDirectory latencySqliteGzFile
567566
let latencySqliteFileName = takeFileName (dropExtension latencySqliteGzFile)
568-
withTempFile latencySqliteDirectory latencySqliteFileName $ \latencySqliteFile latencySqliteHandle -> do
567+
withSystemTempFile latencySqliteFileName $ \latencySqliteFile latencySqliteHandle -> do
569568
latencySqliteGzContent <- BSL.readFile latencySqliteGzFile
570569
let latencySqliteContent = GZip.decompress latencySqliteGzContent
571570
BSL.hPut latencySqliteHandle latencySqliteContent

0 commit comments

Comments
 (0)