Skip to content

Conversation

@nfrisby
Copy link
Contributor

@nfrisby nfrisby commented Jun 18, 2025

Closes #387.

@nfrisby nfrisby requested review from SupernaviX and yveshauser June 18, 2025 13:48
@nfrisby nfrisby self-assigned this Jun 18, 2025
@nfrisby nfrisby marked this pull request as draft June 18, 2025 13:48
@nfrisby
Copy link
Contributor Author

nfrisby commented Jun 18, 2025

I set this PR to be a Draft PR because EBGenerated is an event in the shared schema. I'm not sure if that needs to be updated as part of this PR, and if so, I think @SupernaviX would need to push a commit adding it to the Rust simulator as well?

@nfrisby
Copy link
Contributor Author

nfrisby commented Jun 18, 2025

@yveshauser do you have any advice about how to fix this CI failure on this PR? Perhaps it'd make sense for you to push an Agda commit to it? https://github.com/input-output-hk/ouroboros-leios/actions/runs/15734666849/job/44344067399?pr=416

@nfrisby nfrisby force-pushed the nfrisby/issue-387-ebs-in-EBGenerated branch from 9979bba to 871ad33 Compare June 18, 2025 14:13
@nfrisby
Copy link
Contributor Author

nfrisby commented Jun 18, 2025

  • I renamed it to endorser_blocks, since I just found the parsing code in the trace-processor code that anticipates a field of that name.
  • I added my best-guess of the necessary change to leios-trace-verifier:Spec.Transition. But that code is not included in the cabal.project file, and I don't know why not.

Copy link
Member

@yveshauser yveshauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@SupernaviX
Copy link
Contributor

I set this PR to be a Draft PR because EBGenerated is an event in the shared schema. I'm not sure if that needs to be updated as part of this PR, and if so, I think @SupernaviX would need to push a commit adding it to the Rust simulator as well?

The rust simulation already includes this endorser_blocks field (I'd assumed the haskell sim had it as well). So it's safe to add to the shared trace schema.

@nfrisby nfrisby force-pushed the nfrisby/issue-387-ebs-in-EBGenerated branch from 3f29f97 to f38c278 Compare June 23, 2025 14:03
@nfrisby
Copy link
Contributor Author

nfrisby commented Jun 23, 2025

I updated the schema files and rebased onto main.

@nfrisby nfrisby marked this pull request as ready for review June 23, 2025 14:03
@nfrisby nfrisby merged commit 37f7c35 into main Jun 23, 2025
11 checks passed
@nfrisby nfrisby deleted the nfrisby/issue-387-ebs-in-EBGenerated branch June 23, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EBGenerated event needs an additional field for EndorserBlocks for Full-Short variant

4 participants