remove: pallet-partner-chains-session (#1025)

Author: AmbientTea

Cargo.lock

@@ -14,7 +14,6 @@ members = [
 	"toolkit/smart-contracts/commands",
 	"substrate-extensions/aura/consensus",
 	"toolkit/block-production-log/pallet",
-	"substrate-extensions/partner-chains-session",
 	"toolkit/committee-selection/pallet",
 	"toolkit/committee-selection/pallet/benchmarking",
 	"toolkit/committee-selection/rpc",
@@ -301,7 +300,6 @@ authority-selection-inherents = { path = "toolkit/committee-selection/authority-
 # substrate extensions
 sc-partner-chains-consensus-aura = { path = "substrate-extensions/aura/consensus", default-features = false }
 sp-partner-chains-consensus-aura = { path = "substrate-extensions/aura/primitives", default-features = false }
-pallet-partner-chains-session = { path = "substrate-extensions/partner-chains-session", default-features = false }
 
 # block production and rewards
 pallet-block-production-log = { path = "toolkit/block-production-log/pallet", default-features = false }

Cargo.toml

@@ -10,6 +10,10 @@ This changelog is based on [Keep A Changelog](https://keepachangelog.com/en/1.1.
 
 ## Removed
 
+* `pallet-partner-chains-session` has been removed. Partner Chains should use only the stock Substrate session pallet
+* `PalletSessionSupport` type provided by `pallet-session-validator-management`. The `SessionManager` and `ShouldEndSession`
+  implementations were moved directly to the `Pallet` type instead.
+
 ## Fixed
 
 ## Added

changelog.md

@@ -61,7 +61,6 @@ pallet-session-validator-management = { workspace = true }
 sp-session-validator-management = { workspace = true }
 sp-session-validator-management-query = { workspace = true }
 pallet-session-validator-management-rpc = { workspace = true }
-pallet-partner-chains-session = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }
 substrate-prometheus-endpoint = { workspace = true }

demo/node/Cargo.toml

@@ -29,9 +29,6 @@ pallet-aura = { workspace = true }
 pallet-balances = { workspace = true }
 frame-support = { workspace = true }
 pallet-grandpa = { workspace = true }
-pallet-partner-chains-session = { workspace = true, features = [
-	"pallet-session-compat",
-] }
 pallet-session = { workspace = true }
 pallet-sudo = { workspace = true }
 frame-system = { workspace = true }
@@ -129,7 +126,6 @@ std = [
 	"pallet-block-production-log/std",
 	"pallet-grandpa/std",
 	"pallet-sudo/std",
-	"pallet-partner-chains-session/std",
 	"pallet-session-validator-management/std",
 	"pallet-session-validator-management-benchmarking?/std",
 	"pallet-timestamp/std",

demo/runtime/Cargo.toml

@@ -27,7 +27,6 @@ use frame_system::EnsureRoot;
 use opaque::SessionKeys;
 use pallet_block_producer_metadata;
 use pallet_grandpa::AuthorityId as GrandpaId;
-use pallet_session_validator_management::pallet_session_support::PalletSessionSupport;
 use pallet_transaction_payment::{ConstFeeMultiplier, FungibleAdapter, Multiplier};
 use parity_scale_codec::{Decode, DecodeWithMemTracking, Encode, MaxEncodedLen};
 use scale_info::TypeInfo;
@@ -309,9 +308,9 @@ impl pallet_session::Config for Runtime {
 	type RuntimeEvent = RuntimeEvent;
 	type ValidatorId = AccountId;
 	type ValidatorIdOf = ConvertInto;
-	type ShouldEndSession = PalletSessionSupport<Runtime>;
+	type ShouldEndSession = SessionCommitteeManagement;
 	type NextSessionRotation = ();
-	type SessionManager = PalletSessionSupport<Runtime>;
+	type SessionManager = SessionCommitteeManagement;
 	type SessionHandler = <SessionKeys as OpaqueKeys>::KeyTypeIdProviders;
 	type Keys = SessionKeys;
 	type DisablingStrategy = pallet_session::disabling::UpToLimitWithReEnablingDisablingStrategy;

demo/runtime/src/lib.rs

@@ -10,7 +10,6 @@ use frame_support::{
 };
 use frame_system::EnsureRoot;
 use hex_literal::hex;
-use pallet_session_validator_management::pallet_session_support::PalletSessionSupport;
 use plutus::ToDatum;
 use sidechain_domain::*;
 use sp_consensus_aura::sr25519::AuthorityId as AuraId;
@@ -143,9 +142,9 @@ impl pallet_session::Config for Test {
 	type RuntimeEvent = RuntimeEvent;
 	type ValidatorId = <Self as frame_system::Config>::AccountId;
 	type ValidatorIdOf = ConvertInto;
-	type ShouldEndSession = PalletSessionSupport<Test>;
+	type ShouldEndSession = SessionCommitteeManagement;
 	type NextSessionRotation = ();
-	type SessionManager = PalletSessionSupport<Test>;
+	type SessionManager = SessionCommitteeManagement;
 	type SessionHandler = <TestSessionKeys as OpaqueKeys>::KeyTypeIdProviders;
 	type Keys = TestSessionKeys;
 	type DisablingStrategy = pallet_session::disabling::UpToLimitWithReEnablingDisablingStrategy;