Skip to content

Commit ea6e0dc

Browse files
committed
feat: combine automatic-generate-keys functionality into original generate keys command
1 parent 1acab37 commit ea6e0dc

File tree

8 files changed

+453
-422
lines changed

8 files changed

+453
-422
lines changed

Cargo.lock

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

changelog.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ This changelog is based on [Keep A Changelog](https://keepachangelog.com/en/1.1.
66

77
## Added
88

9-
* New `automatic-generate-keys` command in `partner-chains-cli`:
10-
* Allows users to generate and save session keys by connecting to a running node via RPC (`author_rotateKeys`).
11-
* Decodes session keys using the runtime API and saves them to the keystore and `partner-chains-public-keys.json`.
9+
* Enhanced `generate-keys` command in `partner-chains-cli`:
10+
* Added `--url` parameter to enable automatic key generation via RPC (`author_rotateKeys`) when connecting to a running node.
11+
* When `--url` is provided, the command automatically generates session keys by calling the node's RPC endpoint, decodes them using the runtime API, and saves them to the keystore and `partner-chains-public-keys.json`.
1212
* Provides fallback and error handling for various runtime formats.
13-
* Fully integrated into the CLI as an alternative to `generate-keys` for all roles (Governance Authority, Registered Validator, Permissioned Validator).
13+
* Maintains backward compatibility - when called without `--url`, it uses the traditional local key generation method.
1414
* Comprehensive test suite for SCALE decoding and key handling logic.
1515
* Help message and workflow documentation updated to show both key generation methods and when to use each.
1616

toolkit/partner-chains-cli/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ sp-governed-map = { workspace = true, features = ["std"] }
4949
sidechain-slots = { workspace = true }
5050
authority-selection-inherents = { workspace = true, features = ["std"] }
5151
reqwest = { workspace = true }
52-
indexmap = { workspace = true }
52+
5353
parity-scale-codec = { workspace = true }
5454

5555
[dev-dependencies]

toolkit/partner-chains-cli/src/automatic_generate_keys/mod.rs

Lines changed: 0 additions & 301 deletions
This file was deleted.

0 commit comments

Comments
 (0)