fix: attempt to multiply with overflow error when running with mock data source and debug build #1096
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata source and debug build
LGLO
reviewed
Nov 21, 2025
| // reverse of computation in `get_latest_stable_block_for` | ||
| let block_number = u32::from_be_bytes(hash.0[..4].try_into().unwrap()); | ||
| let timestamp = block_number * 20000; | ||
| let timestamp = u64::from(block_number) * 20000; |
Contributor
There was a problem hiding this comment.
Could it be reading the last 8 bytes to u64 in the line above?
Contributor
Author
There was a problem hiding this comment.
block_number is used as u32 later in this function
LGLO
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Title should be self explanatory
Checklist
changelog.mdfor affected crate