Reuse IsUnknown

Author: inputfalken

src/DynamoDBGenerator.SourceGenerator/Generations/Marshalling/Marshaller.cs

@@ -209,12 +209,9 @@ internal static string InvokeMarshallerMethod(TypeIdentifier typeIdentifier, str
     {
         var invocation = $"{ClassName}.{GetSerializationMethodName(typeIdentifier.TypeSymbol)}({parameterReference}, {optionParam}, {dataMember})";
 
-        if (options.IsConvertable(typeIdentifier.TypeSymbol))
-            return invocation;
-
-        return typeIdentifier is UnknownType 
-            ? $"{AttributeValueUtilityFactory.ToAttributeValue}({invocation})" 
-            : invocation;
+        return options.IsUnknown(typeIdentifier) is false
+            ? invocation
+            : $"{AttributeValueUtilityFactory.ToAttributeValue}({invocation})";
     }
 
     internal static IEnumerable<string> RootSignature(TypeIdentifier typeIdentifier)

src/DynamoDBGenerator.SourceGenerator/Generations/UnMarshaller.cs

@@ -225,12 +225,11 @@ private static IEnumerable<string> CreateTypeContents(IEnumerable<DynamoDBMarsha
 
     private static string InvokeUnmarshallMethod(TypeIdentifier typeIdentifier, string paramReference, string dataMember, MarshallerOptions options, string marshallerOptionsReference = MarshallerOptions.ParamReference)
     {
-        if (options.IsConvertable(typeIdentifier.TypeSymbol))
+        if (options.IsUnknown(typeIdentifier) is false) 
             return $"{GetDeserializationMethodName(typeIdentifier.TypeSymbol)}({paramReference}, {marshallerOptionsReference}, {dataMember})";
-        
-        return typeIdentifier is UnknownType
-            ? $"{GetDeserializationMethodName(typeIdentifier.TypeSymbol)}({paramReference}?.M, {marshallerOptionsReference}, {dataMember})"
-            : $"{GetDeserializationMethodName(typeIdentifier.TypeSymbol)}({paramReference}, {marshallerOptionsReference}, {dataMember})";
+
+        return
+            $"{GetDeserializationMethodName(typeIdentifier.TypeSymbol)}({paramReference}?.M, {marshallerOptionsReference}, {dataMember})";
 
     }
     private static IEnumerable<string> ObjectAssignmentBlock(bool useParentheses, IEnumerable<string> assignments, bool applySemiColon)

src/DynamoDBGenerator.SourceGenerator/Types/MarshallerOptions.cs

@@ -18,7 +18,7 @@ public readonly struct MarshallerOptions
     public string FieldDeclaration { get; }
 
     public bool IsUnknown(TypeIdentifier typeSymbol) =>
-        typeSymbol is UnknownType && !IsConvertable(typeSymbol.TypeSymbol);
+        typeSymbol is UnknownType && IsConvertable(typeSymbol.TypeSymbol) is false;
 
 
     private MarshallerOptions(