Skip to content

Commit cd71ebb

Browse files
committed
style code issues fixed
1 parent 03a034b commit cd71ebb

File tree

1 file changed

+66
-70
lines changed

1 file changed

+66
-70
lines changed

examples/stm32/f4/stm32f4-discovery/lis3dsh_demo/lis3dsh_demo.c

Lines changed: 66 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,15 @@
4141
/* WHO AM I register default value */
4242
#define UC_WHO_AM_I_DEFAULT_VALUE 0x3F
4343

44-
/* ADD_REG_CTRL_4 register configuration value: X,Y,Z axis enabled and 400Hz of output data rate */
44+
/* ADD_REG_CTRL_4 register configuration value:
45+
* X,Y,Z axis enabled and 400Hz of output data rate */
4546
#define UC_ADD_REG_CTRL_4_CFG_VALUE 0x77
4647

4748
/* Sensitivity for 2G range [mg/digit] */
4849
#define SENS_2G_RANGE_MG_PER_DIGIT ((float)0.06)
4950

5051
/* LED threshold value in mg */
51-
#define LED_TH_MG (1000) /* 1000mg (1G) */
52+
#define LED_TH_MG (1000) /* 1000mg (1G) */
5253

5354

5455

@@ -63,31 +64,31 @@
6364
#define SET_WRITE_SINGLE_CMD(x) (x & (~(0xC0)))
6465
/* set write multiple command. Attention: command must be 0x3F at most */
6566
#define SET_WRITE_MULTI_CMD(x) (x & (~(0x80)) \
66-
x |= 0x40)
67+
x |= 0x40)
6768

6869
/* Macros for turning LEDs ON */
69-
#define LED_GREEN_ON() (gpio_set(GPIOD, GPIO12))
70-
#define LED_ORANGE_ON() (gpio_set(GPIOD, GPIO13))
71-
#define LED_RED_ON() (gpio_set(GPIOD, GPIO14))
72-
#define LED_BLUE_ON() (gpio_set(GPIOD, GPIO15))
70+
#define LED_GREEN_ON() (gpio_set(GPIOD, GPIO12))
71+
#define LED_ORANGE_ON() (gpio_set(GPIOD, GPIO13))
72+
#define LED_RED_ON() (gpio_set(GPIOD, GPIO14))
73+
#define LED_BLUE_ON() (gpio_set(GPIOD, GPIO15))
7374

7475
/* Macros for turning LEDs OFF */
75-
#define LED_GREEN_OFF() (gpio_clear(GPIOD, GPIO12))
76-
#define LED_ORANGE_OFF() (gpio_clear(GPIOD, GPIO13))
77-
#define LED_RED_OFF() (gpio_clear(GPIOD, GPIO14))
78-
#define LED_BLUE_OFF() (gpio_clear(GPIOD, GPIO15))
76+
#define LED_GREEN_OFF() (gpio_clear(GPIOD, GPIO12))
77+
#define LED_ORANGE_OFF() (gpio_clear(GPIOD, GPIO13))
78+
#define LED_RED_OFF() (gpio_clear(GPIOD, GPIO14))
79+
#define LED_BLUE_OFF() (gpio_clear(GPIOD, GPIO15))
7980

8081

8182

8283

8384
/* ------------- Local functions prototypes --------------- */
8485

85-
static void gpio_setup (void);
86-
static void spi_setup (void);
87-
static void LIS3DSH_init (void);
88-
static void LIS3DSH_write_reg (int, int);
89-
static int LIS3DSH_read_reg (int);
90-
static inline int twoComplToInt16 (int);
86+
static void gpio_setup(void);
87+
static void spi_setup(void);
88+
static void LIS3DSH_init(void);
89+
static void LIS3DSH_write_reg(int, int);
90+
static int LIS3DSH_read_reg(int);
91+
static inline int twoComplToInt16(int);
9192

9293

9394

@@ -100,8 +101,9 @@ static void gpio_setup(void)
100101
/* Enable GPIOD clock. */
101102
rcc_periph_clock_enable(RCC_GPIOD);
102103

103-
/* Set GPIO12, GPIO13, GPIO14, GPIO15 (in GPIO port D) to 'output push-pull'. */
104-
gpio_mode_setup(GPIOD, GPIO_MODE_OUTPUT, GPIO_PUPD_NONE, GPIO12 | GPIO13 | GPIO14 | GPIO15);
104+
/* Set GPIO12/13/14/15 (in GPIO port D) to 'output push-pull'. */
105+
gpio_mode_setup(GPIOD, GPIO_MODE_OUTPUT, GPIO_PUPD_NONE,
106+
GPIO12 | GPIO13 | GPIO14 | GPIO15);
105107

106108
/* LIS3DSH pins map:
107109
PA5 - SPI1_SCK
@@ -113,9 +115,11 @@ static void gpio_setup(void)
113115
/* Enable GPIOA clock. */
114116
rcc_periph_clock_enable(RCC_GPIOA);
115117
/* set SPI pins as CLK, MOSI, MISO */
116-
gpio_mode_setup(GPIOA, GPIO_MODE_AF, GPIO_PUPD_NONE, GPIO5 | GPIO6 | GPIO7);
118+
gpio_mode_setup(GPIOA, GPIO_MODE_AF, GPIO_PUPD_NONE,
119+
GPIO5 | GPIO6 | GPIO7);
117120
/* Push Pull, Speed 100 MHz */
118-
gpio_set_output_options(GPIOA, GPIO_OTYPE_PP, GPIO_OSPEED_100MHZ, GPIO5 | GPIO6 | GPIO7);
121+
gpio_set_output_options(GPIOA, GPIO_OTYPE_PP, GPIO_OSPEED_100MHZ,
122+
GPIO5 | GPIO6 | GPIO7);
119123
/* Alternate Function: SPI1 */
120124
gpio_set_af(GPIOA, GPIO_AF5, GPIO5 | GPIO6 | GPIO7);
121125

@@ -124,7 +128,8 @@ static void gpio_setup(void)
124128
/* set CS as OUTPUT */
125129
gpio_mode_setup(GPIOE, GPIO_MODE_OUTPUT, GPIO_PUPD_NONE, GPIO3);
126130
/* Push Pull, Speed 100 MHz */
127-
gpio_set_output_options(GPIOE, GPIO_OTYPE_PP, GPIO_OSPEED_100MHZ, GPIO3);
131+
gpio_set_output_options(GPIOE, GPIO_OTYPE_PP,
132+
GPIO_OSPEED_100MHZ, GPIO3);
128133
/* set CS high */
129134
gpio_set(GPIOE, GPIO3);
130135
}
@@ -153,32 +158,29 @@ static void spi_setup(void)
153158
/* Function to initialise the LIS3DSH */
154159
static void LIS3DSH_init(void)
155160
{
156-
int intRegValue;
161+
int int_reg_value;
157162

158163
/* init SPI1 */
159164
spi_setup();
160165

161166
/* get WHO AM I value */
162-
intRegValue = LIS3DSH_read_reg(ADD_REG_WHO_AM_I);
167+
int_reg_value = LIS3DSH_read_reg(ADD_REG_WHO_AM_I);
163168

164169
/* if WHO AM I value is the expected one */
165-
if( intRegValue == UC_WHO_AM_I_DEFAULT_VALUE )
166-
{
170+
if (int_reg_value == UC_WHO_AM_I_DEFAULT_VALUE) {
167171
/* set output data rate to 400 Hz and enable X,Y,Z axis */
168172
LIS3DSH_write_reg(ADD_REG_CTRL_4, UC_ADD_REG_CTRL_4_CFG_VALUE);
169173
/* verify written value */
170-
intRegValue = LIS3DSH_read_reg(ADD_REG_CTRL_4);
174+
int_reg_value = LIS3DSH_read_reg(ADD_REG_CTRL_4);
171175
/* if written value is different */
172-
if( intRegValue != UC_ADD_REG_CTRL_4_CFG_VALUE )
173-
{
176+
if (int_reg_value != UC_ADD_REG_CTRL_4_CFG_VALUE) {
174177
/* ERROR: stay here... */
175-
while(1);
178+
while (1);
176179
}
177180
}
178-
else
179-
{
181+
else {
180182
/* ERROR: stay here... */
181-
while(1);
183+
while (1);
182184
}
183185
}
184186

@@ -199,42 +201,40 @@ static void LIS3DSH_write_reg(int reg, int data)
199201
/* Function to read a register from LIS3DSH through SPI */
200202
static int LIS3DSH_read_reg(int reg)
201203
{
202-
int regValue;
204+
int reg_value;
203205
/* set CS low */
204206
gpio_clear(GPIOE, GPIO3);
205-
regValue = spi_xfer(SPI1, SET_READ_SINGLE_CMD(reg));
206-
regValue = spi_xfer(SPI1, 0xFF);
207+
reg_value = spi_xfer(SPI1, SET_READ_SINGLE_CMD(reg));
208+
reg_value = spi_xfer(SPI1, 0xFF);
207209
/* set CS high */
208210
gpio_set(GPIOE, GPIO3);
209211

210-
return regValue;
212+
return reg_value;
211213
}
212214

213215

214216
/* Transform a two's complement value to 16-bit int value */
215-
static inline int twoComplToInt16(int twoComplValue)
217+
static inline int twoComplToInt16(int two_compl_value)
216218
{
217-
int int16Value = 0;
219+
int int16_value = 0;
218220

219221
/* conversion */
220-
if(twoComplValue > 32768)
221-
{
222-
int16Value = -(((~twoComplValue) & 0xFFFF) + 1);
222+
if (two_compl_value > 32768) {
223+
int16_value = -(((~two_compl_value) & 0xFFFF) + 1);
223224
}
224-
else
225-
{
226-
int16Value = twoComplValue;
225+
else {
226+
int16_value = two_compl_value;
227227
}
228228

229-
return int16Value;
229+
return int16_value;
230230
}
231231

232232

233233
/* Main function */
234234
int main(void)
235235
{
236236
int i;
237-
int intValueMgX, intValueMgY, intValueMgZ;
237+
int value_mg_x, value_mg_y, value_mg_z;
238238

239239
/* setup all GPIOs */
240240
gpio_setup();
@@ -243,70 +243,66 @@ int main(void)
243243
LIS3DSH_init();
244244

245245
/* infinite loop */
246-
while(1)
247-
{
246+
while (1) {
248247
/* get X, Y, Z values */
249-
intValueMgX = ((LIS3DSH_read_reg(ADD_REG_OUT_X_H) << 8) | LIS3DSH_read_reg(ADD_REG_OUT_X_L));
250-
intValueMgY = ((LIS3DSH_read_reg(ADD_REG_OUT_Y_H) << 8) | LIS3DSH_read_reg(ADD_REG_OUT_Y_L));
251-
intValueMgZ = ((LIS3DSH_read_reg(ADD_REG_OUT_Z_H) << 8) | LIS3DSH_read_reg(ADD_REG_OUT_Z_L));
248+
value_mg_x = ((LIS3DSH_read_reg(ADD_REG_OUT_X_H) << 8) |
249+
LIS3DSH_read_reg(ADD_REG_OUT_X_L));
250+
value_mg_y = ((LIS3DSH_read_reg(ADD_REG_OUT_Y_H) << 8) |
251+
LIS3DSH_read_reg(ADD_REG_OUT_Y_L));
252+
value_mg_z = ((LIS3DSH_read_reg(ADD_REG_OUT_Z_H) << 8) |
253+
LIS3DSH_read_reg(ADD_REG_OUT_Z_L));
252254

253255
/* transform X value from two's complement to 16-bit int */
254-
intValueMgX = twoComplToInt16(intValueMgX);
256+
value_mg_x = twoComplToInt16(value_mg_x);
255257
/* convert X absolute value to mg value */
256-
intValueMgX = intValueMgX * SENS_2G_RANGE_MG_PER_DIGIT;
258+
value_mg_x = value_mg_x * SENS_2G_RANGE_MG_PER_DIGIT;
257259

258260
/* transform Y value from two's complement to 16-bit int */
259-
intValueMgY = twoComplToInt16(intValueMgY);
261+
value_mg_y = twoComplToInt16(value_mg_y);
260262
/* convert Y absolute value to mg value */
261-
intValueMgY = intValueMgY * SENS_2G_RANGE_MG_PER_DIGIT;
263+
value_mg_y = value_mg_y * SENS_2G_RANGE_MG_PER_DIGIT;
262264

263265
/* transform Z value from two's complement to 16-bit int */
264-
intValueMgZ = twoComplToInt16(intValueMgZ);
266+
value_mg_z = twoComplToInt16(value_mg_z);
265267
/* convert Z absolute value to mg value */
266-
intValueMgZ = intValueMgZ * SENS_2G_RANGE_MG_PER_DIGIT;
268+
value_mg_z = value_mg_z * SENS_2G_RANGE_MG_PER_DIGIT;
267269

268270
/* set X related LEDs according to specified threshold */
269-
if(intValueMgX >= LED_TH_MG)
270-
{
271+
if (value_mg_x >= LED_TH_MG) {
271272
LED_BLUE_OFF();
272273
LED_ORANGE_OFF();
273274
LED_GREEN_OFF();
274275
LED_RED_ON();
275276
}
276-
else if(intValueMgX <= -LED_TH_MG)
277-
{
277+
else if (value_mg_x <= -LED_TH_MG) {
278278
LED_BLUE_OFF();
279279
LED_ORANGE_OFF();
280280
LED_RED_OFF();
281281
LED_GREEN_ON();
282282
}
283283

284284
/* set Y related LEDs according to specified threshold */
285-
if(intValueMgY >= LED_TH_MG)
286-
{
285+
if (value_mg_y >= LED_TH_MG) {
287286
LED_BLUE_OFF();
288287
LED_RED_OFF();
289288
LED_GREEN_OFF();
290289
LED_ORANGE_ON();
291290
}
292-
else if(intValueMgY <= -LED_TH_MG)
293-
{
291+
else if (value_mg_y <= -LED_TH_MG) {
294292
LED_RED_OFF();
295293
LED_GREEN_OFF();
296294
LED_ORANGE_OFF();
297295
LED_BLUE_ON();
298296
}
299297

300298
/* set Z related LEDs according to specified threshold */
301-
if(intValueMgZ >= LED_TH_MG)
302-
{
299+
if (value_mg_z >= LED_TH_MG) {
303300
LED_BLUE_ON();
304301
LED_ORANGE_ON();
305302
LED_RED_ON();
306303
LED_GREEN_ON();
307304
}
308-
else if(intValueMgZ <= -LED_TH_MG)
309-
{
305+
else if (value_mg_z <= -LED_TH_MG) {
310306
LED_BLUE_OFF();
311307
LED_ORANGE_OFF();
312308
LED_RED_OFF();

0 commit comments

Comments
 (0)