fix: code smells

Author: Gilles Grousset

dart-lang/src/main/java/fr/insideapp/sonarqube/dart/lang/issues/dartanalyzer/DartAnalyzerSensor.java

@@ -66,9 +66,12 @@ public void execute(SensorContext sensorContext) {
             final PubSpec pubSpec = PubSpecParser.parse(sensorContext);
             final AnalyzerOutput output = AnalyzerExecutable.create(sensorContext, pubSpec).analyze();
 
-            final DartAnalyzerReportParser parser = output.getAnalyzerMode().equals(AnalyzerExecutable.Mode.FLUTTER) ?
-                    new FlutterAnalyzerReportParser() : output.getMode().equals(AnalyzerOutput.Mode.MACHINE)
-                    ? new DartAnalyzerMachineReportParser() : new DartAnalyzerLegacyReportParser();
+            DartAnalyzerReportParser parser = new FlutterAnalyzerReportParser();
+
+            if (!output.getAnalyzerMode().equals(AnalyzerExecutable.Mode.FLUTTER)) {
+                parser = output.getMode().equals(AnalyzerOutput.Mode.MACHINE)
+                        ? new DartAnalyzerMachineReportParser() : new DartAnalyzerLegacyReportParser();
+            }
 
             final List<DartAnalyzerReportIssue> issues = parser.parse(output.getContent());
 

dart-lang/src/main/java/fr/insideapp/sonarqube/dart/lang/issues/dartanalyzer/FlutterAnalyzerReportParser.java

@@ -29,7 +29,7 @@ public List<DartAnalyzerReportIssue> parse(String input) {
         List<DartAnalyzerReportIssue> issues = new ArrayList<>();
 
         String[] lines = input.split(System.getProperty("line.separator"));
-        Pattern pattern = Pattern.compile("(hint|lint|info|warning|error)(.*)(-|•)(.*)(-|•)(.*):(.*):(.*)(-|•)(.*)");
+        Pattern pattern = Pattern.compile("(hint|lint|info|warning|error)(.*)([-•])(.*)([-•])(.*):(.*):(.*)([-•])(.*)");
         for (int i = 0; i < lines.length; i++) {
             Matcher matcher = pattern.matcher(lines[i]);
             while (matcher.find()) {

dart-lang/src/main/java/fr/insideapp/sonarqube/dart/lang/issues/dartanalyzer/executable/AnalyzerExecutable.java

@@ -99,10 +99,6 @@ public AnalyzerOutput analyze() throws IOException {
     }
 
     private void maybeThrowException(ProcResult result) {
-        /*final String errorString = result.getErrorString();
-        if (errorString != null && !errorString.isEmpty()) {
-            throw new IllegalStateException(String.format("Error while running '%s' (exit %s): %s", result.getProcString(), result.getExitValue(), errorString));
-        }*/
         if (result.getExitValue() != 0) {
             throw new IllegalStateException(String.format("Error while running '%s' (exit %s): %s", result.getProcString(), result.getExitValue(), result.getErrorString()));
         }