type conversion

Author: ddsjoberg

NEWS.md

@@ -2,6 +2,8 @@
 
 * Added function `ard_incidence_rate()` to calculate ARDs for incidence rate estimation. (#234)
 
+* Fix in `ard_survival_survfit.data.frame()` method where the stratifying variable was not correctly converted back to its original type.
+
 # cardx 0.2.4
 
 ## New Features and Updates

R/ard_continuous.survey.design.R

@@ -376,7 +376,8 @@ accepted_svy_stats <- function(expand_quantiles = TRUE) {
 
   ard_nested <- ard |>
     tidyr::nest(..ard_data... = -c(cards::all_ard_groups(), cards::all_ard_variables())) |>
-    dplyr::arrange(across(c(cards::all_ard_groups(), cards::all_ard_variables()), unlist))
+    dplyr::arrange(across(c(cards::all_ard_groups(), cards::all_ard_variables()),
+                          ~ map(., as.character) |> unlist()))
 
   # if all columns match, then replace the coerced character cols with their original type/class
   all_cols_equal <-

tests/testthat/test-ard_survival_survfit.R

@@ -276,6 +276,24 @@ test_that("ard_survival_survfit.data.frame() works as expected", {
       class(),
     class(mtcars$vs)
   )
+
+  # adding another check type
+  expect_silent(
+    tbl <-
+      ard_survival_survfit(
+        x = cards::ADTTE,
+        variables = "TRTA",
+        y = "survival::Surv(time = AVAL, event = 1 - CNSR, type = 'right', origin = 0)",
+        times = c(6, 12)
+      )
+  )
+  expect_equal(
+    cards::rename_ard_columns(tbl) |>
+      dplyr::pull("TRTA") |>
+      class(),
+    class(cards::ADTTE$TRTA)
+  )
+
 })
 
 test_that("ard_survival_survfit.data.frame(variables=NULL) for unstratified model", {