setup-r-deps: replace `github-token` param with `GITHUB_PAT` env var #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cicdguy merged 3 commits into main from setup_r_deps_gh_pat

Nov 7, 2024

Contributor

pawelru commented Nov 7, 2024 •

edited

Loading

Fix the issue when private repos cannot be accessed: https://github.com/insightsengineering/citril/actions/runs/11717635984/job/32642879518?pr=464

github-token was not used and removed in a companion PR: remove parameter github-token setup-r-dependencies#17
set up GITHUB_ENV on setup-r-deps use


          setup-r-deps: replace github-token param with GITHUB_PAT env var

fc68ca4

pawelru marked this pull request as ready for review

November 7, 2024 10:22

pawelru requested a review from a team as a code owner

November 7, 2024 10:22

Contributor Author

pawelru commented Nov 7, 2024

tests succeeded: https://github.com/insightsengineering/citril/actions/runs/11720908954/job/32647246786

pawelru commented

View reviewed changes

.github/workflows/bioccheck.yaml Outdated Show resolved Hide resolved

pawelru commented

View reviewed changes

.github/workflows/build-check-install.yaml Outdated Show resolved Hide resolved

pawelru commented

View reviewed changes

.github/workflows/pkgdown.yaml Outdated Show resolved Hide resolved

pawelru commented

View reviewed changes

.github/workflows/revdepcheck.yaml Outdated Show resolved Hide resolved

pawelru commented

View reviewed changes

.github/workflows/rhub.yaml Outdated Show resolved Hide resolved

pawelru commented

View reviewed changes

.github/workflows/rhub.yaml Outdated Show resolved Hide resolved

pawelru commented

View reviewed changes

.github/workflows/roxygen.yaml Outdated Show resolved Hide resolved

pawelru commented

View reviewed changes

.github/workflows/test-coverage.yaml Outdated Show resolved Hide resolved

pawelru commented

View reviewed changes

.github/workflows/validation.yaml Outdated Show resolved Hide resolved


          Apply suggestions from code review

9434b53

Signed-off-by: Pawel Rucki <[email protected]>

Contributor

github-actions bot commented Nov 7, 2024 •

edited

Loading

Unit Tests Summary

3 tests 3 ✅ 6s ⏱️
3 suites 0 💤
1 files 0 ❌

Results for commit e376bcd.

♻️ This comment has been updated with latest results.

m7pr approved these changes

View reviewed changes

Contributor

m7pr left a comment

If you meant to set it as env global environment so it can be used in the R session, and not as a configuration parameter of the job, then this is OK!

m7pr self-assigned this

m7pr added the core label

m7pr mentioned this pull request

use setup-r-dependencies action insightsengineering/tlg-catalog#279

Merged


          Merge branch 'main' into setup_r_deps_gh_pat

e376bcd

cicdguy approved these changes

View reviewed changes

cicdguy merged commit d45f912 into main

26 checks passed

cicdguy deleted the setup_r_deps_gh_pat branch

November 7, 2024 13:26

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

core