Skip to content

Conversation

@pawelru
Copy link
Contributor

@pawelru pawelru commented Nov 13, 2024

Pull Request

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@llrs-roche
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@m7pr
Copy link
Contributor

m7pr commented Nov 13, 2024

I see that action for this PR is green
https://github.com/insightsengineering/r.pkg.template/actions/runs/11816560697

@llrs-roche
Copy link
Contributor

Yes, but now we need to test that the changes work on an actual PR: after help from Pawl to understand how it works, I temporary modified the github action on one of the PR where it fails: insightsengineering/teal@69ac901 and re-run the actions.

If insightsengineering/setup-r-dependencies#19 fixes the issues we need to ask for merging, if not iterate till the setup-r-actions is fixed.

@llrs-roche
Copy link
Contributor

Thanks both for the help. At the end using a branch without @ and changing the testing PR from draft to ready for review worked well to test changes on the CI setup.

As this has been merged and released on a rolling version it will be picked up by the teal repositories and this PR doesn't need to be merged.

@llrs-roche llrs-roche closed this Nov 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants