Add a blocking note for missing VignetteBuilder engine #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llrs-roche unsure if we are using blocklist for NOTES from the template or from YAML specifications, but there are also some NOTES blacklisted directly in repositories https://github.com/insightsengineering/teal/blob/main/.github/workflows/check.yaml#L34 |
|
Yes, I know there are some blocklist for NOTES in repositories, this PR comes after one of them: insightsengineering/teal.reporter#291 but Pawel suggested to have this on the template. As this is an easy to fix NOTE. |
Unit Tests Summary3 tests 3 ✅ 6s ⏱️ Results for commit 6af9741. |
cicdguy
approved these changes
Feb 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Following insightsengineering/teal.reporter#288 this PR add this note as a blocking note.
I added the note to several workflows (based on a PR on other repositories), let me know if this is a good approach.