Skip to content

Commit 5f77d9d

Browse files
committed
adjust warning messages
1 parent a277b2d commit 5f77d9d

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

R/qenv-get_warnings.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ setMethod("get_warnings", signature = c("qenv"), function(object) {
5252
sprintf(
5353
"~~~ Warnings ~~~\n\n%s\n\n~~~ Trace ~~~\n\n%s",
5454
paste(lines, collapse = "\n\n"),
55-
get_code(object)
55+
paste(get_code(object), collapse = "\n")
5656
)
5757
})
5858

tests/testthat/test-qenv_get_warnings.R

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ testthat::test_that("get_warnings accepts a qenv object with 2 warnings", {
2828
eval_code(bquote(warning("This is a warning 1!"))) %>%
2929
eval_code(bquote(warning("This is a warning 2!")))
3030
testthat::expect_identical(
31-
get_warnings(q), # TODO fix
31+
get_warnings(q),
3232
paste0(
3333
"~~~ Warnings ~~~\n\n> This is a warning 1!\nwhen running code:\nwarning(\"This is a warning 1!\")",
3434
"\n\n> This is a warning 2!\nwhen running code:\nwarning(\"This is a warning 2!\")\n\n",
@@ -42,11 +42,12 @@ testthat::test_that("get_warnings accepts a qenv object with a single eval_code
4242
warning("This is a warning 1!")
4343
warning("This is a warning 2!")
4444
}))
45-
testthat::expect_identical( # TODO fix
45+
testthat::expect_identical(
4646
get_warnings(q),
47-
c(
48-
"~~~ Warnings ~~~\n\n> This is a warning 1!\nwhen running code:\nwarning(\"This is a warning 1!\")\n\n> This is a warning 2!\nwhen running code:\nwarning(\"This is a warning 2!\")\n\n~~~ Trace ~~~\n\nwarning(\"This is a warning 1!\")",
49-
"~~~ Warnings ~~~\n\n> This is a warning 1!\nwhen running code:\nwarning(\"This is a warning 1!\")\n\n> This is a warning 2!\nwhen running code:\nwarning(\"This is a warning 2!\")\n\n~~~ Trace ~~~\n\nwarning(\"This is a warning 2!\")"
47+
paste0(
48+
"~~~ Warnings ~~~\n\n> This is a warning 1!\nwhen running code:\nwarning(\"This is a warning 1!\")",
49+
"\n\n> This is a warning 2!\nwhen running code:\nwarning(\"This is a warning 2!\")\n\n",
50+
"~~~ Trace ~~~\n\nwarning(\"This is a warning 1!\")\nwarning(\"This is a warning 2!\")"
5051
)
5152
)
5253
})

0 commit comments

Comments
 (0)