fix for verified/unverified teal_data

Author: gogonzo

R/utils-get_code_dependency.R

@@ -19,19 +19,19 @@
 #'
 #' @param code `character` with the code.
 #' @param names `character` vector of object names.
-#' @param check_names `logical(1)` flag specifying if a warning for non-existing names should be displayed.
+#' @param check_code_names `logical(1)` flag specifying if a warning for non-existing names should be displayed.
 #'
 #' @return Character vector, a subset of `code`.
 #' Note that subsetting is actually done on the calls `code`, not necessarily on the elements of the vector.
 #'
 #' @keywords internal
-get_code_dependency <- function(code, names, check_names = TRUE) {
+get_code_dependency <- function(code, names, check_code_names = TRUE) {
   checkmate::assert_list(code, "character")
   checkmate::assert_character(names, any.missing = FALSE)
 
   graph <- lapply(code, attr, "dependency")
 
-  if (check_names) {
+  if (check_code_names) {
     symbols <- unlist(lapply(graph, function(call) {
       ind <- match("<-", call, nomatch = length(call) + 1L)
       call[seq_len(ind - 1L)]

man/get_code_dependency.Rd

@@ -41,6 +41,28 @@ testthat::test_that("`[.` warns and subsets to existing if some names not presen
   )
 })
 
+testthat::test_that("`[.` warns if name is in code but not in env", {
+  data <- within(qenv(), {
+    a <- 1
+    b <- 2
+    c <- 3
+    d <- 4
+  })
+  data@code <- data@code[1]
+  testthat::expect_warning(data[c("a", "b", "c")])
+})
+
+testthat::test_that("`[.` doesn't warn if name is in code but not in env (secret feature for unverified teal_data)", {
+  data <- within(qenv(), {
+    a <- 1
+    b <- 2
+    c <- 3
+    d <- 4
+  })
+  data@code <- data@code[1]
+  testthat::expect_silent(data[c("a", "b", "c"), check_code_names = FALSE])
+})
+
 testthat::test_that("`[.` subsets environment and code to specified object names", {
   q <- qenv()
   code <- c("x<-1", "a<-1;b<-2")