Apply suggestions from code review

Co-authored-by: Dawid Kałędkowski <[email protected]>
Signed-off-by: André Veríssimo <[email protected]>

Author: averissimo

R/qenv-get_var.R

@@ -1,7 +1,7 @@
 #' Get object from `qenv`
 #'
 #' @description
-#' `r lifecycle::badge("superseded")` by native \R operators/functions:
+#' `r lifecycle::badge("deprecated")` by native \R operators/functions:
 #' `x[[name]]`, `x$name` or [get()].
 #'
 #' Retrieve variables from the `qenv` environment.
@@ -31,6 +31,7 @@ setGeneric("get_var", function(object, var) {
 
 setMethod("get_var", signature = c("qenv", "character"), function(object, var) {
   tryCatch(
+   lifecycle::deprecate_soft("0.5.1", "get_var()", "get()")
     get(var, envir = object@.xData, inherits = FALSE),
     error = function(e) {
       message(conditionMessage(e))

tests/testthat/test-qenv_join.R

@@ -68,8 +68,8 @@ testthat::test_that("join does not duplicate code but adds only extra code", {
   )
 
   testthat::expect_equal(
-    as.list(q@.xData),
-    list(iris1 = iris, iris2 = iris, mtcars1 = mtcars, mtcars2 = mtcars)
+    q@.xData,
+    list2env(list(iris1 = iris, iris2 = iris, mtcars1 = mtcars, mtcars2 = mtcars))
   )
 
   testthat::expect_identical(q@id, c(q1@id, q2@id[2]))