Skip to content

Conversation

@m7pr
Copy link
Contributor

@m7pr m7pr commented Aug 19, 2025

Sets digest to 0.6.37 in scheduled.yaml.
Failed job: https://github.com/insightsengineering/teal.code/actions/runs/17046674787
Attempts on fixing the job:
1 - https://github.com/insightsengineering/teal.code/actions/runs/17064114596
2 - https://github.com/insightsengineering/teal.code/actions/runs/17064412291

It's rmarkdown that depends on bslib and digest.
It depends on the old version of bslib (0.2.5.1) and it tries to install 0.5.0 during the check, and for the digest there is no dependency version so it tries to build 0.6.32 which is not enought.

The idea is to support digest 0.6.37 and bslib 0.8.0 (sass 0.4.9)

@m7pr m7pr added the core label Aug 19, 2025
@m7pr m7pr marked this pull request as ready for review August 19, 2025 09:05
@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------
R/qenv-c.R                          55       0  100.00%
R/qenv-class.R                      13       0  100.00%
R/qenv-concat.R                      7       0  100.00%
R/qenv-constructor.R                 1       0  100.00%
R/qenv-errors.R                      4       4  0.00%    6-9
R/qenv-eval_code.R                  60       1  98.33%   40
R/qenv-extract.R                    30       0  100.00%
R/qenv-get_code.R                   24       0  100.00%
R/qenv-get_env.R                     3       1  66.67%   27
R/qenv-get_messages.r                5       0  100.00%
R/qenv-get_outputs.R                 6       0  100.00%
R/qenv-get_var.R                    13       1  92.31%   13
R/qenv-get_warnings.R                5       0  100.00%
R/qenv-join.R                        1       1  0.00%    13
R/qenv-length.R                      2       1  50.00%   2
R/qenv-show.R                       29      29  0.00%    19-50
R/qenv-within.R                      8       0  100.00%
R/utils-get_code_dependency.R      254       3  98.82%   160, 258, 331
R/utils.R                           42       0  100.00%
TOTAL                              562      41  92.70%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 18e4afc

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2025

Unit Tests Summary

  1 files   14 suites   6s ⏱️
171 tests 168 ✅ 3 💤 0 ❌
254 runs  251 ✅ 3 💤 0 ❌

Results for commit 18e4afc.

♻️ This comment has been updated with latest results.

@gogonzo
Copy link
Contributor

gogonzo commented Aug 19, 2025

do we need to change teal.data once this is merged? Installation of teal.code would fix dependency issue so maybe it is not needed to duplicate this code in downstream packages?

@m7pr
Copy link
Contributor Author

m7pr commented Aug 20, 2025

@gogonzo even though both those packages clashed for their Scheduled jobs, this needs to be applied in both of them.
In teal.data it was with+checkmate (1st level dependencies) + sass (2nd level dependency), but in here it's sass+digest (2nd level dependency).

The 2nd level dependencies can be only controlled by setting the requirements for the environment via extra-deps.
Requirements for the environment for the jobs in this repo will not be used in the jobs in repo to teal.data.

@m7pr m7pr merged commit 29ab1f4 into main Aug 20, 2025
58 checks passed
@m7pr m7pr deleted the fix_scheduled_jobs branch August 20, 2025 08:32
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants