Keeps last value of `eval_code()`/`within()` #257

averissimo · 2025-06-12T10:13:01Z

New feature for teal.code that keeps the last value of the code evaluation.

In line with R's .Last.value (see doc)

pkgload::load_all("../teal.code")
#> ℹ Loading teal.code

q <- qenv() |> within({
  1+1
}) |> within({
  aa <- 2
})
q
#> <environment: 0x616d80da6ec0> 🔒 
#> Parent: <environment: devtools_shims> 
#> Bindings:
#> - aa: [numeric]

q@.xData |> attributes()
#> $.Last.value
#> [1] 2

library(dplyr) |> suppressPackageStartupMessages()

q2 <- q |> within(
  bb <- 3
)
q2
#> <environment: 0x616d80725698> 🔒 
#> Parent: <environment: package:dplyr> 
#> Bindings:
#> - aa: [numeric]
#> - bb: [numeric]
q2@.xData |> attributes()
#> $.Last.value
#> [1] 3

Cloning

rlang::env_clone(as.environment(q2)) |> attributes()
#> NULL

^{Created on 2025-06-12 with reprex v2.1.1}

…ions

Code balance is + because I've added one test ;]

Companion to insightsengineering/teal.reporter#334 Consequence of changing naming convention for `teal_report` object.

averissimo · 2025-06-12T10:21:06Z

Should we add a getter function?

gogonzo · 2025-06-12T10:21:06Z

R/qenv-eval_code.R

        {
-          eval(current_call, envir = object@.xData)
+          .Last.value <- eval(current_call, envir = object@.xData)
+          attr(object@.xData, ".Last.value") <- .Last.value


Comparing to base - .Last.value isn't an attribute but an object of the .GlobalEnv

Hmmm, even worse. .Last.value is an object in base and not assigned to any environment :/

a <- "a" c <- "c" a base::.Last.value # [1] "a"

Yes, we cannot fully reproduce it, it would just follow the concept.

…table * origin/main: [skip actions] Bump version to 0.6.1.9003 `{teal}` module returns a `teal_report` object that extends from `teal_data` (#255)

github-actions · 2025-06-12T15:30:57Z

Unit Tests Summary

1 files 13 suites 4s ⏱️
159 tests 156 ✅ 3 💤 0 ❌
249 runs 246 ✅ 3 💤 0 ❌

Results for commit d6c9c0d.

♻️ This comment has been updated with latest results.

github-actions · 2025-06-12T15:31:02Z

Unit Test Performance Difference

Additional test case details

Test Suite	$Status$	Time on `main`	$±Time$	Test Case
qenv_eval_code	👶		$+0.02$	eval_code_keeps_.Last.value_as_an_attribute_of_the_environment
qenv_within	👶		$+0.02$	within_keeps_.Last.value_as_an_attribute_of_the_environment

Results for commit bef1907

♻️ This comment has been updated with latest results.

github-actions · 2025-06-16T13:38:27Z

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ---------
R/qenv-c.R                          55       0  100.00%
R/qenv-class.R                      12       0  100.00%
R/qenv-concat.R                      7       0  100.00%
R/qenv-constructor.R                 1       0  100.00%
R/qenv-errors.R                      4       4  0.00%    6-9
R/qenv-eval_code.R                  62       1  98.39%   42
R/qenv-extract.R                    30       0  100.00%
R/qenv-get_code.R                   24       0  100.00%
R/qenv-get_env.R                     3       1  66.67%   27
R/qenv-get_messages.r                5       0  100.00%
R/qenv-get_var.R                    26       0  100.00%
R/qenv-get_warnings.R                5       0  100.00%
R/qenv-join.R                        7       7  0.00%    137-151
R/qenv-length.R                      2       1  50.00%   2
R/qenv-show.R                       29      29  0.00%    19-50
R/qenv-within.R                      8       0  100.00%
R/utils-get_code_dependency.R      245       2  99.18%   160, 258
R/utils.R                           30       0  100.00%
TOTAL                              555      45  91.89%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: d6c9c0d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

gogonzo

"Attribute of the environment" is not exactly what it is

gogonzo · 2025-06-16T13:38:30Z

tests/testthat/test-qenv_eval_code.R

  )
 })
+
+testthat::test_that("eval_code keeps .Last.value as an attribute of the environment", {


Suggested change

testthat::test_that("eval_code keeps .Last.value as an attribute of the environment", {

testthat::test_that("eval_code stores .Last.value in the parent environment", {

gogonzo · 2025-06-16T13:38:57Z

tests/testthat/test-qenv_within.R

  testthat::expect_identical(get_code(q), "a <- 1L")
 })
+
+testthat::test_that("within keeps .Last.value as an attribute of the environment", {


Suggested change

testthat::test_that("within keeps .Last.value as an attribute of the environment", {

testthat::test_that("within eval_code stores .Last.value in the parent environment", {

gogonzo · 2025-06-16T13:39:47Z

tests/testthat/test-qenv_within.R

+testthat::test_that("within keeps .Last.value as an attribute of the environment", {
+  q <- within(qenv(), x <- 1)
+  env <- parent.env(q)
+  testthat::expect_true(".Last.value" %in% names(env))


This line is not needed as the next one confirms this also

Suggested change

testthat::expect_true(".Last.value" %in% names(env))

gogonzo · 2025-06-16T13:39:57Z

tests/testthat/test-qenv_eval_code.R

+testthat::test_that("eval_code keeps .Last.value as an attribute of the environment", {
+  q <- eval_code(qenv(), quote(x <- 1))
+  env <- parent.env(q)
+  testthat::expect_true(".Last.value" %in% names(env))


This line is not needed as the next one confirms this also

Suggested change

testthat::expect_true(".Last.value" %in% names(env))

gogonzo · 2025-06-16T13:41:39Z

NEWS.md


+### Enhancements
+
+* Code evaluation keeps the last evaluated expression in the `.Last.value` attribute of the environment.


Suggested change

* Code evaluation keeps the last evaluated expression in the `.Last.value` attribute of the environment.

* Code evaluation keeps the last evaluated expression in the `parent.env(<qenv>)$.Last.value`.

gogonzo

I think this is the best proposition so far. I don't think we will be able or it will be worth it to follow the rmarkdown concept of fetching everything like it was called line by line in the interactive session:

I think it is a good compromise easy to cache always the .Last.value in qenv. We will work on the teal.reporter followup implementation of this 👍

averissimo · 2025-06-18T13:56:24Z

@gogonzo Should we pause/discard this PR given your new discovery late yesterday and our call today in favor of using evaluate::evaluate() with custom handler.

This could live as its own feature though.

averissimo · 2025-06-25T15:04:14Z

Closed in favor of #259

gogonzo and others added 14 commits May 27, 2025 12:05

eval_code(cache

fb5cf2b

chore: eval_code methods no longer depend on second argument

6971dca

cleanup: remove logger calls

7abc267

cleanup: remove method from eval_code and removal of unecessary funct…

a075fce

…ions

chore: remove code dispatch parameter in eval_code

78396d6

fix cache for expression and tidyup

bb1ab11

Improvements (i hope so) (#254)

2eab262

Code balance is + because I've added one test ;]

Naming (#256)

7959973

Companion to insightsengineering/teal.reporter#334 Consequence of changing naming convention for `teal_report` object.

[skip roxygen] [skip vbump] Roxygen Man Pages Auto Update

5605340

test of the keep_output

3cd6246

test within(keep_output)

7e1f07a

cleanup: remove keep_output

0110716

docs: update documentation

f08c90b

feat: keep last value of eval_code/within

e7d2759

averissimo added the core label Jun 12, 2025

docs: add entry to NEWS

909c0f0

averissimo requested a review from gogonzo June 12, 2025 10:18

gogonzo reviewed Jun 12, 2025

View reviewed changes

Base automatically changed from teal_reportable to main June 12, 2025 14:44

averissimo added 3 commits June 12, 2025 16:20

Merge remote-tracking branch 'origin/main' into last_value@teal_repor…

c8ec257

…table * origin/main: [skip actions] Bump version to 0.6.1.9003 `{teal}` module returns a `teal_report` object that extends from `teal_data` (#255)

feat: change to keep .Last.value in parent environment

25f6a4f

docs: regenerate

be517a3

fix: parent env should be created after execution

d6c9c0d

gogonzo reviewed Jun 16, 2025

View reviewed changes

gogonzo reviewed Jun 17, 2025

View reviewed changes

averissimo closed this Jun 25, 2025

github-actions bot locked and limited conversation to collaborators Jun 25, 2025

averissimo deleted the last_value@teal_reportable branch June 25, 2025 15:04

	testthat::test_that("eval_code keeps .Last.value as an attribute of the environment", {
	testthat::test_that("eval_code stores .Last.value in the parent environment", {

	testthat::test_that("within keeps .Last.value as an attribute of the environment", {
	testthat::test_that("within eval_code stores .Last.value in the parent environment", {


		### Enhancements

		* Code evaluation keeps the last evaluated expression in the `.Last.value` attribute of the environment.

Uh oh!

Keeps last value of eval_code()/within() #257

Keeps last value of eval_code()/within() #257

Uh oh!

Conversation

averissimo commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

averissimo commented Jun 12, 2025

Uh oh!

gogonzo Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

gogonzo Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

averissimo Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Tests Summary

Uh oh!

github-actions bot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Performance Difference

Uh oh!

github-actions bot commented Jun 16, 2025

Code Coverage Summary

Diff against main

Uh oh!

gogonzo left a comment

Choose a reason for hiding this comment

Uh oh!

gogonzo Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

gogonzo Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

gogonzo Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

gogonzo Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

gogonzo Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

gogonzo left a comment

Choose a reason for hiding this comment

Uh oh!

averissimo commented Jun 18, 2025

Uh oh!

averissimo commented Jun 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Keeps last value of `eval_code()`/`within()` #257

Keeps last value of `eval_code()`/`within()` #257

averissimo commented Jun 12, 2025 •

edited

Loading

gogonzo Jun 12, 2025 •

edited

Loading

github-actions bot commented Jun 12, 2025 •

edited

Loading

github-actions bot commented Jun 12, 2025 •

edited

Loading