Skip to content

Refactor UI tests for tm_t_events* modules #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
llrs-roche merged 9 commits into from
Nov 26, 2025
+14 −9
Merged

Refactor UI tests for tm_t_events* modules #1443

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1a49730
Refactor UI tests
llrs-roche Nov 25, 2025
7679878
Merge branch 'bring_tests' into tm_t_events
m7pr Nov 25, 2025
306b28e
Use shorter selector
llrs-roche Nov 25, 2025
fa635f7
Merge branch 'tm_t_events' of github.com:insightsengineering/teal.mod…
llrs-roche Nov 25, 2025
c536120
Merge branch 'bring_tests' into tm_t_events
llrs-roche Nov 25, 2025
da48899
Merge branch 'bring_tests' into tm_t_events
llrs-roche Nov 25, 2025
1da1f04
Fix lintr issues
llrs-roche Nov 25, 2025
06cfc20
Merge branch 'tm_t_events' of github.com:insightsengineering/teal.mod…
llrs-roche Nov 25, 2025
3506838
Merge branch 'bring_tests' into tm_t_events
llrs-roche Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/testthat/test-shinytest2-tm_t_events.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
app_driver <- app_driver_tm_t_events()

testthat::expect_equal(
app_driver$get_text("#teal-teal_modules-active_tab .active > a"),
app_driver$get_text("#teal-teal_modules-active_module_id * .teal-modules-tree * .nav-link"),
Copy link
Contributor

@m7pr m7pr Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llrs-roche
What do you think about this change that I made on other PR in similar place?
https://github.com/insightsengineering/teal.modules.clinical/pull/1441/files#diff-eea16ad04c22c49466b528d79edebfcb683d3f6f2a255581e007bcc8534c9e9cR65

Copy link
Contributor Author

@llrs-roche llrs-roche Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only realized of this later and used it in a different PR but I wanted to ask for your feedback.
I like that this one uses the id but yours is shorter which is also a plus.
Maybe the one with id is more tightly coupled and works better as a test if the UI changes but I let you decide

Copy link
Contributor

@m7pr m7pr Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llrs-roche my preference is the shorter the better : P
once you change this. you can merge to my branch

"Adverse Event Table"
)
testthat::expect_equal(
Expand Down Expand Up @@ -117,7 +117,7 @@
testthat::expect_identical(app_driver$get_active_module_table_output("table-table-with-settings"), data.frame())
app_driver$expect_validation_error()
testthat::expect_equal(
app_driver$get_text(app_driver$namespaces(TRUE)$module("arm_var-dataset_ADSL_singleextract-select_input .shiny-validation-message")),

Check warning on line 120 in tests/testthat/test-shinytest2-tm_t_events.R

View workflow job for this annotation

GitHub Actions / SuperLinter 🦸‍♀️ / Lint R code 🧶 

file=tests/testthat/test-shinytest2-tm_t_events.R,line=120,col=121,[line_length_linter] Lines should not be more than 120 characters. This line is 137 characters.
"Please select 1 or 2 treatment variable values"
)
app_driver$stop()
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-shinytest2-tm_t_events_by_grade.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
skip_if_too_deep(5)
app_driver <- app_driver_tm_t_events_by_grade()
testthat::expect_equal(
app_driver$get_text("#teal-teal_modules-active_tab .active > a"),
app_driver$get_text("#teal-teal_modules-active_module_id * .teal-modules-tree * .nav-link"),
"Adverse Events by Grade Table"
)
testthat::expect_equal(
Expand Down Expand Up @@ -130,7 +130,7 @@
testthat::expect_identical(app_driver$get_active_module_table_output("table-table-with-settings"), data.frame())
app_driver$expect_validation_error()
testthat::expect_equal(
app_driver$get_text(app_driver$namespaces(TRUE)$module("arm_var-dataset_ADSL_singleextract-select_input .shiny-validation-message")),

Check warning on line 133 in tests/testthat/test-shinytest2-tm_t_events_by_grade.R

View workflow job for this annotation

GitHub Actions / SuperLinter 🦸‍♀️ / Lint R code 🧶 

file=tests/testthat/test-shinytest2-tm_t_events_by_grade.R,line=133,col=121,[line_length_linter] Lines should not be more than 120 characters. This line is 137 characters.
"A treatment variable is required"
)
app_driver$stop()
Expand Down Expand Up @@ -233,7 +233,7 @@
testthat::expect_identical(app_driver$get_active_module_table_output("table-table-with-settings"), data.frame())
app_driver$expect_validation_error()
testthat::expect_equal(
app_driver$get_text(app_driver$namespaces(TRUE)$module("grade-dataset_ADAE_singleextract-select_input .shiny-validation-message")),

Check warning on line 236 in tests/testthat/test-shinytest2-tm_t_events_by_grade.R

View workflow job for this annotation

GitHub Actions / SuperLinter 🦸‍♀️ / Lint R code 🧶 

file=tests/testthat/test-shinytest2-tm_t_events_by_grade.R,line=236,col=121,[line_length_linter] Lines should not be more than 120 characters. This line is 135 characters.
"An event grade is required"
)
app_driver$stop()
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-shinytest2-tm_t_events_patyear.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
skip_if_too_deep(5)
app_driver <- app_driver_tm_t_events_patyear()
testthat::expect_equal(
app_driver$get_text("#teal-teal_modules-active_tab .active > a"),
app_driver$get_text("#teal-teal_modules-active_module_id * .teal-modules-tree * .nav-link"),
"AE Rate Adjusted for Patient-Years At Risk Table"
)
testthat::expect_equal(
Expand Down Expand Up @@ -169,7 +169,7 @@
)
app_driver$expect_validation_error()
testthat::expect_equal(
app_driver$get_text(app_driver$namespaces(TRUE)$module("arm_var-dataset_ADSL_singleextract-select_input .shiny-validation-message")),

Check warning on line 172 in tests/testthat/test-shinytest2-tm_t_events_patyear.R

View workflow job for this annotation

GitHub Actions / SuperLinter 🦸‍♀️ / Lint R code 🧶 

file=tests/testthat/test-shinytest2-tm_t_events_patyear.R,line=172,col=121,[line_length_linter] Lines should not be more than 120 characters. This line is 137 characters.
"Please select exactly 1 or 2 treatment variables"
)
app_driver$stop()
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-shinytest2-tm_t_events_summary.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
skip_if_too_deep(5)
app_driver <- app_driver_tm_t_events_summary()
testthat::expect_equal(
app_driver$get_text("#teal-teal_modules-active_tab .active > a"),
app_driver$get_text("#teal-teal_modules-active_module_id * .teal-modules-tree * .nav-link"),
"Adverse Events Summary"
)
testthat::expect_equal(
Expand Down Expand Up @@ -159,7 +159,7 @@
testthat::expect_identical(app_driver$get_active_module_table_output("table-table-with-settings"), data.frame())
app_driver$expect_validation_error()
testthat::expect_equal(
app_driver$get_text(app_driver$namespaces(TRUE)$module("arm_var-dataset_ADSL_singleextract-select_input .shiny-validation-message")),

Check warning on line 162 in tests/testthat/test-shinytest2-tm_t_events_summary.R

View workflow job for this annotation

GitHub Actions / SuperLinter 🦸‍♀️ / Lint R code 🧶 

file=tests/testthat/test-shinytest2-tm_t_events_summary.R,line=162,col=121,[line_length_linter] Lines should not be more than 120 characters. This line is 137 characters.
"Please select exactly 1 or 2 treatment variables"
)
app_driver$stop()
Expand Down
Loading