Skip to content

wip: fix e2e test on tm_g_pp functions #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m7pr merged 8 commits into from
Nov 27, 2025
Merged

wip: fix e2e test on tm_g_pp functions #1446

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
270387b
wip: fix some tests by changing selectors
Nov 25, 2025
ba287b4
Merge branch 'bring_tests' into fix_e2e_g_pp@bring_tests
llrs-roche Nov 25, 2025
aeaf694
chore: remove wip comments
Nov 25, 2025
1857bf1
fix: modify selectors and functions to get content in order to fix e2…
Nov 26, 2025
d9100ba
test: use more neutral selector
Nov 26, 2025
6aae7a5
refactor: use better selector and call method to compare messages
Nov 26, 2025
4f93677
fix: update selectors to use more general approach
Nov 26, 2025
2ce6ad5
Merge branch 'bring_tests' into fix_e2e_g_pp@bring_tests
m7pr Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/testthat/test-shinytest2-tm_g_pp_vitals.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ testthat::test_that(
app_driver <- app_driver_tm_g_pp_vitals()

testthat::expect_equal(
app_driver$get_text("#teal-teal_modules-active_tab .active > a"),
app_driver$get_text(".teal-modules-wrapper .module-button.active"),
"Vitals"
)
testthat::expect_equal(
Expand Down Expand Up @@ -118,6 +118,7 @@ testthat::test_that("e2e - tm_g_pp_vitals: Deselecting patient_id column throws
app_driver$stop()
})

#fails
Copy link
Contributor

@m7pr m7pr Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try adding app_driver$wait_for_idle() after app_driver <- app_driver_tm_g_pp_vitals().
And also check how I fixed similar tests on the feature branch
https://github.com/insightsengineering/teal.modules.clinical/pull/1441/files#r2565145226

Copy link
Author

@osenan osenan Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this was updated and it works, after trying the new teal version

testthat::test_that(
"e2e - tm_g_pp_vitals: Selecting valid paramcd and paramcd_levels_vals changes plot
and doesn't throw validation errors.",
Expand Down Expand Up @@ -170,6 +171,7 @@ testthat::test_that("e2e - tm_g_pp_vitals: Deselecting paramcd throws validation
app_driver$stop()
})

#fails
testthat::test_that("e2e - tm_g_pp_vitals: Selecting xaxis changes plot and doesn't throw validation errors.", {
skip_if_too_deep(5)
app_driver <- app_driver_tm_g_pp_vitals()
Expand Down Expand Up @@ -198,6 +200,7 @@ testthat::test_that("e2e - tm_g_pp_vitals: Deselecting xaxis column throws valid
app_driver$stop()
})

#fails
testthat::test_that("e2e - tm_g_pp_vitals: Selecting aval_var changes plot and doesn't throw validation errors.", {
skip_if_too_deep(5)
app_driver <- app_driver_tm_g_pp_vitals()
Expand Down
Loading