Remove ggmosaic from v0.5.0 (#935)

# Pull Request

<!--- Replace `#nnn` with your issue link for reference. -->

Fixes #932 

Removes ggmosaic dependency and updates code as required by the new
error message.

<img width="625" height="267" alt="image"
src="https://github.com/user-attachments/assets/c77ae1f0-17eb-446d-b925-aaa2018a8fda"
/>

Tested with released packages and also checked the app generated on the
vignette (using-bivariate-plot) still works well on all shown cases.

The user impact might be higher than initially thought as logical,
character an ordered classes also use ggmosaic due to
[L848](https://github.com/insightsengineering/teal.modules.general/pull/935/files#diff-a91c9cc30e476470275d1bd27bcd7e6d7440c5ca75daf9cb47dfc7062f3c9137R846).
As an alternative we could use `plot(table())` which is not ggplot2
based but works with factors and characters.

<details><summary>Reproducible example</summary>
<p>

```r
# general data example
devtools::load_all("../teal.modules.general")
library("teal.data")
data <- within(teal_data(), {
  CO2 <- data.frame(CO2)
})

init(
  data = data,
  modules = tm_g_bivariate(
    x = data_extract_spec(
      dataname = "CO2",
      select = select_spec(
        label = "Select variable:",
        choices = variable_choices(data[["CO2"]]),
        selected = "Type",
        fixed = FALSE
      )
    ),
    y = data_extract_spec(
      dataname = "CO2",
      select = select_spec(
        label = "Select variable:",
        choices = variable_choices(data[["CO2"]]),
        selected = "Treatment",
        multiple = FALSE,
        fixed = FALSE
      )
    )
  )
) |> runApp()
```


</p>
</details>

Author: llrs-roche

.pre-commit-config.yaml

@@ -15,7 +15,6 @@ repos:
       - id: roxygenize
         name: Regenerate package documentation
         additional_dependencies:
-          - ggmosaic
           - ggplot2
           - shiny
           - checkmate

DESCRIPTION

@@ -23,7 +23,6 @@ URL: https://insightsengineering.github.io/teal.modules.general/,
 BugReports:
     https://github.com/insightsengineering/teal.modules.general/issues
 Depends:
-    ggmosaic (>= 0.3.0),
     ggplot2 (>= 3.4.0),
     R (>= 4.1),
     shiny (>= 1.8.1),

NAMESPACE

@@ -25,7 +25,6 @@ export(tm_missing_data)
 export(tm_outliers)
 export(tm_t_crosstable)
 export(tm_variable_browser)
-import(ggmosaic)
 import(ggplot2)
 import(shiny)
 import(teal)

NEWS.md

@@ -1,3 +1,7 @@
+# teal.modules.general 0.5.1
+
+- Removed ggmosaic package dependency to avoid being archived on CRAN (#932).
+
 # teal.modules.general 0.5.0
 
 ### Breaking changes

R/teal.modules.general.R

@@ -4,7 +4,6 @@
 #' (not necessarily for clinical trials data).
 #'
 #' @import ggplot2
-#' @import ggmosaic
 #' @import shiny
 #' @import teal
 #' @import teal.transform
@@ -15,11 +14,5 @@
 #' @keywords internal
 "_PACKAGE"
 
-# nolint start
-# Note ggmosaic (version <= 0.3.3) needs to be in DEPENDS as the following does not work if it is imported
-# df <- data.frame(x = c("A", "B", "C", "A"), y = c("Z", "Z", "W", "W"))
-# ggplot(df) + ggmosaic::geom_mosaic(aes(x = ggmosaic::product(x), fill = y))
-# nolint end
-
 # Needed to avoid R CMD note on no visible binding
 utils::globalVariables("count")

R/tm_g_association.R

@@ -348,7 +348,7 @@ srv_tm_g_association <- function(id,
     )
 
     qenv <- reactive(
-      teal.code::eval_code(data(), 'library("ggplot2");library("dplyr");library("tern");library("ggmosaic")') # nolint quotes
+      teal.code::eval_code(data(), 'library("ggplot2");library("dplyr");library("tern")') # nolint quotes
     )
     anl_merged_q <- reactive({
       req(anl_merged_input())

R/tm_g_bivariate.R

@@ -968,13 +968,7 @@ bivariate_ggplot_call <- function(x_class,
     )
     # Factor and character plots
   } else if (x_class == "factor" && y_class == "factor") {
-    plot_call <- reduce_plot_call(
-      plot_call,
-      substitute(
-        ggmosaic::geom_mosaic(aes(x = ggmosaic::product(xval), fill = yval), na.rm = TRUE),
-        env = list(xval = x, yval = y)
-      )
-    )
+    stop("Categorical variables 'x' and 'y' are currently not supported.")
   } else {
     stop("x y type combination not allowed")
   }

inst/WORDLIST

@@ -8,6 +8,7 @@ UI
 datatables
 facetting
 funder
+ggmosaic
 ggplot
 pre
 qq

tests/testthat/test_bivariate_ggplot_call.R

@@ -19,33 +19,34 @@ testthat::test_that("bivariate_ggplot_call with numerics", {
 })
 
 testthat::test_that("bivariate_ggplot_call with factor, char, logical", {
-  testthat::expect_match(
+  error_message <- "Categorical variables 'x' and 'y' are currently not supported."
+  testthat::expect_error(
     bivariate_ggplot_call("factor", "factor") %>% deparse(width.cutoff = 300),
-    "geom_mosaic"
+    error_message
   )
-  testthat::expect_match(
+  testthat::expect_error(
     bivariate_ggplot_call("logical", "factor") %>% deparse(width.cutoff = 300),
-    "geom_mosaic"
-  )
-  testthat::expect_match(
+    error_message
+    )
+  testthat::expect_error(
     bivariate_ggplot_call("character", "factor") %>% deparse(width.cutoff = 300),
-    "geom_mosaic"
+    error_message
   )
-  testthat::expect_match(
+  testthat::expect_error(
     bivariate_ggplot_call("logical", "character") %>% deparse(width.cutoff = 300),
-    "geom_mosaic"
+    error_message
   )
-  testthat::expect_match(
+  testthat::expect_error(
     bivariate_ggplot_call("character", "logical") %>% deparse(width.cutoff = 300),
-    "geom_mosaic"
+    error_message
   )
-  testthat::expect_match(
+  testthat::expect_error(
     bivariate_ggplot_call("logical", "logical") %>% deparse(width.cutoff = 300),
-    "geom_mosaic"
+    error_message
   )
-  testthat::expect_match(
+  testthat::expect_error(
     bivariate_ggplot_call("character", "character") %>% deparse(width.cutoff = 300),
-    "geom\\_mosaic"
+    error_message
   )
 })